Received-SPF: pass (google.com: domain of linux-kernel+bounces-183925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <c2baeb4b-5cad-4cb9-a48e-0540f448cb15@intel.com>
Date: Mon, 20 May 2024 08:47:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V6 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency
To: <isaku.yamahata@intel.com>, <pbonzini@redhat.com>,
	<erdemaktas@google.com>, <vkuznets@redhat.com>, <seanjc@google.com>,
	<vannapurve@google.com>, <jmattson@google.com>, <mlevitsk@redhat.com>,
	<xiaoyao.li@intel.com>, <chao.gao@intel.com>, <rick.p.edgecombe@intel.com>,
	<yuan.yao@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <cover.1715017765.git.reinette.chatre@intel.com>
 <a2f7013646a8a1e314744568b9baa439682cbf8a.1715017765.git.reinette.chatre@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <a2f7013646a8a1e314744568b9baa439682cbf8a.1715017765.git.reinette.chatre@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFBnNVFBcHhOT1FoSWdZdUNDOXFpR0o2VDltcEwrRms5MUJqMjJ0ZzRFTU1p?=
 =?utf-8?B?WDd6aytIMlNwU0Z1cGxWcE5RaytCM1dhU09aWStqN3pQTEtGZ0ZiejVoT2I2?=
 =?utf-8?B?VlNYbDdPRVNvdUlJNFYzN1A4Tm43T1RVTWtWd1Z5bHZveUxvd01lOHJvQmxY?=
 =?utf-8?B?OXpzL3ZodStoNi84bEJ5djZKSExwSFRBei9OZmsxY3ZndHl6UjVVd3BqcDJs?=
 =?utf-8?B?U3haUXBsMnFBTE84ak95MXNrRkZkWXhMZmRGR1YwTEp1dlB4QTJ3TmQ4cUZT?=
 =?utf-8?B?L3JDUFdzb3l2OHJTaVpCRGJvRlhOQmhFanlNSzZQQSs3d0N2ZGlEZUFpUFVE?=
 =?utf-8?B?TWY5eVdOaWZUbnREaXVpb2JUVlNiWERieFRZUG1KRVc2bXpzZUdLOWhRaWQw?=
 =?utf-8?B?L1NVdkJzVVFUVTkydGN1YTVYWXR0Ymh6cnRhdmIwSFIydDU4cVZEbTEyNlZI?=
 =?utf-8?B?MFEwbG9BNzlHTGVjaE8wMC9JL2RTTjRKS3F4U1NnbnJrMXdqWFdvVm45SzNu?=
 =?utf-8?B?VmtsZ0dzaFVOcGN3RkEwUlorWUtWVGFKQmpYUHg2a1FjOXQxdlYxQnV0Q2xv?=
 =?utf-8?B?eEw5bXNleUVpeEN4N3NmZGRZWGtaUWE0NnV6K0dkQVp3VmNrbHNQeTUyZ2tC?=
 =?utf-8?B?QVIyM0V1QlcvWnp4K0tRb0VuTTJOVXhGZ3JJZ01jSGQ0eEllWkdRbXY1N2lt?=
 =?utf-8?B?Z1duMVE2bmJHUy9DeUExQmRsTDV0OWUycmdFcDE3U0hOUTRnajFaWStSUzBh?=
 =?utf-8?B?bW54QkRGM1pTYWY3QnFIVXM4eEtqKzVscGNJK3ZScVh4dWJOWStCT2loSU9D?=
 =?utf-8?B?THhxTkNxd3NWODErZFhFVW1RSVF5S295QUNHVFdtZG10ZGZ4bkU1SUdITGxt?=
 =?utf-8?B?MzVLemRnVUxUd09PQVJWNHBERXZBc0Y3NWlHaDBMc3dYbDAvcWlnVVBrd0RQ?=
 =?utf-8?B?TVp5aWMrRTg3Y3BGaGRSdEREV2dlZTJ4eXBOd1ZRbVhLZjBCeTJiMUwvOGV0?=
 =?utf-8?B?dGZiajlTQmdWdDRyTmYreUR1RUNsUXZ4ZUYxUS92a3M5Y29sai96NFZ2OHlW?=
 =?utf-8?B?U1dCeEJRbEh2dUVlODE4T1V2bEZNZStIUVZGTmMxaVF2QUpiK0JvWThjdkhI?=
 =?utf-8?B?dHBIeUNyYXU0R3AzVTBVVnQyQS9veEUzZ2ovQ2x1MTdPUEVFVCtMVWlOMjZa?=
 =?utf-8?B?VW5OZ2xNZkZ0Y2NsWW1ZcHNzQ1JVMjNlazgvZFl0Tmw1VjJzR3h5Yk56TlBs?=
 =?utf-8?B?bkpGL3BhVTloNnZtRjFodGlkSGE5ZnpTMEJLNDB3dUw3YjBFYlpyNllaS2FO?=
 =?utf-8?B?TVJ4dFI5eVhzWWRaT0FObEpwcEFGSVN3bU44Q08xdUd4RnNQUkxkWHI3MzI0?=
 =?utf-8?B?Zk5XQzNCU1hQSXIrWFhpNEhkU3l2YnhTM2Q1WDZxcCtSUnhUMzg3eFFuNXhM?=
 =?utf-8?B?Y0tpaTlNSUhOMmJ6UHdmeEJYUWRmeUE3Ym1XZVBQYVJJc2VEU2FVdFN4OG1j?=
 =?utf-8?B?RFdHNDRwdHhabjQ1Y1JWOUZLaWRQNEMvdFMvZ2x6RHdSaFBHcCt1UEJRZ2N5?=
 =?utf-8?B?QVhueU5FbVBhMEx6cGI1SXFTYTcxR1RaVlAxTWhTQkZaNnJHcy81UFpFSmkv?=
 =?utf-8?B?Y2lSTzVBVTFtRlgzS0x4Z3Z0WUY5MSs1UmF0Y3doZ2QzQ0pqTnUwaDRHRlRD?=
 =?utf-8?B?N3cwV1V5ZFViZTdLSElXc1A0ZGVTcTdBcVFXVXlPS3c2Uk9KaDhiOGlwZmQx?=
 =?utf-8?B?NGdqb3gvQlRlZVhlL2RoSjRIUDJDM2E4eTlOTG9GcjJuVEpZV0ZQNTlHdGtT?=
 =?utf-8?B?YkgwYjdTa2hoK1NORjhVODFHWFdMOTg3WDNEODZvMVQrRFdCYVdMMFE1Q1ZS?=
 =?utf-8?B?RmxVRDdydVB2eDhxd01LSy8ydVdPTmVyVHN2OTlvOVhTY3hpc0hSMFovK0ti?=
 =?utf-8?B?aC90blNiS1JHQUMvZUdvd1ZmSG8wTHR0amVhQkVJSUVxTmgxcWdTY0NQbGk2?=
 =?utf-8?B?bVZJUy8rWnk3ZGEyS2ZocnYxd21GZHZaQVpyeGV6bEx1dUw1QnduZ1pZQ1JV?=
 =?utf-8?B?RXhkRGRDMGJnRExxUnNxY1BUNnQ3cVFoVTdUUk14VFIrVDViRlBtZGU2Y3Rr?=
 =?utf-8?B?TDVFRXM5VGl4MVczVlN1eVJSZFV6V3dFdDhISTlFajZWT2s2YkhHQ2MwVWRT?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 147d5b48-ec7e-409f-b0fc-08dc78e42943
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 15:47:32.1195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WEpzxbjeMO8O2rRiRZCkFIXA6I+2dqNJCZ6TDsaq/xOEQ03AA20Ry6Z+dShtgp4s9oEIiRYg2gh8BBeeWuSkBFAL0isC/ddqCF/ezFk42+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7655
X-OriginatorOrg: intel.com


On 5/6/2024 11:35 AM, Reinette Chatre wrote:

..

> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
> new file mode 100644
> index 000000000000..56eb686144c6
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
> @@ -0,0 +1,166 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Test configure of APIC bus frequency.
> + *
> + * Copyright (c) 2024 Intel Corporation
> + *
> + * To verify if the APIC bus frequency can be configured this, test starts
> + * by setting the TSC frequency in KVM, and then:
> + * For every APIC timer frequency supported:
> + * * In the guest:
> + * * * Start the APIC timer by programming the APIC TMICT (initial count
> + *       register) to the largest value possible to guarantee that it will
> + *       not expire during the test,
> + * * * Wait for a known duration based on previously set TSC frequency,
> + * * * Stop the timer and read the APIC TMCCT (current count) register to
> + *       determine the count at that time (TMCCT is loaded from TMICT when
> + *       TMICT is programmed and then starts counting down).
> + * * In the host:
> + * * * Determine if the APIC counts close to configured APIC bus frequency
> + *     while taking into account how the APIC timer frequency was modified
> + *     using the APIC TDCR (divide configuration register).
> + */
> +#define _GNU_SOURCE /* for program_invocation_short_name */

As reported in [1] this #define is no longer needed after commit 730cfa45b5f4
("KVM: selftests: Define _GNU_SOURCE for all selftests code"). This will be
fixed in next version of this series.

Reinette

[1] https://lore.kernel.org/oe-kbuild/202405181535.WFKy4EwQ-lkp@intel.com/