Received-SPF: pass (google.com: domain of linux-kernel+bounces-183945-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 20 May 2024 11:59:16 -0400
From: Frank Li <Frank.li@nxp.com>
To: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, devicetree@vger.kernel.org,
	Jason Liu <jason.hui.liu@nxp.com>
Subject: Re: [PATCH v4 00/12] PCI: imx6: Fix\rename\clean up and add lut
 information for imx95
Message-ID: <ZktzVPsLexhMVY1Q@lizhi-Precision-Tower-5810>
References: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TnVaSk9QRXpvNzJmS3pYMjNKc2c0T2dRMHNENGMzWnBsK3VmQkt4aE0xVDcw?=
 =?utf-8?B?dm9DY2ZhR3F6WFg4aVpaRWNsQ2NVOEZxbSt4UE83cmRGN3NtOW9sellpazJS?=
 =?utf-8?B?SU9uRGxuWGJqS2FzQXFRa3JzazJpMndnemd6ZHNIWWltcU9pYmY3YlpQWDQv?=
 =?utf-8?B?NTlJNVEyaGkzZGp5eXdLMElSeUxpUnh6N0hYR0I0VUZiTkRHUFZuSDlrRXpV?=
 =?utf-8?B?NGpKV05EOFMzZ25aV0FPSE12a2srMzRlVDROOWFxdktvSGlLUXp6VWpQNHVH?=
 =?utf-8?B?bWZBdWlYRC9kcVQwY3dydzgweXV5TDJjTi84cXB0SkN0NUh3ZDZTWTNjU0cy?=
 =?utf-8?B?YlBoaHZyMStzQjVSNjJIOWg3RjltbHQ0UGxSZ1N6Mm52KzljNzBTRGFKdUds?=
 =?utf-8?B?TnZhTDJ6WGRmYlBpdmJ6eTBNcE5pRkVObHJ4Vm44d1RTS0dhY1dob2ZvdDBw?=
 =?utf-8?B?eTRlQ3hzbUhORUZMczltQy9lM2FiTWlHQm1aZkxzZDFGSVJKb3FNOUJHNk9O?=
 =?utf-8?B?UXNTd3ZTWTh4L05TeE8ySlJTUkI4RS9PU3ZlRSswQUxZcGZuN2UyNStzb2I1?=
 =?utf-8?B?WG01aEs4MUh1SDVvKzdGZHZ3SmtYZHBLZzJBckszcGE1ckZiTlJiOHdWQVda?=
 =?utf-8?B?MmJBYW1HaDBjSnlaV1NucmxiaktMclB4M3RJUlhiZm9VbllqcUhmYUlYQXRp?=
 =?utf-8?B?OEZ0d1hxM1N5Z013WWREcUVGNy94am5jRzdzRzRRMTF6UHE5cm9SaS9JSWNB?=
 =?utf-8?B?M1Y3TnVCVEVwYTdXV0FPaHVicmxCN3lGdklzTmIyWXVELy8yVEk4Um5KU25H?=
 =?utf-8?B?ZERsOWozS3ArOHhONEd5aU9IM2w4VFMyU2FWa2xwanNsSzU5b2szMXBYYllR?=
 =?utf-8?B?WHFIZ3phbzlRaUdoK3MyeGZjZ0lLYXdoYThHZkhiQWpMQ0lHdHJzMVI2Z0tX?=
 =?utf-8?B?S0w1UWVkVmhqWEdEcDNZRk50T3lud0NncVpXcHUyRGVzbG9wUHpiY2ZzU1Bj?=
 =?utf-8?B?UFJCQURkZGE4V0VtSFQxSDRXcTI0WHFTR1ZxWWhZYm5KcU9DNFVPMnJObWNp?=
 =?utf-8?B?dnNiUEtSck5hNktRcWxTbUpsa1hRT1B3MDJGalRySzdlSnZka2tYaDB2aXZJ?=
 =?utf-8?B?UXBjWFUzSklzdXNGVTJEZHQ4R3VoKzdLM0JKRGlmUml5cU9QQ0VVTmRKam9D?=
 =?utf-8?B?alI1amp1SnB0MUlSdVZXenRVc2NWTzViZkxZRFN3Q21aZGZ5RmN1SzhTM2Z0?=
 =?utf-8?B?UlNGdUxPVncyMjJ0MXFtK3hOaEt2Sm5CeklhYThtWFlMcmMwMkNDc2pwK2ZR?=
 =?utf-8?B?UGw3RnVXZXUvSFdtazBtd3Fnb1JzQ3ZQYnJmU3d6K3RSL2Y2NE5TR2RVbm41?=
 =?utf-8?B?NEhoSjBxMm1zRW1hRDFyUlZXNll6MTRhbTJHZEdnWmYxamdVbXVQY01LMGtI?=
 =?utf-8?B?Q2FOblBLTUl4MWFyeGlSMUNXcXVsY0Qzc3pqVEhMYmtIUWJ1MXpVVUtUM1o4?=
 =?utf-8?B?L2RMeFhKTU1HUTRsMUo4dGtWc20zTmhub1JLVENTYlZZZXZ1K1VQaDY5NUZk?=
 =?utf-8?B?d2ZZKzUxZzlldzFmcE91a3g4OHd5emw1TkpzL0FtcjdoajhTR1VybjFTQmFx?=
 =?utf-8?B?ZXphQ2R2WDNBUDBDN3MwMlVsU1R5Tkg3ZlhKallTci83VEVBdXc1N1JEcUxn?=
 =?utf-8?B?bXJ6UGZuNXJYeHEwRndSbFlPa3Z2UTVlQmVxZTJDOUs4blRRR2xhOUZrMWJr?=
 =?utf-8?B?M01WWTkrdTQwUVhoUG9scVh0MWtGajJWaFpBaEk3ek5ZbExKNWlEWG0zaHEw?=
 =?utf-8?B?bEdRM2ZTVzZIeFpEWk5CUEpzeDZTQ0pKTkxyNVB6N1BKbnZQdXR0NlBWemo1?=
 =?utf-8?B?dy92eTd6TnNHQWZwN2JoOXpjcWZzUUZQdUp3Ym5NTHFWenAyMWFSVWN4SEN2?=
 =?utf-8?B?endrRG0rODhGK1JSSUNkWW5kbGpUdWFnNHV2ZXlaeVB1QVJjaktITGVxN1dj?=
 =?utf-8?B?SlRUU0J6SFJjSDAwNzFvWGdydmhDSDFlbXpmN3AyUFZORXgxUnNCZjZTQnU2?=
 =?utf-8?B?MlR1YlBTZ1NDSyt6Sm9KV2ZKS1ZDbnpIdjR1ektnbUF3aEpDUkNwNmwxVkls?=
 =?utf-8?Q?PCLMf3n+/fTrglfXD4plujt7x?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b790a0c-b1ad-4dfb-4098-08dc78e5d30a
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 15:59:26.4147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VJPIiCouuw4ojj35JFKy/iae5kRd5uaWC1NlBapBxGIN15KOpUF5cNqYfNI/KTrrsazV06oqYU0/s8J2UFv3Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10368

On Tue, May 07, 2024 at 02:45:38PM -0400, Frank Li wrote:
> Fixed 8mp EP mode problem.
> 
> imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid     
> confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to        
> pci-imx.c to avoid confuse.                                                
> 
> Using callback to reduce switch case for core reset and refclk.            
> 
> Add imx95 iommux and its stream id information.                            
> 

Mani:
	Do you have chance to check these again? I fixed what your said
at v3.

Frank Li

> Base on linux-pci/controller/imx
> 
> To: Richard Zhu <hongxing.zhu@nxp.com>
> To: Lucas Stach <l.stach@pengutronix.de>
> To: Lorenzo Pieralisi <lpieralisi@kernel.org>
> To: Krzysztof Wilczyński <kw@linux.com>
> To: Rob Herring <robh@kernel.org>
> To: Bjorn Helgaas <bhelgaas@google.com>
> To: Shawn Guo <shawnguo@kernel.org>
> To: Sascha Hauer <s.hauer@pengutronix.de>
> To: Pengutronix Kernel Team <kernel@pengutronix.de>
> To: Fabio Estevam <festevam@gmail.com>
> To: NXP Linux Team <linux-imx@nxp.com>
> To: Philipp Zabel <p.zabel@pengutronix.de>
> To: Liam Girdwood <lgirdwood@gmail.com>
> To: Mark Brown <broonie@kernel.org>
> To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-pci@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: bpf@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Changes in v4:                                                             
> - Improve comment message for patch 1 and 2.
> - Rework commit message for patch 3 and add mani's review tag
> - Remove file rename patch and update maintainer patch
> - [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback
> 	remove extra space.
> 	keep original comments format (wrap at 80 column width)
> 	update error message "'Failed to enable PCIe REFCLK'"
> - PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback
> 	keep exact the logic as original code
> - Add patch to update comment about workaround ERR010728
> - Add patch about help function imx_pcie_match_device()
> - Using bus device notify to update LUT information for imx95 to avoid
> parse iommu-map and msi-map in driver code.  Bus notify will better and
> only update lut when device added.
> - split patch call PHY interface function.
> - Improve commit message for imx8q. remove local-address dts proptery. and
> use standard "range" to convert cpu address to bus address.             
> - Check entry in cpu_fix function is too late. Check it at probe
> - Link to v3: https://lore.kernel.org/r/20240402-pci2_upstream-v3-0-803414bdb430@nxp.com
> 
> Changes in v3:
> - Add an EP fixed patch
>   PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode
>   PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
> - Add 8qxp rc support
> dt-bing yaml pass binding check
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml
>   LINT    Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb
> 
> - Link to v2: https://lore.kernel.org/r/20240304-pci2_upstream-v2-0-ad07c5eb6d67@nxp.com
> 
> Changes in v2:
> - remove file to 'pcie-imx.c'
> - keep CONFIG unchange.
> - Link to v1: https://lore.kernel.org/r/20240227-pci2_upstream-v1-0-b952f8333606@nxp.com
> 
> ---
> Frank Li (8):
>       PCI: imx6: Rename imx6_* with imx_*
>       PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
>       PCI: imx6: Simplify switch-case logic by involve core_reset callback
>       PCI: imx6: Improve comment for workaround ERR010728
>       PCI: imx6: Add help function imx_pcie_match_device()
>       PCI: imx6: Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95
>       PCI: imx6: Consolidate redundant if-checks
>       PCI: imx6: Call: Common PHY API to set mode, speed, and submode
> 
> Richard Zhu (4):
>       PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
>       PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
>       dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string
>       PCI: imx6: Add i.MX8Q PCIe root complex (RC) support
> 
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |   16 +
>  drivers/pci/controller/dwc/pci-imx6.c              | 1193 ++++++++++++--------
>  2 files changed, 736 insertions(+), 473 deletions(-)
> ---
> base-commit: 9d8b196fd12e52820a40c21297a97ea6186aa87e
> change-id: 20240227-pci2_upstream-0cdd19a15163
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
>