Received-SPF: pass (google.com: domain of linux-kernel+bounces-183978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d0744767-e393-44cc-8786-5419afeaf2b5@intel.com>
Date: Mon, 20 May 2024 09:52:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V6 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency
To: Sean Christopherson <seanjc@google.com>
CC: <isaku.yamahata@intel.com>, <pbonzini@redhat.com>,
	<erdemaktas@google.com>, <vkuznets@redhat.com>, <vannapurve@google.com>,
	<jmattson@google.com>, <mlevitsk@redhat.com>, <xiaoyao.li@intel.com>,
	<chao.gao@intel.com>, <rick.p.edgecombe@intel.com>, <yuan.yao@intel.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <cover.1715017765.git.reinette.chatre@intel.com>
 <a2f7013646a8a1e314744568b9baa439682cbf8a.1715017765.git.reinette.chatre@intel.com>
 <c2baeb4b-5cad-4cb9-a48e-0540f448cb15@intel.com>
 <Zkt2gNFxC0MHyIRb@google.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Zkt2gNFxC0MHyIRb@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TklDUjJmMVRrSFEveFU5SVJlU2FWK0NpNEdkYlFHT2hKNGtueDNZeTc0OW1i?=
 =?utf-8?B?Zmt0SGdxeXJJYjdvN2Nsbml0QVVNbWFnckR2RW1pQUV4cGxmU2wrZXM3emIz?=
 =?utf-8?B?aURIR01ISTR1bUs2VjFDSlBQMjlZS1VZcnUxZC9Yanpma2ZsbG9EbktmQ1B2?=
 =?utf-8?B?S3NLME9JbnEvVEZXM2lYMGk5czBKQ3dqOCt0VkxsMGpEL3hqUk1KU0dra0dE?=
 =?utf-8?B?R2F4MUtabWx6Uk0xMmRvYmxYYnFsZFM4MXUwTVl6VWxHLzNwOUZTWjRhbGFP?=
 =?utf-8?B?TmFrWXBmTEF0MVRmUjQ5OGRHN0tDUU5LV3AyVXc0anFwTHk4aURoakIrbE1S?=
 =?utf-8?B?SlF0MVBTTmJOS3pOM21JQ25EcXVhT3hIYng0RWE1dktzZDYwU244SUl6TGVm?=
 =?utf-8?B?bmpDTmNqckF4WkxOaXpOUGVXZ3V0WFJLbWpTeFRHalJaUjNsbm1va0RuUDlS?=
 =?utf-8?B?b0NtT3hDakIvSFpVUDE0Mmh0Zkc2cDZQdDNWQkVHK3pvTlArdTh0VzEvSm9y?=
 =?utf-8?B?ZWxCL0xhcjhTb1hFeEozbTdjRlpZRnN5WWh0ZklyRU9TRUxyeHFlaDFiZXUz?=
 =?utf-8?B?Smc1dVlkcmFRVDFwbnJ0S1BtVUlyc3I3dDc3TUEwemRleHFOemwwMnZBaWlx?=
 =?utf-8?B?dVJTTTBWUVZTcFNHd2lUMEczMElsUjY4d2NZekFaTU1FY29UV1lxTEJtNEhK?=
 =?utf-8?B?TVVyOFVoV2xaTTk4SUREV2JnaUVKRTlKOUpJNDlTNjE0RzRiMlI4K2I3Ukgr?=
 =?utf-8?B?a3Q5bzhGREtlMlJoTVZ5K3pnblpZMjVCUDlRUENXWFhETGNsL2dTVVFJYWVT?=
 =?utf-8?B?Z3B1LzFnLyt2b1JNRCtEaWhrN3RIOU9BSDFtS0J3Y2xiblZsbitLbjNHQlhy?=
 =?utf-8?B?anJIRmw3aTEvYk9FR1h6dW9tcmp4UnZnR2l1NEU0VzdTY1dnL09lVFo5WExX?=
 =?utf-8?B?QXQ4R2dZTW80TDlZaW5Hc0lzc3F4am40Y0pIcmNWaXlpVmwwVGsyRVQvei9L?=
 =?utf-8?B?VzNJQzJXS1BMblM4UDQvRVU3YXVVWGwyZ3FET3VKQzZJMzMrTWw4c1c5ZjlM?=
 =?utf-8?B?ZGp3WUJzTFlVSWs2SVU0TFpqS0tlUnc5STJ5RWdWOVhsdCtKRlRDZDU2SU0v?=
 =?utf-8?B?VjVnTmxpanlyS1JVWWlZRkVVdmlPUUMwT0RsWDBaOE1KOUlyY1pUWFVaczlt?=
 =?utf-8?B?dnNtdisrSWd4N3Z5M01rYjh1Yk9nU0M3R0MwTmdxclNvZmR5OEZ5M2Fhb3N2?=
 =?utf-8?B?WUNGMFphM1dZT0hjMWs3dW1XTm85SzEyWFA2SlI1dUltRTVTTnlPa2Z4dW5W?=
 =?utf-8?B?Vy9YV0g2eXUxWFFQdlVaTlpvZ2ZKQXNtdnIwc1ExRGFLYUhxYUNCeHFFOE9k?=
 =?utf-8?B?cnZQV1hrei9lM05ONGZ0aWRsRGs4K3hkM2R2U3FxWTJscjE2L1FLQ3poVGVJ?=
 =?utf-8?B?Z1BFT1lrb0JwV0ZvYmdmcG5wbmVGeVNjVnAzeVE3RkxNRnVOMzhqM2kydDNr?=
 =?utf-8?B?NUp4Q3dFMFZNZy8xNTFwaHRraTZHU1dCMVZvT3daSmRFTWZGVVJ1NVdwK2dY?=
 =?utf-8?B?dkRUSlp4T1FGZmFTVHFuRjZMdGlFNHd2eEg2RWNQdW5BcVc2Qyt6TG9pUFhH?=
 =?utf-8?B?dUlDTEJuUjVXYndDZHdMNmJQV3piYVMyMmp2eit5VzF2eGVZR0NxNkJnRE9J?=
 =?utf-8?B?ZzgvVFJkUEcyVjJqN0IwQ1JTdFhqMWkwY1BEMEtIQk9LNSsyaFRSOEM3d3Fw?=
 =?utf-8?B?cHJFUVpWS2lqWWRQWUJZNGJMMXZCUmZ4eW1nR3U2alRndGVvR3lRNi9KWlow?=
 =?utf-8?B?VUNsZGUwN0NHTjFXeEZrWVgwK29iaTJUbDNGUXlwT3cwYU42R3R0QkJmeWJV?=
 =?utf-8?B?WWNuVzBmYldKeTE3QzdqcTg0U3RTYVFTUEhMQnJiM3RIcjhqNzcvbVUwaGhE?=
 =?utf-8?B?ZW1xMnVnUzBFdDAvYlY1bml6S2JOTlJFaVBNblpXK1d0RFU0L3VTWVhHTlR0?=
 =?utf-8?B?V3J4OFR0Rk5uTERXSmpiUXQ3aWk3cmFZTllyL1M2eTVKdFVQS1dKa3FIVXJv?=
 =?utf-8?B?U0JiKzlPVUxMdWFOaEtubi9FY2RDb0tPaURtNW5lK0xVN3JXWDB1N3JSbURk?=
 =?utf-8?B?L0Y0dnlXQXpkNnYrTUxUT3N6Q2VxTDd3MlJmUWZ2SHlCNyticmFNMWRYejdn?=
 =?utf-8?B?Ymc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 41386f54-8962-4a91-fe5f-08dc78ed4aa1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 16:52:53.6510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B64xD2jnH4pk+hyF9VvV/yg+ozHIdurZmW1kNSdronGYydvy5yDvaC+aH7n91261iCbHLJJk1zOWHjgegv8K9foYxpOy7qs2fdQQSD3Sk6E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8319
X-OriginatorOrg: intel.com

Hi Sean,

On 5/20/2024 9:12 AM, Sean Christopherson wrote:
> On Mon, May 20, 2024, Reinette Chatre wrote:
>> On 5/6/2024 11:35 AM, Reinette Chatre wrote:
>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> new file mode 100644
>>> index 000000000000..56eb686144c6
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>> @@ -0,0 +1,166 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Test configure of APIC bus frequency.
>>> + *
>>> + * Copyright (c) 2024 Intel Corporation
>>> + *
>>> + * To verify if the APIC bus frequency can be configured this, test starts
>>> + * by setting the TSC frequency in KVM, and then:
>>> + * For every APIC timer frequency supported:
>>> + * * In the guest:
>>> + * * * Start the APIC timer by programming the APIC TMICT (initial count
>>> + *       register) to the largest value possible to guarantee that it will
>>> + *       not expire during the test,
>>> + * * * Wait for a known duration based on previously set TSC frequency,
>>> + * * * Stop the timer and read the APIC TMCCT (current count) register to
>>> + *       determine the count at that time (TMCCT is loaded from TMICT when
>>> + *       TMICT is programmed and then starts counting down).
>>> + * * In the host:
>>> + * * * Determine if the APIC counts close to configured APIC bus frequency
>>> + *     while taking into account how the APIC timer frequency was modified
>>> + *     using the APIC TDCR (divide configuration register).
>>> + */
>>> +#define _GNU_SOURCE /* for program_invocation_short_name */
>>
>> As reported in [1] this #define is no longer needed after commit 730cfa45b5f4
>> ("KVM: selftests: Define _GNU_SOURCE for all selftests code"). This will be
>> fixed in next version of this series.
> 
> Don't worry about sending another version just for this, I can clean this up when
> applying.

Thank you very much. At this time this is the only change planned for this series.
I do not know the status of all completed and planned merges during the merge
window, but I did a quick check and this series applies cleanly on top of today's tip
of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. The kernel parts
passed a bisect test cleanly, while the selftest encountered just the warning related
to _GNU_SOURCE.

Reinette