Received-SPF: pass (google.com: domain of linux-kernel+bounces-183982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Yang Shi <yang@os.amperecomputing.com>
To: catalin.marinas@arm.com,
	will@kernel.org,
	anshuman.khandual@arm.com,
	scott@os.amperecomputing.com,
	cl@gentwo.org
Cc: yang@os.amperecomputing.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [v2 PATCH] arm64: mm: force write fault for atomic RMW instructions
Date: Mon, 20 May 2024 09:56:36 -0700
Message-ID: <20240520165636.802268-1-yang@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oJw3SgbBZGiGSw4aj2kbo8zKjCRY5wbDqQrHPS1gZjKefS0nmc5njppz7mn8?=
 =?us-ascii?Q?RhxrK2A1FdgE0Wx6mvn6CziqEW4LFujR9Ccr32BA2oQP2ARMRHj5u3/FUu5+?=
 =?us-ascii?Q?/MxInA48BuL7NwG0WQ0GeM9qERU96ACI/6rHrHE9WG4MoQWbNM8fWJ6aahfl?=
 =?us-ascii?Q?R2ybMdRKLI2AvCAVIAGgRJx6RWehk7GFOZ4i8eQNQi95fJ9nlr9hlQqqL4cl?=
 =?us-ascii?Q?3cRym0HlLD9FycXAredQ19Wy5rIZ1KQrYWfNHpHgjDbKZIAtwvweTtr3Gsti?=
 =?us-ascii?Q?R81uX9tTMgY0sx8X2JPQLzy4DXTuuqybrtO5UeX5d4KtxfRXs6CC+rhMVkZf?=
 =?us-ascii?Q?xg/rLz3de9BSHHQN9qwxpp/7ZhBkq0ozGa0JneRqCYMrEWGg6KWaViJUBs0c?=
 =?us-ascii?Q?0BtsSJbNEOIZfCYk54hc8d8KzpcMZB4EPbMO9CXrCpFHgoRB0IO5i+0UQX6F?=
 =?us-ascii?Q?3alAFSKggMOofubh6a49gr5Tcy1wZmUSHGZdQk+RRTNV6toqz27gCzC4uO+r?=
 =?us-ascii?Q?oc70Gmj1A/Ztsm0LXusHkgtA1mA4RZSw4jnnbGjm/SzCwXdl2j5/YsJN4IW/?=
 =?us-ascii?Q?c9cEEnTALyy0iWVI3H9tZ8yJrFmT59t6BgNq/HS1KTncq6UCxFbfw+/iAG9i?=
 =?us-ascii?Q?xyHeV1Jopb2edwuLIVBY5AiCxn/lRa1h8o0bfCcNH8m9R3q/7VnO+kThzgLM?=
 =?us-ascii?Q?rZ3wJ8KReEoQRUWZNeFPVmncVcl/ilOta2s/yRCcga2Xvb8ZZ/P4YCI0R2QM?=
 =?us-ascii?Q?n+gDnsGmk5PZV477Qnb3rg5IMoQzXBddmLZfBE2XuC4iQLKPHdYDBxJHtTRk?=
 =?us-ascii?Q?krRK6Mm/e8s7ltsgK/YUA5N12jOiuy0oKuoVumfd56Qyv/Qr5jfStri6FLc8?=
 =?us-ascii?Q?g2NGAZWpsCh5NNjigbP0dol/Ow8C906ZiBv5GuGlP/jCTavqDzzXorl8txIp?=
 =?us-ascii?Q?yvnFMwyIZIuey+aZdxy5XB+uM7OOvnqlTRtL4BPUWWxkkm+haWQwhIH8NsVm?=
 =?us-ascii?Q?In2QOSvPv/bPn2E3IwaXRcAjCJ8TcD9GGSwuHHemQssJOZbjeqshPI1o3PxD?=
 =?us-ascii?Q?6cbweg8VLvdL8HUmVPD3ygTK7v9lCogXPzZBxqVBHvXWQOMCsLgcwBivX/XT?=
 =?us-ascii?Q?hyOhPy8pFJE60iuBs0f/e26j1Gd5wz15IGb5MeXHSIYtfMSp6Yebq+HIjVQP?=
 =?us-ascii?Q?aHJhad08ykUGKlk1v86U7Z2Kcx6cTCAwPypxj+6sm684lGRytEaM/z3lXP23?=
 =?us-ascii?Q?ZHqw8mEF+Yr6gkcmjP9c1ohiTj5F/HyLVJAQRwvgO3HvNc8Wvw1pNhJek5XB?=
 =?us-ascii?Q?HfkyVWscGuKywHKUrHfxYhSJufGx2pIrIkgJrfvBeQxXGqEpb5Ri7c21b0dn?=
 =?us-ascii?Q?g5NdchRh6tSuH+IMUrUd8MA0cVCgNXusS3YcpncTXfqZk9LpjyJhT3mgwPSO?=
 =?us-ascii?Q?qhcKyIZo4l18ZrX3aNrIntBy88koDMwhJF4am7DEHmQG0bpXpCLWnAEdBdDl?=
 =?us-ascii?Q?iX5SIqYEgjJaYCg02Q2P9efKGTvI83gkrgojXnOu8CiT1XGZYa45ZniNAZqN?=
 =?us-ascii?Q?Q6JHLEQJfr8KrXljJkOckoDpzvxXU5ufQooxF2iorjt0rbONHIulDf/OL423?=
 =?us-ascii?Q?0yymO7I3I4sLkaWkIxnuZPU=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 525e9039-e274-45b2-eec5-08dc78edda0b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR01MB5463.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 16:56:54.2659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eo0ub764BuEpAYw9+cZUuFlZ+dZl2WSlammiTuyejCpPQ8fYUV1WwpMLCBMrvZ6RkBsJr85b6skfVZZTK6igiPqSUzg+MIqVS/VUzZTVOGs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR01MB8008

The atomic RMW instructions, for example, ldadd, actually does load +
add + store in one instruction, it will trigger two page faults per the
ARM64 architecture spec, the first fault is a read fault, the second
fault is a write fault.

Some applications use atomic RMW instructions to populate memory, for
example, openjdk uses atomic-add-0 to do pretouch (populate heap memory
at launch time) between v18 and v22 in order to permit use of memory
concurrently with pretouch.

But the double page fault has some problems:

1. Noticeable TLB overhead.  The kernel actually installs zero page with
   readonly PTE for the read fault.  The write fault will trigger a
   write-protection fault (CoW).  The CoW will allocate a new page and
   make the PTE point to the new page, this needs TLB invalidations.  The
   tlb invalidation and the mandatory memory barriers may incur
   significant overhead, particularly on the machines with many cores.

2. Break up huge pages.  If THP is on the read fault will install huge
   zero pages.  The later CoW will break up the huge page and allocate
   base pages instead of huge page.  The applications have to rely on
   khugepaged (kernel thread) to collapse huge pages asynchronously.
   This also incurs noticeable performance penalty.

3. 512x page faults with huge page.  Due to #2, the applications have to
   have page faults for every 4K area for the write, this makes the speed
   up by using huge page actually gone.

So it sounds pointless to have two page faults since we know the memory
will be definitely written very soon.  Forcing write fault for atomic RMW
instruction makes some sense and it can solve the aforementioned problems:

Firstly, it just allocates zero'ed page, no tlb invalidation and memory
barriers anymore.
Secondly, it can populate writable huge pages in the first place and
don't break them up.  Just one page fault is needed for 2M area instrad
of 512 faults and also save cpu time by not using khugepaged.

A simple micro benchmark which populates 1G memory shows the number of
page faults is reduced by half and the time spent by system is reduced
by 60% on a VM running on Ampere Altra platform.

And the benchmark for anonymous read fault on 1G memory, file read fault
on 1G file (cold page cache and warm page cache) don't show noticeable
regression.

Some other architectures also have code inspection in page fault path,
for example, SPARC and x86.

Signed-off-by: Yang Shi <yang@os.amperecomputing.com>
---
 arch/arm64/include/asm/insn.h |  8 ++++++++
 arch/arm64/mm/fault.c         | 38 +++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

v2: 1. Made commit log more precise per Anshuman and Catalin
    2. Made pagefault_disable/enable window narrower per Anshuman
    3. Covered CAS and CASP variants per Catalin
    4. Put instruction fetching and decoding into a helper function and
       take into account endianess per Catalin
    5. Don't fetch and decode insn for 32 bit mode (compat) per Catalin
    6. More performance tests and exec-only test per Anshuman and Catalin

diff --git a/arch/arm64/include/asm/insn.h b/arch/arm64/include/asm/insn.h
index db1aeacd4cd9..1cc73664fc55 100644
--- a/arch/arm64/include/asm/insn.h
+++ b/arch/arm64/include/asm/insn.h
@@ -319,6 +319,7 @@ static __always_inline u32 aarch64_insn_get_##abbr##_value(void)	\
  * "-" means "don't care"
  */
 __AARCH64_INSN_FUNCS(class_branch_sys,	0x1c000000, 0x14000000)
+__AARCH64_INSN_FUNCS(class_atomic,	0x3b200c00, 0x38200000)
 
 __AARCH64_INSN_FUNCS(adr,	0x9F000000, 0x10000000)
 __AARCH64_INSN_FUNCS(adrp,	0x9F000000, 0x90000000)
@@ -339,6 +340,7 @@ __AARCH64_INSN_FUNCS(ldeor,	0x3F20FC00, 0x38202000)
 __AARCH64_INSN_FUNCS(ldset,	0x3F20FC00, 0x38203000)
 __AARCH64_INSN_FUNCS(swp,	0x3F20FC00, 0x38208000)
 __AARCH64_INSN_FUNCS(cas,	0x3FA07C00, 0x08A07C00)
+__AARCH64_INSN_FUNCS(casp,	0xBFA07C00, 0x08207C00)
 __AARCH64_INSN_FUNCS(ldr_reg,	0x3FE0EC00, 0x38606800)
 __AARCH64_INSN_FUNCS(signed_ldr_reg, 0X3FE0FC00, 0x38A0E800)
 __AARCH64_INSN_FUNCS(ldr_imm,	0x3FC00000, 0x39400000)
@@ -543,6 +545,12 @@ static __always_inline bool aarch64_insn_uses_literal(u32 insn)
 	       aarch64_insn_is_prfm_lit(insn);
 }
 
+static __always_inline bool aarch64_insn_is_class_cas(u32 insn)
+{
+	return aarch64_insn_is_cas(insn) ||
+	       aarch64_insn_is_casp(insn);
+}
+
 enum aarch64_insn_encoding_class aarch64_get_insn_class(u32 insn);
 u64 aarch64_insn_decode_immediate(enum aarch64_insn_imm_type type, u32 insn);
 u32 aarch64_insn_encode_immediate(enum aarch64_insn_imm_type type,
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 8251e2fea9c7..73f954fcb8c7 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -519,6 +519,30 @@ static bool is_write_abort(unsigned long esr)
 	return (esr & ESR_ELx_WNR) && !(esr & ESR_ELx_CM);
 }
 
+static bool is_el0_atomic_instr(struct pt_regs *regs)
+{
+	u32 insn;
+	__le32 insn_le;
+	unsigned long pc = instruction_pointer(regs);
+
+	if (!user_mode(regs) || compat_user_mode(regs))
+		return false;
+
+	pagefault_disable();
+	if (get_user(insn_le, (__le32 __user *)pc)) {
+		pagefault_enable();
+		return false;
+	}
+	pagefault_enable();
+
+	insn = le32_to_cpu(insn_le);
+	if (aarch64_insn_is_class_atomic(insn) ||
+	    aarch64_insn_is_class_cas(insn))
+		return true;
+
+	return false;
+}
+
 static int __kprobes do_page_fault(unsigned long far, unsigned long esr,
 				   struct pt_regs *regs)
 {
@@ -529,6 +553,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr,
 	unsigned int mm_flags = FAULT_FLAG_DEFAULT;
 	unsigned long addr = untagged_addr(far);
 	struct vm_area_struct *vma;
+	bool force_write = false;
 
 	if (kprobe_page_fault(regs, esr))
 		return 0;
@@ -557,6 +582,11 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr,
 		/* It was write fault */
 		vm_flags = VM_WRITE;
 		mm_flags |= FAULT_FLAG_WRITE;
+	} else if (is_el0_atomic_instr(regs)) {
+		/* Force write fault */
+		vm_flags = VM_WRITE;
+		mm_flags |= FAULT_FLAG_WRITE;
+		force_write = true;
 	} else {
 		/* It was read fault */
 		vm_flags = VM_READ;
@@ -586,6 +616,14 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr,
 	if (!vma)
 		goto lock_mmap;
 
+	/* vma flags don't allow write, undo force write */
+	if (force_write && !(vma->vm_flags & VM_WRITE)) {
+		vm_flags |= VM_READ;
+		if (!alternative_has_cap_unlikely(ARM64_HAS_EPAN))
+			vm_flags |= VM_EXEC;
+		mm_flags &= ~FAULT_FLAG_WRITE;
+	}
+
 	if (!(vma->vm_flags & vm_flags)) {
 		vma_end_read(vma);
 		goto lock_mmap;
-- 
2.41.0