Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2614882lqo; Mon, 20 May 2024 10:49:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXs60wMTRod8wW7M7nYoeLh1RCsp8XRIGrVGTKIzeYIprPpMa7GQehQEySjrUbGTOlmnRFRtXO4VMb+UnZH1Eo18pQ2t81ONbDVDdENQw== X-Google-Smtp-Source: AGHT+IEVtQOSpQwvGVR+wNsNNHV+vQPbDj2m+YVGSvFnOqMeqFj8v2zXrREquQcbPS7jWiYhawsl X-Received: by 2002:a17:90b:3118:b0:2bd:8803:485b with SMTP id 98e67ed59e1d1-2bd88034b40mr2011350a91.6.1716227354962; Mon, 20 May 2024 10:49:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716227354; cv=pass; d=google.com; s=arc-20160816; b=gqq16K3qJUzPHYCzpDv4bWYlQE89LmoCYo5Afb/G2ikNCVaj231/ImWCkT59LQhPl1 Gj29GpKfAvryZV0ggWCj0TxbOTNTwm/Uo4W4XT55mcIePd0YPNdoLn7yNN+T+M3QupT7 bavdZD7yVkqx3XchQiq3a9SaAkh7iV1Vvzfhw+4pQB+FqEKZSniN8MFmQwWNvYu81xm/ ysLrqpwNYcGXBqQ34ab/DzOFrDu60++1Gx+d8G0lkcOi4K6gj48Cb9kXciUiKr3FK5uF 0Gm5pWMFTs8wmCVvw7JdaUSr+eHmp4V+Koh60PygNQmfN5Ht8kBdvH+UIXeU4dh9Phwh s0sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=XfldnoFCtlXjDUGIkjCxDruNAojvgZwZWzyNtsiBzQI=; fh=71Gx+lVLREOgNWiyEBz+I27yEp9f/8QCOzn378J9F7k=; b=FTaJ1FUtVXaBU41niDkwzyghRhRcL0HnRv/6aYO4V8dbeSzaysJ55vg8QiQv3iD0jq 88OMayjcNC/kXaOBj2z0H3dvj09Twa7+iAhPfvcMRhWxlq2QvAIVeQf5dgfoiXRwGBYV q2MJ+u216/uhQl7YJEf6VyNKnFPNYZjRGkzCi42TYvub5AwTpVIPatskYfmZLV9FHF/N m4u2x+prRFHS3HZgT3DBhJsnZYbI6rilCno17TNwtk9z3kEWvKG7QP8eVrqA3fLpYVDP YvTKNCTbPDSybqtm3vJzgrT1a0xVQzCC3Szsh8qh2dVoV8ADB9/jReczTvt9kbcG/mu2 lbeQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=HOEcB3m6; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-184023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184023-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bd70be8281si3444811a91.33.2024.05.20.10.49.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 10:49:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-184023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=HOEcB3m6; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-184023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184023-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 325D1B21C0E for ; Mon, 20 May 2024 17:49:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 021F9137C54; Mon, 20 May 2024 17:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HOEcB3m6" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F37DD53E; Mon, 20 May 2024 17:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716227340; cv=none; b=fmt/2V5/MdOwai5ulOCtIZAuxP8zCI3pCcbimnNp0DacUbZWaUJQd0kXM1ebnTSM9m0bIkkFg6YpBml2MwbWm0pE/cHCRabt4Atn5/ITWV9mPr03TpNERd7ib7coy/ZtaTjik8FQmjuUSMl3ayF8/QN+fIrjNP0+3LSjcidUzCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716227340; c=relaxed/simple; bh=Gj0UBJfjFW3PwUY9gUpaYI356SaQ6by9B7HTUA781h8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BGy3bOHaAoCQ0Aa23wWcBczY4n6vmK78qkd3cStCWmG6q1U9fJzUQtPEzzV7+4sR2n8048CrPLkfkq5nDbths5YUGNpQbmq2VT/DsNLa47BCsuIJPY15tLSpFK7qt0WOYGB0GKROkaAgTHaX+Ab20pGq8RfXDACYHPxlmiHZQns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=HOEcB3m6; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XfldnoFCtlXjDUGIkjCxDruNAojvgZwZWzyNtsiBzQI=; b=HOEcB3m6VMMOMDPp2cPBpKomlO FekL9B6kRdA3i7PGuGVL6jOAl8+l8w4sUza98ZBCYB/she/YBJ87BuBH/uYaxdE0EVgc3NuHmKYlW G1Ufav1ydalYq60mo06uVnnWf/kBK2CQ8r2vQNHzg4CLAw1v9RiQvAk9/zNTZjnT/kfcomuOfzkX6 5T7DUyMXFY3xpexzATBep97nyKXYp78EbdrCUPVIVzmv5gisGMe3TS8KECo+DwihcrSHB0zDyCcvH 4nTUFM0bejLOuEE2KQzySqDJv7nHOjAlIOYeDIK/HOKE000QjQLooBC1E7cXoNEvMFVCsonX1lTb3 +UnysHNg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52632) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s977m-0007BC-2Y; Mon, 20 May 2024 18:48:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s977k-0004Tz-AX; Mon, 20 May 2024 18:48:36 +0100 Date: Mon, 20 May 2024 18:48:36 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "dqfext@gmail.com" , Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "hkallweit1@gmail.com" , "daniel@makrotopia.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH net-next v2 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20240517102908.12079-1-SkyLake.Huang@mediatek.com> <20240517102908.12079-6-SkyLake.Huang@mediatek.com> <283c893aa17837e7189a852af4f88662cda5536f.camel@mediatek.com> <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch> Sender: Russell King (Oracle) On Mon, May 20, 2024 at 03:02:21PM +0200, Andrew Lunn wrote: > > Actually this phy is strictly binded to (XFI)MAC on this platform. > > So I directly disable HDX feature of PHY. > > Sorry, i don't follow your answer: > > Can the PHY do half duplex? > Can the MAC do half duplex? > > The part which cannot do half-duplex should be the part which disables > half-duplex. Note that if the PHY is doing rate adaption (preferably in a form that it can control the MAC transmission rate), then even if the MAC can't do half-duplex, the PHY can still do half-duplex. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!