Received-SPF: pass (google.com: domain of linux-kernel+bounces-184054-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <632479f9-1abd-4c92-86e4-92d08a9b5b2a@oracle.com>
Date: Mon, 20 May 2024 11:15:48 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/5] mm/memory-failure: move hwpoison_filter() higher
 up
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240510062602.901510-1-jane.chu@oracle.com>
 <20240510062602.901510-5-jane.chu@oracle.com>
 <329c33ce-3fb8-436c-2ceb-e6520f0a973a@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <329c33ce-3fb8-436c-2ceb-e6520f0a973a@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OEg2ZGwrckFaNmZLNFB1d0JFV0ZWb2pyYWNoZWRkWW45Sm9zOStkRjJWdksy?=
 =?utf-8?B?RDFHamxNV3lFSE1UVGIraWRvSHVGa0ZmNllJRjh6SlpURmxYZ3JJUDRkdk1l?=
 =?utf-8?B?MFNrYXhTcjhLNSs0VmdpU0o3RG84K00wNHZHVVdHNFpmQXJGd05tMTJ3Tmdo?=
 =?utf-8?B?L0RqWi9SR2I3R3A0K1hZenF3S1ovdTNRRDZTRFlVQWliRXdpaDdSOHl3bkFV?=
 =?utf-8?B?bzFnalkrMmFpVWo0SFlOQXQ2UkZMSzMrdVVtMFN0VWNFbXZXNjZ1cnQxMUhn?=
 =?utf-8?B?TWhlVVo2MXI3QWlyMk5WeTB4ZUF5YmkxNEdqazdnT01BQytXV1BYSEFTc1hM?=
 =?utf-8?B?Rjdpc1JzK3NMTGhjTTA0VEZERTZpRTVlNlVEdCtoMHhwY3Foc1FnZGg0Ums0?=
 =?utf-8?B?eHZKQkRBYXZXOC9ZOEI4dWxBb2xIdk9FV1ZYVmJrd2pqZXVxUlJ0TC9IWEVX?=
 =?utf-8?B?TFE0VytKT0pJLzlEWjVGVzcrTUtla2w5WndGam5TWVBSU1N6ZTVuSW9hR0c3?=
 =?utf-8?B?NlpqS0ExVG9meWpXbDNyMW41WFY5VUV4czlvSlFZY1Z6YzVRbXFOWkJzdFFs?=
 =?utf-8?B?R0FYYmsybEM3U0xpeG9jWXJnbTk1MFZjcW5LR1VoL3hUQ0FueERnQVJ2cHBT?=
 =?utf-8?B?UXF5QkREb1VZM1VmMXhOWDVibHFBY2NoMWxyNmtXMjlKTGpsUEtpTmxWZHVx?=
 =?utf-8?B?TWczbGw0dGRvcXdPOUorZ2M3THhuRGkwK1p4R2dEYXVLUU9GeDlacVEwT2hn?=
 =?utf-8?B?QUszemJUdFNGSjdwRUdodjhRMG4zLy9zWE9kQmg5THoxSkNQNWFBQUdPU1Ny?=
 =?utf-8?B?dHBweWsrbkFVbEhrdU42SWVjeW1wdElKNFFVSjdHS1dYNU5qcCtudlZ6cStw?=
 =?utf-8?B?MXJ1UFVpRTU5OWNIZ3pudVBFYzAvT0xBajQ0K2hiQ3RJY2VWdjl0U1Y0d2ZW?=
 =?utf-8?B?YUE1ODR1RVJBWFdDOWdlUDBqc2dCaTBnc2V2SmVNV1VXYW9NTmlJMUVLcHNi?=
 =?utf-8?B?NXJKK0pRb2lzbS9HRUJQbkl6YVkyVHVSRVppK2JZMlZUb0tHcHA4Y3ZCUEV1?=
 =?utf-8?B?cHhrOGdRTTFzSDRnZmt5WVlYclppbEd6WEk2Zy81aUlOVmFGMWtwVWRmbE9r?=
 =?utf-8?B?aGllSDFEOUhvWld5dDZUN0Q0bUxaeWhqUk9uNkdMUW1ZdTMzcm8rTXFBS1FC?=
 =?utf-8?B?d3FYSk1oUURmWTZLZmpIWFpiby9PVjF3UjJHNno3ckJ1SGNUVG9mbGgxZk1Q?=
 =?utf-8?B?ME1GVzRwZ2sySU0yYWlHU1ZQell1TUtDczB5RmFNSTR1RHh0VEl3NWV1ckVF?=
 =?utf-8?B?MXF1TDlkM0MrejZrcnhtODlNekdNUEpqWFZmVTJ2WkQ2alU5NDVQaFkwd3dY?=
 =?utf-8?B?WTFsaVRCWExhaENUOUhkMUd4UDArMEgwQk1hWG1WYldEV28wSis4Z0g0dGVN?=
 =?utf-8?B?SnM3TEV4V0tQbmhSUEYxYUZOdkRUV3dqMHVEMCtGN1NGd1pTRmVpSnVubjhC?=
 =?utf-8?B?RG82Tk1wdy9NNXYrWFltNFI1em04WlNka3ZTMzRicUVoSURobDAzRkpOOUo5?=
 =?utf-8?B?TTFUaktKTmNiK0wwb1RqNWJJeVJSOThWbUV4cHdiOXIzbFNBaWRFdUJvcUdW?=
 =?utf-8?B?SnZKcnhEdmdlQTk3c3FsT1d3WnZmTy9FaHUzSXRjcXkvMWdURmRQSDBaOS9s?=
 =?utf-8?B?QkcrYVBGendCTzJhdDNJeEFEU1JmTTE3dWdqamNHQ0JZcEk1b1J0a0NJQVBn?=
 =?utf-8?B?V0ZCdlFwaWVaandGa3AvcndBODVjMHRFTXY1VzNES0g4TXF5Wmg1aExKckRQ?=
 =?utf-8?B?dU4xUkFlcHFJMktEN01uYWxya1pMVXRteGUrV09WZFZiclNjK2tuUklvWkNI?=
 =?utf-8?B?TDhVemp4R2cyNnNKUFZXVG9xMW5VU09XMEhKd09XNmI0cGZpSGxCUmVhT0lQ?=
 =?utf-8?B?eE5XSkJ1UzNPTnRXdTNYSWFWazFBZUFDV2NoNlhRUENRSmNHTFRhcDRxcTVy?=
 =?utf-8?B?NDVCU3ErNUlQZmhlZVkvRG0xYkJNdUFoc29qWGtkOGJkeitkQlEwRTliU2FE?=
 =?utf-8?B?QWxrdnI2OUl4My9LZEhCcEtQbGlpK1oraGIrQlNUNkJBTHBKUmxNQ1F4c2Ir?=
 =?utf-8?Q?OMxQPy2R43HPTUabaN4quRhyD?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	BtTNkP4J4vrDxy/yizzU8sJY3+Zzhj4C9b1bQicdtFxwCGxkcURHvoTzUsVq+tNlpWrENV3o1Ve2UXVEs+efHJq/QKAfTpcuAN3pSR4QXYtdMwYYALzqwWvEcM6q0ZNmrwntdYhrAZvdZuee3xvhegt0fwvXjsEx9phN1e67VoYj/kVNh8ABx26mpy8rYMNYHFcmPAXgRH1HB23MewR2SFP6kHs3S3KkuqcanT3GbyqeAK/n06RIr5oo3YAg5SKgnPvOHPw8QJ18qH+qb8E1gXTN2zHCy4n9IWbcx9nxStHGQyCm74PcHRiXnnrpWldr2QbjIwVZZ4v+UEQ5wsHcwn+TnX/Tmdbov4xeT45O6w9N9L2VfogbDDQI020WHCiYGIRaVcIAsZXeWFnyWEubCnK0LAC3j+PGGQGISI+k9gWBe40LFcBOXtz733d37qkSKoPqxwVOrSGttG9NLOaMrkvNO0uKtX/TWmGhkXm2HBRcPmdSOjEN6OrN4zVV/Vcxq6+sKNimhkBuN07HAYsPE0Tn+DiuzFp8bKq/VyJlw7OmnXIuGWgnoW9FZPBD+vBLsx8YGXs3lH8czimd0ex6IJQaXtiZ6gpqOqL8X4b3F9A=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a2f755a-700b-48c8-fd99-08dc78f8e2b6
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 18:15:53.5769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /+/zs2XtEPGShhI6HhI7HrNzjnKuXN2Il9NSC6kSvyevyXcC9+kkeGogidilsdRjrrK0A5wXhiZ7w7TMzNZarQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6182
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-20_09,2024-05-17_03,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405200145
X-Proofpoint-ORIG-GUID: 7bNCTu2iCBgayjgq6-64XlTqDofveJ-1
X-Proofpoint-GUID: 7bNCTu2iCBgayjgq6-64XlTqDofveJ-1

On 5/11/2024 1:29 AM, Miaohe Lin wrote:

> On 2024/5/10 14:26, Jane Chu wrote:
>> Move hwpoison_filter() higher up as there is no need to spend a lot
>> cycles only to find out later that the page is supposed to be skipped
>> for hwpoison handling.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>> ---
>>   mm/memory-failure.c | 15 +++++++--------
>>   1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 62133c10fb51..2fa884d8b5a3 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -2236,6 +2236,13 @@ int memory_failure(unsigned long pfn, int flags)
>>   		goto unlock_mutex;
>>   	}
>>   
>> +	if (hwpoison_filter(p)) {
>> +		if (flags & MF_COUNT_INCREASED)
>> +			put_page(p);
>> +		res = -EOPNOTSUPP;
>> +		goto unlock_mutex;
>> +	}
> It might not be a good idea to do hwpoison_filter() here. We don't hold extra page refcnt
> yet, so the page state will be really unstable. Or am I miss something?

I agree with you.

It  looks like hwpoison_filter_flags() in particular needs a stable page 
in order to retrieve

a wholesome KPF_ flags set that at any time, although the flags could 
change immediately

afterwards, they won't be torn flags. For that, it looks like the folio 
should be locked as well.

thanks!

-jane

> Thanks.
> .