Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2632179lqo; Mon, 20 May 2024 11:19:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW0hKNumvbpW+RbulmmqK/ohvlVkOB1flhfJ+oY6wSsKtGocD55rXWMRU0BZqYONKWUn2ivry/yM0AdCMz+mKZfEk8djlB3DdrLYyKE6A== X-Google-Smtp-Source: AGHT+IGZPop0h94oW78Hev9bYKsGbF11dUMshUttHc9vFdDjRVioacC1kjo3aaWIY3eex86Z+bx5 X-Received: by 2002:a17:902:e74c:b0:1f2:f043:7765 with SMTP id d9443c01a7336-1f2f0437c72mr79745435ad.67.1716229172526; Mon, 20 May 2024 11:19:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716229172; cv=pass; d=google.com; s=arc-20160816; b=HPDBQURWS+SDHng6dw+UvOE19I4fqrTJztR2hJgWoZgC8lkGiTvJzCh7ve9jb0ILfc 82LVGwuY6WnKyPlPZPpQOspDhMDCLS7ESbVMRNOlULzSfwlFRWzWgbT9aclEJmxlqmdz zsFKZusN4QfOrRwGzjh98OPfquQa/tEnxD6UkssZZIJApjA9WlXxvzi9oyKk1F3DIPxe TBTO9x2AwfKaLR+9Oj5FHNjy1giExXbnx4Nzn/9YreXHkoRi1eLdomf1k6Fx3m9jWjFT kTBNQL7kTkMipz9AV2VDTCe+TFNZCZ9PGqZehRAN1q4wXIUf3RLyTnV1fxdInK5/Oa6I 3mmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=UV0Vw/qMOjwWgUro/BzTpPQePzxbzienYDyA4fIgerU=; fh=n9hALwov5RoLtndDKTo1gOapCU32FdsETURwUGvIUQg=; b=ZdCxwH7gxUDbL4is851t5W0wV7CR+hb/2Ulb8ildvjIlMbwwvEorncIBsTWfbLu7kA Bn2D3EgXMI6ShQplFxECngha8L6N2ZzTEx6WySNliazgttFmFA+TBDzxHgU+OUwkf+07 YUetRh9xeQTXsTg/hXjIexmnC1fN+StOz/1ntKmlkvDcjpHkg2sHW01zD3LqieNWV6hh Qpt3PHD6IX+N415n0nGYjrKmRGNAPnL7P9sjlXfVZ57rhSwUncb5LOuq9Nz/HZslXgic jvZk+iyNIxzUj6/N67wg5D/7xLUmYuHHcJf0knuyBd8+r1oMG5zhvUxkM2UwBmH9DLWz ZJVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=ugc2zAsG; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-184056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184056-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0b9cff98si233680995ad.72.2024.05.20.11.19.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 11:19:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-184056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=ugc2zAsG; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-184056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184056-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 21813B2116F for ; Mon, 20 May 2024 18:17:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE9F7137C2D; Mon, 20 May 2024 18:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="ugc2zAsG" Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7D711184; Mon, 20 May 2024 18:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716229032; cv=none; b=o49nKyYWT/xDP412yiuVlr7HF1yDMfQBjVINAaALCkjsUvZQby3qjq8zwgfz6/JecKL7uIuGT0HiGfw8XQ5XlRXcrjV9Sl7Td/4N26f+pn+1BT4faKpuSv+AkmRRKGPTSnq1k9fXyCutgYZhgqtqSU5d/fYTSiTa0yVxr0Z1DwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716229032; c=relaxed/simple; bh=W9S3tmYKAVI1vZm6O1FnsaIXgDq769OyLxHGWe+NJQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fySH02EE2iBTAGGI2xZ1YQ3cddAfe6NqRUWzV+SOhHuYBhBdzJz1CPmvNjk0LC4FBOu4J8AJBv/+WLlkQP5YROj+vI0SxDJNUAfU0vamOfIjCnQ07/5LYrqH/fvhsEVKiVNg4XnwPk0+W4boN0JOInqsRfVLnHMNAiJJJP2NwxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=ugc2zAsG; arc=none smtp.client-ip=199.89.1.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4Vjm4P6Nkbz6Cnk8y; Mon, 20 May 2024 18:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1716229027; x=1718821028; bh=UV0Vw/qMOjwWgUro/BzTpPQe PzxbzienYDyA4fIgerU=; b=ugc2zAsGCLq8K7mwlrFOthyOI83lgQ1f44aCKIAL 9jqLiBfd8sLSZWciEOIzNY+70wb5VBZJPMYEs/WEsuEeNtF49L2MTDgnazsq8Lkp tJJcmm43com4RC9pty9n27dQhDfDcYNfsZjkftL39L+eo6pFAbXRTb2wWP143rti M4WxJJaQUobOK6A74EZ2MShTVqA14cCPQu4RKZ7I2ZGnAd1wQD8l2KxuAGvKUi3a kRhuIQl/GAz/nToXgRRF8UjIqeCx+dsEyAJgfp4EN/nAGUT23KswBCDNo1iQr/m0 8FU3OBhGPcaCQV01wdw3QWdIrfRl26KeMCuTf5U1ZmNEtQ== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id gXAi3W1zJuCL; Mon, 20 May 2024 18:17:07 +0000 (UTC) Received: from [100.96.154.26] (unknown [104.132.0.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4Vjm4J4cJnz6Cnk8t; Mon, 20 May 2024 18:17:04 +0000 (UTC) Message-ID: <6c66018c-abfa-4306-84e5-d17841e87dec@acm.org> Date: Mon, 20 May 2024 11:17:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] ufs: mcq: Fix missing argument 'hba' in MCQ_OPR_OFFSET_n To: Minwoo Im , "James E . J . Bottomley" , "Martin K . Petersen" , Alim Akhtar , Avri Altman Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Granados , gost.dev@samsung.com, Asutosh Das References: <20240519221457.772346-1-minwoo.im@samsung.com> <20240519221457.772346-2-minwoo.im@samsung.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20240519221457.772346-2-minwoo.im@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/19/24 15:14, Minwoo Im wrote: > The MCQ_OPR_OFFSET_n macro has taken 'hba' on the caller context > without receiving 'hba' instance as an argument. To prevent potential > bugs in future use cases, this patch added an argument 'hba'. Reviewed-by: Bart Van Assche