Received-SPF: pass (google.com: domain of linux-kernel+bounces-184070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 20 May 2024 14:41:51 -0400
From: Frank Li <Frank.li@nxp.com>
To: Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 06/12] dmaengine: stm32-dma3: add DMA_CYCLIC capability
Message-ID: <ZkuZb2I83Q29kW6s@lizhi-Precision-Tower-5810>
References: <20240520154948.690697-1-amelie.delaunay@foss.st.com>
 <20240520154948.690697-7-amelie.delaunay@foss.st.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240520154948.690697-7-amelie.delaunay@foss.st.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IT1UsjhHMF19dY+1HROma/C0/v0J2W+YBkY5LN6LaF98ly8Ng1KIu+24f5ZO?=
 =?us-ascii?Q?GDejg7Z/Dj4mNSHraagLyTtrngLyn0BtCg0p1M7vWjJQLrhHGeb7EM/ndMY3?=
 =?us-ascii?Q?e7btqq1G9HrcOo4ROalXGruBv/ve0Z1ifUWAjWbMVNfo6eduA1MzK6r4fIgT?=
 =?us-ascii?Q?OsmCOngurqXh+AyuLWOW5k8EkrLo9IUKTV+DnyAvFzlFBeqoy6iasOZiNtuy?=
 =?us-ascii?Q?Km8nIjWbjV9/pYoNwRDUwcx0ZDNgEqpEpzDJ/3R2OPilWX07bMp53MJmpYXo?=
 =?us-ascii?Q?6gCx5Li7s9NninGVzpPDK5mHveyzpfYtOvwwPgsjF9Fq/gWvdrM36hPgZGqQ?=
 =?us-ascii?Q?jopPNo8W55wrnvLD4J/upN6YOouufVcmDfJJuMYLL8k3G4jRabauNlvUrFXj?=
 =?us-ascii?Q?8eLRL7s8R1txFgnahRJarcR6s0IKv/D+VcUzQcjnHS40j2sKT2o6pfl9SZvt?=
 =?us-ascii?Q?Lwyq3lc64c4QATTpSgG2DPGNRVVhE4DXOmQsXwBLZSrgm6p2Tn9KwKHsrBxe?=
 =?us-ascii?Q?PPppwgSACIGuDGKub4jWz1wdbfXGuNBbJ9XENLJihupCF91WD2nKbE9R+8th?=
 =?us-ascii?Q?86KILXPYd98RUrfS/UPVIlu4cBqZpK0wMjyPLA14qJCpU8Jdkgm4Nvg82zLM?=
 =?us-ascii?Q?CiMu6TxsyMvsr6nxgol3aVrY4pcxD1pbX/bdG9NikL5KxJ3XvERNx8PGlPXH?=
 =?us-ascii?Q?yXXKaT9SjMYf5zVGzrsavl+XEu0+0V3yWBDrfFqRhCASzJNY7LQrEutWddV7?=
 =?us-ascii?Q?GQKF5s8gWLM9rFovJfNEB3D3UY7YwdLPZNGCS6MXA47IwtlapdXUv92AkhRo?=
 =?us-ascii?Q?D6mWDYwUmS5RH1MjTXBqs3RFgMxGFopk6Oym2BYUZRiOEpjVwg2Waw43TV+H?=
 =?us-ascii?Q?aJcKiEIsZF97KWDsF5xboryMih4lh0bwAEclrDJFBFWNnNmszQ4qGbiLSezd?=
 =?us-ascii?Q?vp3/ra9eZprjcybGXXnNC60O5gXec6hcHVHHLhKVmnebFXqqjql3kZTXSagY?=
 =?us-ascii?Q?8o7vje9N2XeiXeucIo2cBb3YmpKCFenKMkJAumeaFob3x1Ksmuj3FDBAmm6M?=
 =?us-ascii?Q?Amquz7+tZioDta0lOt9Ja9sYaDk25LvWPmpQiddC3s4GpnbD9ZPa2xP6J2W9?=
 =?us-ascii?Q?XB079nJtwYZwC9MnmCJaB7c39X2DNTglvbKJUnAsoFZOazGcqTQhxod/5afS?=
 =?us-ascii?Q?Btev7AreleB3hXkl5ogHeAaUgqGv1hhFASmLTkWn/pbjI+CtVjTBrQmcLLDD?=
 =?us-ascii?Q?IzrFSDUskwXsQvjbJtdYZ4YCxt4gPRx6h52kJf8uDnoJDxYgJQXlID/jidFD?=
 =?us-ascii?Q?3kvQN1BQadjhO+xh/5cBQKUgkfkcw45zSReydxqrfS4J+guWq/9jCG3ADmxz?=
 =?us-ascii?Q?j5CaMKZH9U406tKpM/yl0COlPRj8fNn3mWP3CtRcYFjffGqrSjqv4t3dA7io?=
 =?us-ascii?Q?PGzlPRGKoKU0pLHQoRn1s2Ah3gUKbZVBN9PHpjhF/vOVGSkT9WEhZetyhC1R?=
 =?us-ascii?Q?1a0GZgfLDbJKFZUvRPL3EB6SzVm84B3s/VxEFlRSF4r7TjNUG2Dzb7cwHhrE?=
 =?us-ascii?Q?o7Fu/KdCFCwZ1FaWltxx/QClRXTuI1fvaBLvIRZ9?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18576f6c-68e2-41d7-861f-08dc78fc87fd
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 18:41:59.0218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RDJBI44qz58m7PYizLyLi6HUc3VBRtdJTYw62XlnP4TgxjfVb5wzQkKWzD5y8XvtBMKzlkhbZ7du/uzmjaZP6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9285

On Mon, May 20, 2024 at 05:49:42PM +0200, Amelie Delaunay wrote:
> Add DMA_CYCLIC capability and relative device_prep_dma_cyclic ops with
> stm32_dma3_prep_dma_cyclic(). It reuses stm32_dma3_chan_prep_hw() and
> stm32_dma3_chan_prep_hwdesc() helpers.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
>  drivers/dma/stm32/stm32-dma3.c | 77 ++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c
> index 134c08a7ee96..aae9fc018b1d 100644
> --- a/drivers/dma/stm32/stm32-dma3.c
> +++ b/drivers/dma/stm32/stm32-dma3.c
> @@ -1021,6 +1021,81 @@ static struct dma_async_tx_descriptor *stm32_dma3_prep_slave_sg(struct dma_chan
>  	return NULL;
>  }
>  
> +static struct dma_async_tx_descriptor *stm32_dma3_prep_dma_cyclic(struct dma_chan *c,
> +								  dma_addr_t buf_addr,
> +								  size_t buf_len, size_t period_len,
> +								  enum dma_transfer_direction dir,
> +								  unsigned long flags)
> +{
> +	struct stm32_dma3_chan *chan = to_stm32_dma3_chan(c);
> +	struct stm32_dma3_swdesc *swdesc;
> +	dma_addr_t src, dst;
> +	u32 count, i, ctr1, ctr2;
> +	int ret;
> +
> +	if (!buf_len || !period_len || period_len > STM32_DMA3_MAX_BLOCK_SIZE) {
> +		dev_err(chan2dev(chan), "Invalid buffer/period length\n");
> +		return NULL;
> +	}
> +
> +	if (buf_len % period_len) {
> +		dev_err(chan2dev(chan), "Buffer length not multiple of period length\n");
> +		return NULL;
> +	}
> +
> +	count = buf_len / period_len;
> +	swdesc = stm32_dma3_chan_desc_alloc(chan, count);
> +	if (!swdesc)
> +		return NULL;
> +
> +	if (dir == DMA_MEM_TO_DEV) {
> +		src = buf_addr;
> +		dst = chan->dma_config.dst_addr;
> +
> +		ret = stm32_dma3_chan_prep_hw(chan, DMA_MEM_TO_DEV, &swdesc->ccr, &ctr1, &ctr2,
> +					      src, dst, period_len);
> +	} else if (dir == DMA_DEV_TO_MEM) {
> +		src = chan->dma_config.src_addr;
> +		dst = buf_addr;
> +
> +		ret = stm32_dma3_chan_prep_hw(chan, DMA_DEV_TO_MEM, &swdesc->ccr, &ctr1, &ctr2,
> +					      src, dst, period_len);
> +	} else {
> +		dev_err(chan2dev(chan), "Invalid direction\n");
> +		ret = -EINVAL;
> +	}
> +
> +	if (ret)
> +		goto err_desc_free;
> +
> +	for (i = 0; i < count; i++) {
> +		if (dir == DMA_MEM_TO_DEV) {
> +			src = buf_addr + i * period_len;
> +			dst = chan->dma_config.dst_addr;
> +		} else { /* (dir == DMA_DEV_TO_MEM || dir == DMA_MEM_TO_MEM) */

look like comment is wrong.

DMA_MEM_TO_MEM will return -EINVAL at previous check. 

> +			src = chan->dma_config.src_addr;
> +			dst = buf_addr + i * period_len;
> +		}
> +
> +		stm32_dma3_chan_prep_hwdesc(chan, swdesc, i, src, dst, period_len,
> +					    ctr1, ctr2, i == (count - 1), true);
> +	}
> +
> +	/* Enable Error interrupts */
> +	swdesc->ccr |= CCR_USEIE | CCR_ULEIE | CCR_DTEIE;
> +	/* Enable Transfer state interrupts */
> +	swdesc->ccr |= CCR_TCIE;
> +
> +	swdesc->cyclic = true;
> +
> +	return vchan_tx_prep(&chan->vchan, &swdesc->vdesc, flags);
> +
> +err_desc_free:
> +	stm32_dma3_chan_desc_free(chan, swdesc);
> +
> +	return NULL;
> +}
> +
>  static void stm32_dma3_caps(struct dma_chan *c, struct dma_slave_caps *caps)
>  {
>  	struct stm32_dma3_chan *chan = to_stm32_dma3_chan(c);
> @@ -1255,6 +1330,7 @@ static int stm32_dma3_probe(struct platform_device *pdev)
>  
>  	dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
>  	dma_cap_set(DMA_PRIVATE, dma_dev->cap_mask);
> +	dma_cap_set(DMA_CYCLIC, dma_dev->cap_mask);
>  	dma_dev->dev = &pdev->dev;
>  	/*
>  	 * This controller supports up to 8-byte buswidth depending on the port used and the
> @@ -1277,6 +1353,7 @@ static int stm32_dma3_probe(struct platform_device *pdev)
>  	dma_dev->device_alloc_chan_resources = stm32_dma3_alloc_chan_resources;
>  	dma_dev->device_free_chan_resources = stm32_dma3_free_chan_resources;
>  	dma_dev->device_prep_slave_sg = stm32_dma3_prep_slave_sg;
> +	dma_dev->device_prep_dma_cyclic = stm32_dma3_prep_dma_cyclic;
>  	dma_dev->device_caps = stm32_dma3_caps;
>  	dma_dev->device_config = stm32_dma3_config;
>  	dma_dev->device_terminate_all = stm32_dma3_terminate_all;
> -- 
> 2.25.1
>