Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2662387lqo; Mon, 20 May 2024 12:21:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWs6H3PJfDCiMEDkqqYQv/EVtNHTVN83Qnoi4v/LMtyVx6m2Ny36ixw7dLYc6qFJaOvhPdYptRUTNx7BXo78NDsXXP66HJFCkJMOCcyeA== X-Google-Smtp-Source: AGHT+IF3SWjP1IDMGcNKv6+DMMxhMUPbuR305kA3RGVSJPeM2xGzSKTwUvdyBF/ObMNPehtVp6Tg X-Received: by 2002:a05:6a00:2e19:b0:6f6:94e0:79ea with SMTP id d2e1a72fcca58-6f694e07a53mr10326397b3a.32.1716232900254; Mon, 20 May 2024 12:21:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716232900; cv=pass; d=google.com; s=arc-20160816; b=EvXkaYD4f/YralNTlVt2U1zjaMTRmJI3B4PotmSJdv2SxbKX/hArTk3LRfzMy77dbF c6jFp/RUVhxw/2MYKFZWpWg8I2rzJXavqWQlew6X9UbZv1rXm8ZP+L6MkmcWzrZkJ2Be Qgy/N6PMQv39rD9+63pu1zYCdOpUfSob78CHnxMqBxcnI+bGBEnd6rQJE5K0bWAO+sCO Bjfs/6Uuz07+gPfWq5ObEvyE6yw3cN+iMBf6xakWY4LGhLD3wJijxH6mPlF/Xvf2HhQE Ulgn2wdksiRpTERn2GK8XfQvryJnSJcyzuWR6C7trZZFo8w1+tXFmLTLXeRelQ05dH4Y n7Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GZrTJtBwlpR/EVIjJPI2DkHMEGjnRsBhHUshv5q6++I=; fh=UwjCloVKq5SGRiZ0D5cgntxXXOHz8CykmNSiCi9d+Eo=; b=I8OYmzZsp89Juq8p9UtzNtbGbAj763cD2o+ycRSHshuoiB44dyGKkMEZCftlmkqIi6 xIWx7wHxKIlmN19B5lWTt0faaVsf1TkcmgaNXCUkM8tfe83tUP7ILymOEYodWFUkPNfT wLVYoHdwqOjZO6kGFKpzMKA9IKP8/CO7Bgc8CwXOfvX9C10PXC6ljQLOUZx4D06N6GIP Oik5oMLaQd7acfDEvxuYHlHM6KzGiGMi/Sj6BO1pqjxU0RdDYefALk/TkVzEapO2QIqV Y68oozz13CKEZnDy3YyJ2LJcK+KQuPx6TY+st3lnQAe6jxc3lOoVLoQAzPC0/qmuwoCG BzUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Lt2ig/R9"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-184107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184107-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-658c1225c7asi4017405a12.724.2024.05.20.12.21.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 12:21:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-184107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Lt2ig/R9"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-184107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184107-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EAF68B224BB for ; Mon, 20 May 2024 19:20:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 404EE1386AC; Mon, 20 May 2024 19:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lt2ig/R9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6CF137916; Mon, 20 May 2024 19:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716232845; cv=none; b=IBDiy0Zy95JHm2DfC0l5Ip+RCvzk8T4d93cTVOXptKuBFxxuc2LJqfzRapv5GezTXofOzBz+kAA/gAJ6O0eKW5v4S7jL6DNWM+zSrtWwwM6D1M577+Ee144Hr/w7VVlLY/n5ddK804uX777RHLQZsVRFapE5m+v0PVzgdA7AIaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716232845; c=relaxed/simple; bh=oFOkhPb/obahsAYRZ9KsMVQHApqTJjpvtfnG0CAlpL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PeJayvSoACwloymUYO+mK6QAyn5/CQ1PD2Rf/7uITHdV+yarDFFMvUBKTb4rk+untUteksKm1E1lXq1DrM9AkJXjxcig5iWRewruTD6BxQohRUv3HZnT8K+zRrHxaqGRqdim1pSbEdaAIw0ej+Q5fJqLRcNwwCH1oGOXV5KwplI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Lt2ig/R9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFCBDC32789; Mon, 20 May 2024 19:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716232844; bh=oFOkhPb/obahsAYRZ9KsMVQHApqTJjpvtfnG0CAlpL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lt2ig/R9v5B6a1wGEekuUUBqXgEerDXXUrGoa8lJHvufZ51MMeCMHexhklXZbZhg8 vfNC1H1ooY4LcBXOl3+rHwdPa4vjnV9xCqa2TkR3RP6wjE6nt0I0Ev/wu0/8NAFLXW aGL6iOT8jKAHauOPvxlSlOtXiGY0T/NLOwSzs/+qFOspLziNcER+wgLZON3rinocWg 08JOYx58n3YhEH85EAUmuiPG690CaBLY2hSnUp+galvrh+aE048NmxbI7kny6CdqPy kUADJod8DxBjFyaWszuhydhgWVTl/SgXtZm6OlOAERCm0mHb+EPlvAQ9JCIovH/sgi uXOAdIKwl1o/Q== Date: Mon, 20 May 2024 14:20:43 -0500 From: "Rob Herring (Arm)" To: Shresth Prasad Cc: julia.lawall@inria.fr, javier.carrasco.cruz@gmail.com, devicetree@vger.kernel.org, saravanak@google.com, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH][next] of: property: Remove calls to of_node_put Message-ID: <171623283323.1344625.8429412262018055075.robh@kernel.org> References: <20240515202915.16214-3-shresthprasad7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515202915.16214-3-shresthprasad7@gmail.com> On Thu, 16 May 2024 01:59:17 +0530, Shresth Prasad wrote: > Add __free cleanup handler to some variable initialisations, which > ensures that the resource is freed as soon as the variable goes out of > scope. Thus removing the need to manually free up the resource using > of_node_put. > > Suggested-by: Julia Lawall > Signed-off-by: Shresth Prasad > --- > I had submitted a similar patch a couple weeks ago addressing the same > issue, but as it turns out I wasn't thorough enough and had left a couple > instances. > > I hope this isn't too big an issue. > --- > drivers/of/property.c | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) > Applied, thanks!