Received-SPF: pass (google.com: domain of linux-kernel+bounces-184213-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 20 May 2024 15:26:37 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: Michal Schmidt <mschmidt@redhat.com>, Rasmus Villemoes
 <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, Alex Elder
 <elder@linaro.org>, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] bitfield.h: add FIELD_MAX_CONST
Message-ID: <20240520152637.065bb8a8@kernel.org>
In-Reply-To: <Zkuksm3K+pKugjgF@yury-ThinkPad>
References: <20240515172732.288391-1-mschmidt@redhat.com>
	<Zkuksm3K+pKugjgF@yury-ThinkPad>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 20 May 2024 12:29:54 -0700 Yury Norov wrote:
> > A simplified example of what I actually want to use in a driver:
> >   #define DATA_SIZE_M GENMASK(3, 0)
> >   #define MAX_DATA_SIZE FIELD_MAX_CONST(DATA_SIZE_M)
> >   static void f(void) {
> >   	char buf[MAX_DATA_SIZE];

You need a "+ 1" somewhere here, right?

> >   }
> > 
> > In the implementation, reuse the existing compile-time checks from
> > FIELD_PREP_CONST.
> > 
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>  
> 
> Hi Michal,
> 
> So... FIELD_MAX() already requires the _mask to be a const value.
> Now you add a FIELD_MAX_CONST(), which makes it more confusing.

+1, I think this is doing too much in general.