Received-SPF: pass (google.com: domain of linux-kernel+bounces-184288-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <78b3a0ef-54dc-4f49-863e-fe8288a980a7@intel.com>
Date: Tue, 21 May 2024 11:09:21 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/9] KVM: nVMX: Initialize #VE info page for vmcs02 when
 proving #VE support
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini
	<pbonzini@redhat.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240518000430.1118488-1-seanjc@google.com>
 <20240518000430.1118488-3-seanjc@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240518000430.1118488-3-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1ppaGc5cXlEcnN4eGVmb0oxK2s3VEx4a1B2QU9nM0F1K2ZEYjZsREc3SG91?=
 =?utf-8?B?M0V4TWNIMmJyS2U3UnVGb0lQM1hSU3c1eC9aaHhPVW5PamJXTkFWZEFhWnVD?=
 =?utf-8?B?aUtEeG4yR2NBempURkJ3RUQ1RjZNeUJ1MWJUMVMyVUovd1h1QXh1TUpmRlI2?=
 =?utf-8?B?bFV3SGp6MmRpVGFSNUQ0am14bnU1bi81VmFUcHd1T0dQMXFzVk5rNDkvajRG?=
 =?utf-8?B?d1lhNSsxYWV6MG9kYTRSNHpNUVd2TExUQ2JRV3hZS0FBRURLOE1wMnRJKzBP?=
 =?utf-8?B?Vm1mbUpacGwzUGw5ODRWclhzdVNDL0s5RHdoVXlhc2Q4djl6d3Q3d0M3U3FZ?=
 =?utf-8?B?aHlFRmJMVFZsWG9jcXRhZysxczlNOWtNSnJSellOM1ZrbUF6YkhUNVE2UkNE?=
 =?utf-8?B?WUtVU1l5cCsydXpOamxoN2U1WnlmMEpqUzNHUUNJQVlRRVA5UktNOFNkV1Fr?=
 =?utf-8?B?bkVrbW1DbUFBMk9aTUhHNFZwM1RyNjBOalpGMWdMeFQ1WFZRVEUrN2lNZGti?=
 =?utf-8?B?VXZrUFBZbHJma2tlaW1qR2JvRkVDU3hXMjZQdDA1UDFYQTRwVU0zOUJFRCtJ?=
 =?utf-8?B?cTBzNXV6cDUxNW1lcVR1UUNjZDlRR1FsRzgvZEE4Y21VVXJKRjFweVZvM2Jr?=
 =?utf-8?B?eG92U2pkZWFNc1JaL254dHI3SXI5eGF1MnhRMHlUc2ZacnZBbXNWQmhIczZK?=
 =?utf-8?B?Ym1uTEVMa0QvYWVLSjBtZWVoZktORy9MNE9Bdjg2N2ZFWk5MTVpMdHNueXlV?=
 =?utf-8?B?ZXQzS0dlbDNobGhOVkx1NUhwUFM4dnEwSWUrSlMvNEJhSFpMOHVYVkFSUUN1?=
 =?utf-8?B?SEQyOXdOUlk0cEp2bGV3Y21LemU5ZEtRcVU1U0hDczRoL2VNYm5rUC9Sb3BU?=
 =?utf-8?B?b3ZGWXo4NGtZSkUzdTRhRGpKZTkwTlErYnU2dUhVVXQ1bHZ5UllLNlBRYWow?=
 =?utf-8?B?RzdJRWt4QzVqYTJLZ0p6aTR1YWtaRENaOXlrWS9INmxxNjc5a0hnVG9Rd3k1?=
 =?utf-8?B?QTFhaFNxZExIRjBjdXordGUwVHFsNzdZWm85K1hvWnV4R0Y3ZlRpVEVJSFlt?=
 =?utf-8?B?dXI4cU5qVlBBMGtQeHN3WnlEZktNSTVQYXp4MDgxakN2NXIvdlhtMjB3b0xU?=
 =?utf-8?B?em8vZVpFaDZ3RUsrSi83N25hMkU0TUxvcDJ0R3RoNVI0Z3BDS1g1SXU2U2hI?=
 =?utf-8?B?c0RyWGVSRy9ZSU5oc01PK3NnY1VZZTNRSmRCdUI2N205U2pXZlVnQTFvOGdR?=
 =?utf-8?B?em5YZkp1bFp4UEtSTk9JTDh6cnY0M2QwdDVod3gxVkhReDlldWZHcTBiZFM0?=
 =?utf-8?B?MTc5eWZzWVZWNTMzVDAwcjhwVndhbDkrbUhDTk1pamJENXNIdVNleTJ2TXh1?=
 =?utf-8?B?OXE3NTY4WEJuNTQ5LzA2L3lINDArUUJKMmJFWjFFdjV3WWQ2L0xuVnZEWHlO?=
 =?utf-8?B?UGp2bE5OaUtka0twY2s4VjNPVFg0bG1MaW1nSzNUU21iKzhRYVk1NFNVeXhx?=
 =?utf-8?B?WkZCVys4enpONnF3WFg3N0cwWElxZW83SWd6dWdhNmhXN1ZZODNuQ2JGbDQ2?=
 =?utf-8?B?S2xld2xDMzVlYVc3QndYa2poSk5xbExmdnhydHQ0ZUtpSU1Bb3dGdVBmVm9z?=
 =?utf-8?B?NTRkdlVvT0kxcVZ2amhkUHFSN09hTkNoUFRQcEhLSCsrdEhJTkhJcXpZWGZh?=
 =?utf-8?B?NytJSndnUStKZ2dUL2dITVk3dmMwbVE5WVkwNTFQZjI0NFBHRFlFalZZdlFQ?=
 =?utf-8?B?RnRLMVE5ejMrUFkyUHFWNi9RVTk0dFBLeDJuODZtZHpvWnVTWXRCUEVOZkhN?=
 =?utf-8?B?czFYMVYyVldZbFJlNmxSbTVVaXN3Ri9wQTRJaFZqZDBrVmhmVzQ5MHA5N0FR?=
 =?utf-8?B?RTlnRGhJczhOcDZSUlo4SkY0a3ZjRVJ0R0taTFV0ZTRhNm9QSmg5VlJDM1V1?=
 =?utf-8?B?Y0NWZ1VHVDQyQjluVy9WbEgyRU0xbUowd1libEswMzZjWVdHeTlid2dNZU15?=
 =?utf-8?B?MEJ5Tm93NUN6VGdxWkJraVlBOHAwdjJXRk1mTjBubjVYK1JhYUpTdnYyd0JW?=
 =?utf-8?B?N01QYjBHZEd4R3VIVHZsaHVUZ056d3BabjF1TWxoZGtWVnV1NVUwZktLNXhB?=
 =?utf-8?Q?8cuux1LI0auc4iE5LSiNgXqI9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0827366-a94d-4370-c16b-08dc7921ecf8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 23:09:39.8270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SDCyEcMIeOzsYeuEKuLUE+X080nD5PUiNKIZIFbr9fSkiE+ITlQj8wqf+d4y8xSUz3YJ2gQfj3hA1ePRAMFAHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7924
X-OriginatorOrg: intel.com


On 18/05/2024 12:04 pm, Sean Christopherson wrote:
> Point vmcs02.VE_INFORMATION_ADDRESS at the vCPU's #VE info page when
> initializing vmcs02, otherwise KVM will run L2 with EPT Violation #VE
> enabled and a VE info address pointing at pfn 0.

How about we just clear EPT_VIOLATION_VE bit in 2nd_exec_control 
unconditionally for vmcs02?  Your next patch says:

"
Always handle #VEs, e.g. due to prove EPT Violation #VE failures, in L0,
as KVM does not expose any #VE capabilities to L1, i.e. any and all #VEs
are KVM's responsibility.
"

> 
> Fixes: 8131cf5b4fd8 ("KVM: VMX: Introduce test mode related to EPT violation VE")
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   arch/x86/kvm/vmx/nested.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index d5b832126e34..6798fadaa335 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -2242,6 +2242,9 @@ static void prepare_vmcs02_constant_state(struct vcpu_vmx *vmx)
>   		vmcs_write64(EPT_POINTER,
>   			     construct_eptp(&vmx->vcpu, 0, PT64_ROOT_4LEVEL));
>   
> +	if (vmx->ve_info)
> +		vmcs_write64(VE_INFORMATION_ADDRESS, __pa(vmx->ve_info));
> +
>   	/* All VMFUNCs are currently emulated through L0 vmexits.  */
>   	if (cpu_has_vmx_vmfunc())
>   		vmcs_write64(VM_FUNCTION_CONTROL, 0);