Received-SPF: pass (google.com: domain of linux-kernel+bounces-184290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 20 May 2024 16:13:57 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, <linux-cxl@vger.kernel.org>
CC: Ira Weiny <ira.weiny@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>, Vishal
 Verma <vishal.l.verma@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] cxl/events: Use a common struct for DRAM and General
 Media events
Message-ID: <664bd935b9eb4_a02829444@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240518113317.3683718-1-fabio.m.de.francesco@linux.intel.com>
 <4446774.UPlyArG6xL@fdefranc-mobl3>
 <2114228.Jadu78ljVU@fdefranc-mobl3>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2114228.Jadu78ljVU@fdefranc-mobl3>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHdWczQzdlVVd1V6cnYyaVptQXFLRVFwNmJrd0pQOVFxWlNuN0lMRW1SOGV2?=
 =?utf-8?B?cTJqWjJmUGMwRzRLUmhYU1QyMFpZMEk4NWYrbzVCZjhGSEgvdW8xcmMraXkv?=
 =?utf-8?B?RTR4UzhkbUdmYzR4a0NuZGpOYnJNdmZCcEs2VlRZR3JKaklFWUhGUmtYQ05o?=
 =?utf-8?B?bmZGWU9XcTR6WGRjdnBVMHo2WHRjejZIdng1ekNuYzJEc0JpRlNZZVdwaGli?=
 =?utf-8?B?YXh2M3NXMzJmU2UxVk1RWTdvUVNTbUYrbFNETEZWY0p2MXo4KzdPclFWaC9M?=
 =?utf-8?B?aVJOdVg3SnRPVFlENnpLQVlRVTFvKzh0MWMza1g1WTdaUGp5c1JJRTJaRncz?=
 =?utf-8?B?dHR4bG5sazREaStxUnIrTFJ6UmRPMzNFMTJ1ZTVzRzIzUU5UUXJLa3RJdUtq?=
 =?utf-8?B?Smd5NWtWdGFTWk0yWC91UlUyUHVSSHFwY2xJSG1lbVM4d3lEMmsrUDljOXVm?=
 =?utf-8?B?Q21lRTdlQjdXeGpkUnZZRUxWNmdlWHplQ3RYeUVmbU11Z2FUN1pwZnVXNG5U?=
 =?utf-8?B?OFI0eGxIcUFRRlo2OXl6ZW1DQTlNZzFYQ3VjR3B2VitXblNaeXdVNUFrY1Uz?=
 =?utf-8?B?YzJ5QXJrRTdWNGlUMVI1WXBNUnlHVCsrOHg5aFlKeUFUa2E4NU13YS91OGUv?=
 =?utf-8?B?NWxJOWxGTDRta2p2UUNaNnJJUS9VTlo3aXlKMFFXeVVOM3I5TVJNUkU5Q0xP?=
 =?utf-8?B?MDhuYmV0T0xsSHhCWVE1QVdvRktDUXNMblF6Qkc2Mk9wbk4xZk9DdnVnUlJL?=
 =?utf-8?B?ekZSUWlha3AvbDRiQjdRRk1rajhNazhId05qQnh1R1I3NklTYlJud2VWaWE4?=
 =?utf-8?B?dDZ4c0VPMEwrL21UV1RyTWh5UzFWQUVaRHVCd1Z3WDVkOTF4Q3VKRkQxRHND?=
 =?utf-8?B?Wmd4ZnVoOWh3MUVDVGJ3QkRWNktndFczS0pobTBNTE1idWtGbW56NlJoQXE3?=
 =?utf-8?B?ZTdWWWxTelZTbUhZSUNMbDdVK29sTFRSUjJJYW5mU2RyblY4VlFzOW9LWm85?=
 =?utf-8?B?QnMrT1EyL09HVzFWSnE2TWNpcTJwY0Z5Z2NYYzRnZDR0b0tPVVdmSE5wQ1l6?=
 =?utf-8?B?ajRyditPbmhBa2V4eUxBVHRYWDFDdWdiaVJ2OGRDbFRZZEtSVW9UQVJDdnZi?=
 =?utf-8?B?bURVUCt5R0dZWEpVRjFQVlRvaStOUjBPOUZGeDhFMUtxT053ZHB0ajMwaXF4?=
 =?utf-8?B?Ylo3c2Y4Tjg1V0VjeDZtQkFVOUdVZ0x4NDRHQXFLZlhsVGpINW9Qb05zVm55?=
 =?utf-8?B?NFFqN243a3h0SW9obU9pd3lONm5LdU9LWldnSjlNSFE5TWxmYU9NUWszVkJh?=
 =?utf-8?B?bDJPUzNZTlZlTGt5MnZYZHhzOUVZSTRLK1pHSTNjRkF0dnNPS2xCOExMTTNB?=
 =?utf-8?B?cDdLcTlNdHhlL2xXU0ZQSkovVk1jQXJHSW9FNjBhYm5WcUhNbnhFSllIT2Zm?=
 =?utf-8?B?MThCNHVyODUxSFlDazJXd3NkZmM3VC81QitUYXpSQk90QUFwSS9nVXV5MDhv?=
 =?utf-8?B?OGdQZWlBeDhTbkNTWVAzUG1TTE5Rak9WVXJSN01ncjFVL0trL1Q5VGNYSDFO?=
 =?utf-8?B?V3ZSQ3RnVjVjVVJ3SGhGZ1l5VnZ5VUVvNFdzeEdDZUhFS0Z5RURDNzBOTVFv?=
 =?utf-8?B?WVAwcFF1Q3BseFIrOXdnazlzV2tLT2JxUGNCdm5vSzhQcXN1T2pQdnc5bHVq?=
 =?utf-8?B?Z3FyVWVEdkpyWWVXRDN6cm0rUmV6VWNPcUpYZWIxQit6TEdUdDdjNmhCR1Fm?=
 =?utf-8?B?UlZwMktxNVZVMnZpWVIyMHJkNkpGR1FQZTlvR25yVEEzWGcybVZZMzUrY1JS?=
 =?utf-8?B?ZDNROG1zcjdzRndGQVBicUlUSkxyT0dtUWs1L2N2YjZVbXlIdDdPTFFpcUl4?=
 =?utf-8?B?OHFBekFwNXNRQyt6eC94ZHIzdUhQTGxrRnRiV1NBajdwMUM1RGQ1SjdaWnVs?=
 =?utf-8?B?WmJwRjR0QVJ5SDVJWXg1UHBQMS9tNUpwaENXeGdsZXBXVTJ3cnY2N2d2Umh0?=
 =?utf-8?B?YTNlcjZqNXM1OUZ5TE5TVzRnUFRQRkh5Y01lTmtqanhkWENuZ0g0NUM3U0lo?=
 =?utf-8?B?azVtRGF5RFFBWnNHb1lWaTl1WnJYVHRZUExZc2dkcHF0VjdBalpObDFPS0l0?=
 =?utf-8?B?akpMSVlocFczakFZbWV0MnJBM1d6UUE2aCtrQ3RCd0xkd3NLZWdXYUtscTYv?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d3c4f2b-ce99-4acc-7c18-08dc7922881b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 23:14:00.0497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mitZBOScvcv+PF0CAgHLBaiMc4ngZCKkprd/OFv378+8Z+dmYn1K3DHiW+58gZbiz0QqWT17ojg/Mt7eQFjUIFd/udMzzCpC9Zvxvyh3w00=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4771
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> On Monday, May 20, 2024 7:55:17 PM GMT+2 Fabio M. De Francesco wrote:
> > On Saturday, May 18, 2024 1:26:21 PM GMT+2 Fabio M. De Francesco wrote:
> > [...]
> I suspect that I didn't clarify that the diff above is proposing an additional 
> little change to this patch (for v4) and that I wanted to collect comments 
> before applying and respinning.
> 
> To be clearer, that diff is meant only to show that cxl_event_media_hdr can be 
> removed from union cxl_event at no cost while still be used for the common 
> fields in the definitions of cxl_event_dram and cxl_event_gen_media.

I agree with Alison, this is what a union is for, and more generally,
runtime code should never be added to make up for deficiencies in the data
structure.