Received-SPF: pass (google.com: domain of linux-kernel+bounces-184304-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 21 May 2024 01:26:28 +0200 (CEST)
From: Jan Engelhardt <jengelh@inai.de>
To: Tejun Heo <tj@kernel.org>
cc: Linus Torvalds <torvalds@linux-foundation.org>, 
    Craig Small <csmall@enc.com.au>, Yafang Shao <laoar.shao@gmail.com>, 
    linux-kernel@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH workqueue/for-6.10-fixes] workqueue: Refactor worker ID
 formatting and make wq_worker_comm() use full ID string
In-Reply-To: <ZkvO-h7AsWnj4gaZ@slm.duckdns.org>
Message-ID: <8r004s1r-06r2-1pq1-4s29-6177np23q0rq@vanv.qr>
References: <o89373n4-3oq5-25qr-op7n-55p9657r96o8@vanv.qr> <CAHk-=wjxdtkFMB8BPYpU3JedjAsva3XXuzwxtzKoMwQ2e8zRzw@mail.gmail.com> <ZkvO-h7AsWnj4gaZ@slm.duckdns.org>
User-Agent: Alpine 2.26 (LSU 649 2022-06-02)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Tuesday 2024-05-21 00:30, Tejun Heo wrote:

>Currently, worker ID formatting is open coded in create_worker(),
>init_rescuer() and worker_thread() (for %WORKER_DIE case). The formatted ID
>is saved into task->comm and wq_worker_comm() uses it as the base name to
>append extra information to when generating the name to be shown as.
>
>However, TASK_COMM_LEN is only 16 leading to badly truncated names for
>rescuers. For example, the rescuer for the inet_frag_wq workqueue becomes:
>
>  $ ps -ef | grep '[k]worker/R-inet'
>  root         483       2  0 Apr26 ?        00:00:00 [kworker/R-inet_]
>[...]

This patch works satisfactorily for me.


Tested-by: Jan Engelhardt <jengelh@inai.de>