Received-SPF: pass (google.com: domain of linux-kernel+bounces-184308-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <26e49614-ddb5-4d4c-97c1-a3a8c06d5bb5@oracle.com>
Date: Mon, 20 May 2024 16:44:53 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/hugetlb: remove {Set,Clear}Hpage macros
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, vishal.moola@oracle.com,
        muchun.song@linux.dev, peterx@redhat.com, osalvador@suse.de
References: <20240520224407.110062-1-sidhartha.kumar@oracle.com>
 <ZkvdAGyua4daHg_S@casper.infradead.org>
Content-Language: en-US
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <ZkvdAGyua4daHg_S@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MlFObkJramRpdDBPY2hmajhjQWhHemlpVTNoNkE1N2Evdmc3MzQ0cXhqQmVF?=
 =?utf-8?B?UEZaaVVEZlFkUk0vNzIwbTJWRXlXbHFXa3labDNlUXNncWw5YzR3cnJWOE5x?=
 =?utf-8?B?Tko1M1dPaVhzQlkyQlNrQ1lwRklQbVp2VFBWNExwOGhWaVdYSitUMGFLTUFR?=
 =?utf-8?B?ZDJJWGtqRzRiYTFMTUUzK2JDYnA4ZkZCZWJ1WFRmdkg2dlBodW4yOFJrRG5q?=
 =?utf-8?B?V2VtdDhxMk1laGpLMm8zUTlPRFI0WUdDT3k1TTFmL2RBek5ibXRQN2RKUzFi?=
 =?utf-8?B?cmMycnhwUjBJT3hxWG5xMTkvdmduekdwb29wdmgwQVkxUEZGY3ZjeHFJWEFD?=
 =?utf-8?B?blRpeThqYUJYUjN3Y0p0U0szMkkrdTVPUXRLNWNQakhiejFUQjhaeVVMaEgr?=
 =?utf-8?B?MVJRZldUY2RCS3lWNUw3L1dzSURVbXZ3ZjdheHVHcEZ2UmFhZjhuN3ZzRXNB?=
 =?utf-8?B?WWNZYU9wTFJuemJ6dFdsTUkyOGhaR2tCZmV6dTh3RFlvMEZOUHl0bnNsWTZz?=
 =?utf-8?B?cDJ6bWtFZk1LWmhMdnFwTElLNXFxRnJHSzFIMXlyeGp3Nk1vQUlzdkF2S3hD?=
 =?utf-8?B?bkNiT2lFUGl5dXhBb2NKZllWcEZiNXVqUmFGSUx4a25tRmNIN1dLdmlKQyt0?=
 =?utf-8?B?UEJZZWt3SUlldm0yOGd4aTBFS1hheEtOVDRLRzJsNUlKeVB1eXFOYTY2T3RG?=
 =?utf-8?B?Qnh5V1pjeTV1OXMyQm5IU1g2ZG53T2U4WWVvZlFMNVZXWTFsMmozUVo3MVRn?=
 =?utf-8?B?OCtGZzVKR3BBc2JHNXduL2xPZEpHejB0Qm1TQ0kvckR2czdsZFdMTkVMM0Y1?=
 =?utf-8?B?RkU2Sk9GVzIzU1c5YUdSOHFmRHd6eTZFemVHYWV4ZEFJRGhOKzZrdnRwQmlC?=
 =?utf-8?B?SEhaM0c2cFRHWTV1VHBxNE1lTThWV0pVRWE3R1FsdkRmYnVvR04rZXRpUEZZ?=
 =?utf-8?B?djkyZ3lSeEEzMEI3QkdqT0F6ZGJ4ZDNRdzJMMld4eTIvc0NMc2JHQ0xtbFFn?=
 =?utf-8?B?bWNjRXA3VVhYa1VOTkduM3NXQjdSZHlLUWE2SmphNlRwOXg4cmppY1BycXlh?=
 =?utf-8?B?ellzTmhwVWh5dW9BWkxHYkgyb0xwSUhEbVpEMVB6TDVkU0xmR1hidUs2dG9H?=
 =?utf-8?B?a0lLOHpSRmpKYlZZVkFwUVgreVlvVzQrVGJOUHdHYS9teFNEQTlKcEFUV2VF?=
 =?utf-8?B?NEFuTW9hTDRHbThad21ycGhZbHNFZkN4TExlTmRjWG5FdW5zbjkrYWlGdnZ2?=
 =?utf-8?B?ZXJSSS9BSk43Nk8vY1FSdkJmczNGWmIrRHdnYmk5NERTd0g5VXp6Sm5Od2VM?=
 =?utf-8?B?bDFwSUNtWkdYSXdWQnQ5NjMwbG1BMGRYcEFBNEFqS3I4OWdxUmdhd21NbTJL?=
 =?utf-8?B?TUQ5WDBlYUs5NXZaT2V0d1hONFpveE1sSUVURHJFdW1Qay83cy8wOVdZREMw?=
 =?utf-8?B?UFhBdmpERTVpWE5JWFdXMDdsWnArR01YMDMyTUJaOWlCNkhtWDAzbEFsM3da?=
 =?utf-8?B?REVOV2Zldk1sZG9xSE5NZ25QNVkzV3BsME12Q0lCcVEwR0FvTlB5UGlCS0pu?=
 =?utf-8?B?ZW9YWTNTNVdLQUNNZ0dST1FYUldyRFFqa1dYSU5pQlZkVGExSXJTRnRJSjFY?=
 =?utf-8?B?QUNPem9GQmxpa3pqV3Nmdld6SWREb0FkMUhzUkY3UzIxdUxiWnBwb0Z4UVFE?=
 =?utf-8?B?aHRaMXRhK0VTdnNobXc4VEdGOGUyV3VNWE8xeElrSUFrdE1uOW1WZDNnRERT?=
 =?utf-8?B?K244d241UU5WYXQ4anB0alpjdG5ZMDJPWW5YTDBPSjkyd2I4MlRCWmJ6aEw0?=
 =?utf-8?B?K1F2Z20wQU1Fd3E5WXZ1eGE3MTdWbnh1bnQ2RStpNU1LdDNXU3B1K0pMbzU0?=
 =?utf-8?B?S09nTFAvaXNXOGkvODhETXRsTzBzaFNlbXpCN3ovRWp3aXpiZkFZMTNwbDlj?=
 =?utf-8?B?MVRKMmZZS1FkdnkycEFDQ25zMGQ0Um1XRnJsM3Zlck90TmF0Z0wzVElaTWRy?=
 =?utf-8?B?cXZsRWQ1a2lXYWd4QWVTVU0zZUdNN1lsaW9ldDVMQU1wQVlQcWNBQnFqVE9K?=
 =?utf-8?B?cG9xVFplWVJDYTQyUksyVFFhVXc4dVdYUW1HY0pLRDhGWVpBdjdPbjdQRkpS?=
 =?utf-8?B?SmlqcVlaR1p4aGRoTm96elZBdWp6V0tDdng2VXdFalB1Z0FpWW5rM0RmZE1T?=
 =?utf-8?Q?0tS/M3QOd1TdmXbnMGRQlhE=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	9cbuaCN5ZLfAEV+TtPDmMBUtB+ld33WiTPw2V4FAPORpSdRya60wU5ogTK2VMdzkuKHSU8xH2YCYNusfJtpxw5B93gks+Of7lQX7+3B2a/8KlNwyleewpLI5Bt9pZfX0ckNMu9oG+3Y/jr9OiAjVREOxyHEyJ39qIX7SVP1MKVmDVD1Wl/VnemwsG1wVUPVjG6SPaJAsImwQoqaGPllbdkvrNs/dLOn44aczhfsjXcwbCqDD0SDV1XBrtMdXPlqSqb+CcTKalYufVWEO/FRdr/mTeBohAdBXTteCH9V3CjJki7fghp7xJSYdfuULds6DFfmc1d0Z/tUlg4ZwPw4N48uTVHIt02UqkEFmKqN2DOwvL5I0Hot9sVsSpZo0S5T5G4uCxdtaSRwVWrSqoVQT6QFNcQxKIUQ6JyS6+SfIM87D7n355i6qMof2zIGLckq8zeLfvoQiEpIjpYHUtOfNNNbOwIQz4+kFMOIEbprB3TAq8L8XCQ6e0C2Dgy3x9878u62aRL3kekQSzO5tmDO4Xw010zeOCZfKK+c7diZnUPKE0YREGfr6YY7DkSuN9o7+ma5/323CJHZsY9s81ep4s4K98Q91yAQAkxBRdk70Rhs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45222651-532b-4035-7807-08dc7926dafb
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 23:44:57.0557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mulgsf9vW5v5uG4NDMXH+At9lW82yZeG/LO1Ay0E7kNjQsc9tNeS+Nu7Oy0SjIbF+w6e3RO8pHPrljV4qrI1TTzfWmLgPcYO3gWt0e4td1s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6506
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-20_13,2024-05-17_03,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405200189
X-Proofpoint-ORIG-GUID: jTM_tmeeaYDLaUh3UJrH0F39Rw6dNefP
X-Proofpoint-GUID: jTM_tmeeaYDLaUh3UJrH0F39Rw6dNefP

On 5/20/24 4:30 PM, Matthew Wilcox wrote:
> On Mon, May 20, 2024 at 03:44:07PM -0700, Sidhartha Kumar wrote:
>> All users have been converted to use the folio version of these macros,
>> we can safely remove the page based interface.
> 
> Yay!
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> 

There is only one remaining user of page-based Test version of these macros.

in mm/memory-hotplug.c:

		if (!PageHuge(page))
			continue;
		head = compound_head(page);
		/*
		 * This test is racy as we hold no reference or lock.  The
		 * hugetlb page could have been free'ed and head is no longer
		 * a hugetlb page before the following check.  In such unlikely
		 * cases false positives and negatives are possible.  Calling
		 * code must deal with these scenarios.
		 */
		if (HPageMigratable(head))
			goto found;
		skip = compound_nr(head) - (pfn - page_to_pfn(head));


I've previously sent a patch to convert this to folios[1] but got feedback that 
it was unsafe. But I'm not sure why replacing compound_head() with page_folio() 
and using folio_test_hugetlb_migratable(folio) rather than HPageMigratable(head) 
changes the existing behavior. With no reference or lock, can't the head pointer 
also be moved and no longer be a part of page like the comment states. So would 
the folio conversion just be maintaining this level of existing un-safety that 
the calling code should handle anyways?


[1]: 
https://lore.kernel.org/lkml/Y89DK23hYiLtgGNk@casper.infradead.org/T/#mb3a339b98386b1cd0b87f94f45163756ebd7feaa