Received-SPF: pass (google.com: domain of linux-kernel+bounces-184328-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <1715945202-30045-1-git-send-email-zhiguo.niu@unisoc.com> <Zkup-c2K74bxVJ0i@google.com>
In-Reply-To: <Zkup-c2K74bxVJ0i@google.com>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Tue, 21 May 2024 08:56:44 +0800
Message-ID: <CAHJ8P3J=qJMp=VjB3Ui19AWAf3O3df4bmNwhMo0Rg_Nf+w3Y7w@mail.gmail.com>
Subject: Re: [PATCH] f2fs: fix to check return value of f2fs_allocate_new_section
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Zhiguo Niu <zhiguo.niu@unisoc.com>, chao@kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, 
	ke.wang@unisoc.com, Hao_hao.Wang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 3:52=E2=80=AFAM Jaegeuk Kim <jaegeuk@kernel.org> wr=
ote:
>
> On 05/17, Zhiguo Niu wrote:
> > commit 245930617c9b ("f2fs: fix to handle error paths of {new,change}_c=
urseg()")
> > missed this allocated path, fix it.
> >
> > Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > ---
> >  fs/f2fs/segment.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index a0ce3d0..71dc8042 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -5190,7 +5190,9 @@ static int fix_curseg_write_pointer(struct f2fs_s=
b_info *sbi, int type)
> >       if (cs->next_blkoff) {
> >               unsigned int old_segno =3D cs->segno, old_blkoff =3D cs->=
next_blkoff;
> >
> > -             f2fs_allocate_new_section(sbi, type, true);
> > +             err =3D f2fs_allocate_new_section(sbi, type, true);
> > +             if (err)
> > +                     return err;
>
> I hesitate to apply this, since this may give mount failures forever. Do =
you see
> a real issue with this?
Hi Jaegeuk,
No I did not have a real issue related to this, just found it by code revie=
w.
it is ok not to apply this for me .
thanks a lot.
>
> >               f2fs_notice(sbi, "Assign new section to curseg[%d]: "
> >                               "[0x%x,0x%x] -> [0x%x,0x%x]",
> >                               type, old_segno, old_blkoff,
> > --
> > 1.9.1