Received-SPF: pass (google.com: domain of linux-kernel+bounces-184349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fa885eca-d7e6-415a-8a08-9103b002c6bb@amd.com>
Date: Mon, 20 May 2024 20:35:06 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amd/display: Add pixel encoding info to debugfs
To: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>, alexander.deucher@amd.com
Cc: Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Aurabindo Pillai
 <aurabindo.pillai@amd.com>, Hamza Mahfooz <hamza.mahfooz@amd.com>,
 Wayne Lin <wayne.lin@amd.com>, Hersen Wu <hersenxs.wu@amd.com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
 Fangzhi Zuo <jerry.zuo@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
 Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240520210817.9943-1-rinoandrejohnsen@gmail.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240520210817.9943-1-rinoandrejohnsen@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzZXcWJOSmNYd3FsTEdrRWRQTXJMcGtTdmpXYVU2N2JpdmNmT2JqQ3ZSQUVh?=
 =?utf-8?B?eWxlM29RU3R1YU1tQUwxdVYrK0VtQlZuaUdlNGpmL0VCbWtQZHdhRzJCT3FD?=
 =?utf-8?B?dWp3WlFFZUVqNXdXUlJISHB0ejI5TWN2bjVvWk00elZpN0xuVm44TEkwTXpQ?=
 =?utf-8?B?ZWZpRVkyZ2lzN2JFU3c5enlKT04wL3FLNjdFY3lhcThjVDRSTzhOV0dvc3lF?=
 =?utf-8?B?UXd2dHBEc25QQnI0NjBBelA1Uk9BSDFOUExUR0dJV2JqTjNTdTFBcnFiT1Jn?=
 =?utf-8?B?ZDhyUjJQWk8yNTBOWDB0OVVxcHRyeTE0L096L1ZKNXY3RzRhZU1hM0RYK2xB?=
 =?utf-8?B?V016WVlKN1loTkJyRjJ1NVBLTERobTFZV0dmWjUxSWFvRVBWZE5ZOXlNSXdG?=
 =?utf-8?B?WXptajcrbEtCU0I3Rlp4aXp6aC9SdC8vVEE4SWtvN0U4ckwyemVnQWliK3JQ?=
 =?utf-8?B?b04xRGZ0TklKd3ZsMDRDZ0lSWDllY1p1c0RMcUd0SlNjLzQxVVlQenVsczcr?=
 =?utf-8?B?QWt2VzVucEVOTW5uemNEN3BucWs3VjQ2UVdoSW83NUJwL1E2WDZ1L203SUI2?=
 =?utf-8?B?MnZkZ280eWY0YkNPazduQzR3Ly92dHo2S3hnTC82cXdiMFFaalNDeFh0WElq?=
 =?utf-8?B?QXFrT3dyRGc1MXlZSnl2Ymh5Sk9LQ1BaRWFOTUNJRE0zbDdRaXBqc3BXbC9Z?=
 =?utf-8?B?dTBoWTdpRENQRkJBOUhjb1NWcGM2RW9Eb1F3OTRmaHVrQWJ1SDRrSDN5SHAx?=
 =?utf-8?B?c2FkcENTUUF0OUswVG5pSnpiL3R0bWQ1QmN2Zlhua1hzWC9ONFlHOHJNUm5J?=
 =?utf-8?B?K1VFZXJsaXFleGVieERJSlVlRDNMR0NJSG8zeU5wZWZSRUoxWEJwSk5LbWVQ?=
 =?utf-8?B?dTdDU2tjVUx1YzNJWkp2dVk5Mm9wSHEvb1UyYk12YmZUOHZjcytMNElIS1Vv?=
 =?utf-8?B?a0MxSlRoMWY2Tm1yTFlma3lXeFBmcitia08zUkZwcEhJLzQ1eTRSalZOTkRR?=
 =?utf-8?B?ZzJxcTVpNHNJV0EyVWZzQVFJVXNFbVV0b3VMTUhaRnFiK2VRc2hLVE5UcW40?=
 =?utf-8?B?SHBsdXd4a1JtYTkzTkx0d2FWc1NqenRwRGxJRzlwWUZpalhXSVpaa0ovODRi?=
 =?utf-8?B?V0d2b20vY3pXV0RuRGJHSEVKbmx0NTBUNmNoRTVqekNjNDM3cVAwYmRDYVBB?=
 =?utf-8?B?SHBZTVYzVjZyTFN4NUt5TC9qNTNsYzNvVTNNUjR2WnowQmpEcjJ1bm1PWHpJ?=
 =?utf-8?B?c0w2d3JxcnEzYStuN1kzSE82Q3g4Ym1GLzVaQ2NIUXpNdmlEN1lKQ0lIMWN6?=
 =?utf-8?B?T3FCNllkTUdjc2crSUJxcGkwUU52ZHZ1MzBOVk1pZ3N1MGlTOWhUVkg2blMz?=
 =?utf-8?B?NkhFcVEzeWRNb0puYmhBRmlyUFAvL01abnlXK1Nzbnpmb1RJRU1WUzNQSGti?=
 =?utf-8?B?akhLN0ljMjNSVU95NFo1U3Z2MEZMWUJ2bEQzZzhJYTF4Z1N3QTJNUzVMc2Nz?=
 =?utf-8?B?Z0FlQmtoZzRZM1lDUldoL202eDVEWDhGL3IvclZRWFVmRTBuRUZJR0wxSXBF?=
 =?utf-8?B?T0J5VXUrZzBxWk9Md1pPRHlUUm9zaHdlUjNMLzQ4NnJWZEpkaWNQU3V4aWNx?=
 =?utf-8?B?cEhKMG9lVHE2cEc4SXFYNzREVWJVVzk2c09zRUNRSVNZN0FSNWFvZUdvMFIr?=
 =?utf-8?B?QkNPV0NPQVhqVmxzVndBcUQvNDVuRkhaOVF6ZXNYbzBoenF1KzlDalR4UHhD?=
 =?utf-8?B?ZmttMjFMRDh4UzVSK1U2U3dyc0dWcHJJQUtsUDgveU53WTFJeW1lUmp1dDdR?=
 =?utf-8?B?bkxyeG1nZHI0Z2dLR1NvcWtHY1dWVnVURVlLYWgvTjVveHQ3d083RUJEUk1S?=
 =?utf-8?B?R0F2Rk5CcnIwaE9INGIvQWFXaERRd3VQNVpGQXZ2YUtsRFJPMXkzSHhoYlFS?=
 =?utf-8?B?L1ZsUkNnT2pva1o0OEN2SE94NFdPQjZnSERHZm5PSlhEaDlxZ1k0c29ZSE96?=
 =?utf-8?B?L0MzWWNabDBzdE9OTWl2ZWJINHM5dmNwLzhkRlJyZXYrVmxvZnhGMTM0V25r?=
 =?utf-8?B?M1J1dHJoMEJXNXNwM2tzbngvOCt0c3BuUUxOMGRuaU5uYWlCOGhHeE92U2lB?=
 =?utf-8?Q?KxV+yDNU2SQE6KjoyK5toy9ZS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 414dadd2-9f49-4fb4-d133-08dc793640a5
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 01:35:10.1101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0kJy8j+7pAWbBpp9Ftk4QOjHy1U4qjkLShaYu5goIQGESGdYIDEV8wCoX9v3QY+9VATxll1VrM9mF6IQJTIwSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6069

On 5/20/2024 16:07, Rino Andre Johnsen wrote:
> [Why]
> For debugging and testing purposes.
> 
> [How]
> Create amdgpu_current_pixelencoding debugfs entry.
> Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding
> 
> Signed-off-by: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>
> ---
>   .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 47 +++++++++++++++++++
>   1 file changed, 47 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 27d5c6077630..d275e5522335 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -1160,6 +1160,51 @@ static int amdgpu_current_colorspace_show(struct seq_file *m, void *data)
>   }
>   DEFINE_SHOW_ATTRIBUTE(amdgpu_current_colorspace);
>   
> +/*
> + * Returns the current pixelencoding for the crtc.
> + * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/amdgpu_current_pixelencoding
> + */
> +static int amdgpu_current_pixelencoding_show(struct seq_file *m, void *data)
> +{
> +	struct drm_crtc *crtc = m->private;
> +	struct drm_device *dev = crtc->dev;
> +	struct dm_crtc_state *dm_crtc_state = NULL;

There is no need to initialize dm_crtc_state to NULL.  You set it before 
its first use.

> +	int res = -ENODEV;
> +
> +	mutex_lock(&dev->mode_config.mutex);
> +	drm_modeset_lock(&crtc->mutex, NULL);
> +	if (crtc->state == NULL)
> +		goto unlock;
> +
> +	dm_crtc_state = to_dm_crtc_state(crtc->state);
> +	if (dm_crtc_state->stream == NULL)
> +		goto unlock;
> +
> +	switch (dm_crtc_state->stream->timing.pixel_encoding) {
> +	case PIXEL_ENCODING_RGB:
> +		seq_puts(m, "RGB");
> +		break;
> +	case PIXEL_ENCODING_YCBCR422:
> +		seq_puts(m, "YCBCR422");
> +		break;
> +	case PIXEL_ENCODING_YCBCR444:
> +		seq_puts(m, "YCBCR444");
> +		break;
> +	case PIXEL_ENCODING_YCBCR420:
> +		seq_puts(m, "YCBCR420");
> +		break;
> +	default:
> +		goto unlock;
> +	}
> +	res = 0;
> +
> +unlock:
> +	drm_modeset_unlock(&crtc->mutex);
> +	mutex_unlock(&dev->mode_config.mutex);
> +
> +	return res;
> +}
> +DEFINE_SHOW_ATTRIBUTE(amdgpu_current_pixelencoding);
>   
>   /*
>    * Example usage:
> @@ -3688,6 +3733,8 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
>   			    crtc, &amdgpu_current_bpc_fops);
>   	debugfs_create_file("amdgpu_current_colorspace", 0644, crtc->debugfs_entry,
>   			    crtc, &amdgpu_current_colorspace_fops);
> +	debugfs_create_file("amdgpu_current_pixelencoding", 0644, crtc->debugfs_entry,
> +			    crtc, &amdgpu_current_pixelencoding_fops);
>   }
>   
>   /*