Received-SPF: pass (google.com: domain of linux-kernel+bounces-184281-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
 Jonathan Cameron <jonathan.cameron@huawei.com>,
 Dave Jiang <dave.jiang@intel.com>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, linux-kernel@vger.kernel.org
Subject:
 Re: [PATCH v3] cxl/events: Use a common struct for DRAM and General Media
 events
Date: Tue, 21 May 2024 00:57:10 +0200
Message-ID: <2114228.Jadu78ljVU@fdefranc-mobl3>
In-Reply-To: <4446774.UPlyArG6xL@fdefranc-mobl3>
References:
 <20240518113317.3683718-1-fabio.m.de.francesco@linux.intel.com>
 <4446774.UPlyArG6xL@fdefranc-mobl3>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Monday, May 20, 2024 7:55:17=E2=80=AFPM GMT+2 Fabio M. De Francesco wrot=
e:
> On Saturday, May 18, 2024 1:26:21=E2=80=AFPM GMT+2 Fabio M. De Francesco =
wrote:
> [...]
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a08f050cc1ca..05de8836adea 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -875,7 +875,13 @@ void cxl_event_trace_record(const struct cxl_memdev=
=20
> *cxlmd,
>                 guard(rwsem_read)(&cxl_region_rwsem);
>                 guard(rwsem_read)(&cxl_dpa_rwsem);
> =20
> -               dpa =3D le64_to_cpu(evt->media_hdr.phys_addr) & CXL_DPA_M=
ASK;
> +               if (event_type =3D=3D CXL_CPER_EVENT_GEN_MEDIA)
> +                       dpa =3D le64_to_cpu(evt-
>gen_media.media_hdr.phys_addr)
> +                             & CXL_DPA_MASK;
> +               else if (event_type =3D=3D CXL_CPER_EVENT_GEN_MEDIA)
> +                       dpa =3D le64_to_cpu(evt->dram.media_hdr.phys_addr)
> +                             & CXL_DPA_MASK;
> +
>                 cxlr =3D cxl_dpa_to_region(cxlmd, dpa);
>                 if (cxlr)
>                         hpa =3D cxl_trace_hpa(cxlr, cxlmd, dpa);
> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 6562663a036d..f0a5be131e6a 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -97,7 +97,6 @@ union cxl_event {
>         struct cxl_event_gen_media gen_media;
>         struct cxl_event_dram dram;
>         struct cxl_event_mem_module mem_module;
> -       struct cxl_event_media_hdr media_hdr;
>  } __packed;
> =20
>  /*
>=20

I suspect that I didn't clarify that the diff above is proposing an additio=
nal=20
little change to this patch (for v4) and that I wanted to collect comments=
=20
before applying and respinning.

To be clearer, that diff is meant only to show that cxl_event_media_hdr can=
 be=20
removed from union cxl_event at no cost while still be used for the common=
=20
fields in the definitions of cxl_event_dram and cxl_event_gen_media.

=46abio