Received-SPF: pass (google.com: domain of linux-kernel+bounces-184512-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 21 May 2024 08:02:43 +0200
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann
	<daniel@iogearbox.net>, John Fastabend <john.fastabend@gmail.com>, Andrii
	Nakryiko <andrii@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>, Yonghong
	Song <yonghong.song@linux.dev>, KP Singh <kpsingh@kernel.org>, Stanislav
	Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa
	<jolsa@kernel.org>, <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] bpf: constify member bpf_sysctl_kern::table
Message-ID: <20240521060243.w2g57rrdjvi7biol@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="d6hc32oq7mipiuho"
Content-Disposition: inline
In-Reply-To: <20240518-sysctl-const-handler-bpf-v1-1-f0d7186743c1@weissschuh.net>
CMS-TYPE: 201P
References: <CGME20240518145935eucas1p160af103aca811919cc3f0b47626ed7ec@eucas1p1.samsung.com>
	<20240518-sysctl-const-handler-bpf-v1-1-f0d7186743c1@weissschuh.net>

--d6hc32oq7mipiuho
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 18, 2024 at 04:58:47PM +0200, Thomas Wei=DFschuh wrote:
> The sysctl core is preparing to only expose instances of
> struct ctl_table as "const".
> This will also affect the ctl_table argument of sysctl handlers,
> for which bpf_sysctl_kern::table is also used.
=2E..
> Cc: Joel Granados <j.granados@samsung.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  include/linux/filter.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index 0f12cf01070e..b02aea291b7e 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -1406,7 +1406,7 @@ struct bpf_sock_ops_kern {
> =20
>  struct bpf_sysctl_kern {
>  	struct ctl_table_header *head;
> -	struct ctl_table *table;
> +	const struct ctl_table *table;
>  	void *cur_val;
>  	size_t cur_len;
>  	void *new_val;
>=20
> ---
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> change-id: 20240511-sysctl-const-handler-bpf-bec93a18ac68
>=20
> Best regards,
> --=20
> Thomas Wei=DFschuh <linux@weissschuh.net>
>=20

Reviewed-by: Joel Granados <j.granados@samsung.com>

--=20

Joel Granados

--d6hc32oq7mipiuho
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmZMOQMACgkQupfNUreW
QU92cwv6A3Q54H1yWAu0kZl0kwaEfyuJ8P0cdishMdjgVnPLUhbT+lDcuom2KU0c
zgxj40U08H7GnVNorLYKKhSYqbNTRpJwgZ+59QRSFB/U4EEc+7IWKUhCyZO/ED1K
X5NND5rUJudBey0MsUrUqLfswzurzG4/44lG+wdxfVcYuPt6cBySW5YlA7jC5QZ7
OvB/TJJg2H1zN9tIsmfRdqw+cgkN/ifl7M+195+ivGP2Yn2PnvntG8qGDiaKmx6t
QiMkOUSrOn1p1q/gTVAq9IlN/q5mbAunmmSxK4npyK7pT8THp63/0ZSb5CJvepVF
EvpK/nEr8XHFJ5vN03uvcOOxB/oP1zNxfBAkR9swQ7Roa2M2fpUR/kEuZrXp5fst
2V1X0JBu4oaKBxg7YiJ+h8JMrwimld7BgZscrQRfRhfQdZNQhXrfyIlV2DENp6HX
8d6a4QoeDNyl4WQnhGQdExNnI+37iH2oRDhTPO55Wy8yxJOAW/TrSgeUxBTFPlD/
eQnplWZQ
=QnWQ
-----END PGP SIGNATURE-----

--d6hc32oq7mipiuho--