Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2920750lqo; Tue, 21 May 2024 00:52:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUHN8+SUSEk+WVjrZB0NVD9FkzsrJhgJT0RYPjWxc5TzI+yxSHB6NuiNsRHpkCHGLh81mCkt9PJCh8N9sXOGBZ3JJbk30t2HpEdEcnE2A== X-Google-Smtp-Source: AGHT+IGC0JdDnC66j9dh7Z39mU8Yx9qvFdVE93P86rjl3Pk62zkOLQ8fLzif5cQNcaKmq4uBcc4O X-Received: by 2002:a50:cccf:0:b0:575:2ccb:8138 with SMTP id 4fb4d7f45d1cf-5752ccb8b12mr5463072a12.29.1716277954512; Tue, 21 May 2024 00:52:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716277954; cv=pass; d=google.com; s=arc-20160816; b=DWL2QJSa5if4yWN9Hf50wLKbOUPEW8IMmHzRQO1OeyWYM8LrPp0rwIJ0kCtlWFocx5 nL/3gdeG4uA0JHz6bI62c2q3w7wVF6f5d9O5qDzMepMXruMRJBx2rcCRiRHp9wrwr6b/ zNuWof5dnjTOl6ArZXcz50g8oFVIVhvlbbbXqK6dwjgrZ2+HO7J42ApZ/NpKfhLCrPNi w/X0gvaKYlLkG6qTF0ZEgjCL/PndghVWiiiPqH+54muKv+FnLK0doXEWUsjh+ESk0d3z EYoLZDNpGYcA38xNRh4c7CPHuQFq4pf8yDCDnk/FndPB3hLLoj5QtGJWrSmxyZ6m0uDU Kkmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=Ky+k1jItDFTQozcF5vybAK9Eyw4lX37xXZwEkKCSz/k=; fh=F3XwLurDKHU/TkSDikTyFLMwG+uhCgYz3Z+3RFayLsk=; b=rBF/haqYafDiao+tj7e7EkZQrX1PeNnQ/D/zu1TIyReOdio5/xdMt6d8JW88u75sIx 5evdrLokS/vgGvHOg1EIRNotvsSbdyoOF9NS86KoF0BtwUcUaAqSdE0uFw0c1iZiBOj8 XuXca1fjUfxymuvE2t52vvBtOv6v1i9t3+ZR/BfYTMUmkUTfPAQDoRPbuJI9lpkYij54 0nojwiWjH9UuZDHAWVXxFeHRDMW7ZFzXb2T0BZ6Q1MgJ2PE2Z1UtzZ6gYKSF7TenpfbJ fyZUhmDz3wSY1UEWLSbnzzLKUVDphKkjKBmMpU7Ig4+k/uUyq7mQ/dPc3dCPIYYnK/oj o5Wg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=astralinux.ru); spf=pass (google.com: domain of linux-kernel+bounces-184591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184591-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c2d458fsi13717039a12.342.2024.05.21.00.52.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 00:52:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-184591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=astralinux.ru); spf=pass (google.com: domain of linux-kernel+bounces-184591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-184591-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E97AA1F22C9C for ; Tue, 21 May 2024 07:46:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EAE55337D; Tue, 21 May 2024 07:46:06 +0000 (UTC) Received: from new-mail.astralinux.ru (new-mail.astralinux.ru [51.250.53.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B85717740; Tue, 21 May 2024 07:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.250.53.164 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716277565; cv=none; b=ZT0fTQ/CnAPfx/41LdT72I/QdtpeBystaN08ii1wO3XNfoW5l/J5YHZHUXxyO8L+A0D0EKOnkhg85Z9M8YuJ39B2tJSi3IgeSo/ldGXlaOccM9U8WsiBv84/Xn2l9keAlZN4EzhsS6SVeji7jWsaEh07KjUfKEzpXoMAr/O58Qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716277565; c=relaxed/simple; bh=ReNLlDgpjZ1jaZiHgCEwYSvsQ1fg9dcm9wtlMCL728U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=lhX2nNAswCQzGcohMdA7edf2M3tkAOjAtQyCEgquALohsUfd3RKnGxONyA8HNk/Hmh+qRIq9pJQKVO8z0JazS35MbJBv15gf9e8l0FoGRhxEfgqrpsgLb8jM5lJwEr8tOaX/Er8Lz8bxArzmPQeqIPA5qo5ZItzkjhoQKIGJaAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=astralinux.ru; spf=pass smtp.mailfrom=astralinux.ru; arc=none smtp.client-ip=51.250.53.164 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=astralinux.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=astralinux.ru Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.15.104]) by new-mail.astralinux.ru (Postfix) with ESMTPA id 4Vk5qD5KW8zqSR3; Tue, 21 May 2024 10:36:56 +0300 (MSK) From: Anastasia Belova To: Sylwester Nawrocki Cc: Anastasia Belova , Mauro Carvalho Chehab , Krzysztof Kozlowski , Alim Akhtar , Kyungmin Park , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset Date: Tue, 21 May 2024 10:36:07 +0300 Message-Id: <20240521073607.19426-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DrWeb-SpamScore: -100 X-DrWeb-SpamState: legit X-DrWeb-SpamDetail: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddgtddvucetufdoteggodetrfcurfhrohhfihhlvgemucfftfghgfeunecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetnhgrshhtrghsihgruceuvghlohhvrgcuoegrsggvlhhovhgrsegrshhtrhgrlhhinhhugidrrhhuqeenucggtffrrghtthgvrhhnpeffhfffiefggedvjeduhfdtjefgvdfhteeivdfgleevleeihfejhfefkeethfegheenucfkphepuddtrddujeejrdduhedruddtgeenucfrrghrrghmpehhvghloheprhgsthgrqdhmshhkqdhlthdquddtiedtiedvrdgrshhtrhgrlhhinhhugidrrhhupdhinhgvthepuddtrddujeejrdduhedruddtgeemfeehgeeigedpmhgrihhlfhhrohhmpegrsggvlhhovhgrsegrshhtrhgrlhhinhhugidrrhhupdhnsggprhgtphhtthhopedutddprhgtphhtthhopehsrdhnrgifrhhotghkihesshgrmhhsuhhnghdrtghomhdprhgtphhtthhopegrsggvlhhovhgrsegrshhtrhgrlhhinhhugidrrhhupdhrtghpthhtohepmhgthhgvhhgrsgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihksehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrlhhimhdrrghkhhhtrghrsehsrghmshhunhhgrdgtohhmpdhrtghpthhtohepkhihuhhnghhmihhnrdhprghrkh esshgrmhhsuhhnghdrtghomhdprhgtphhtthhopehlihhnuhigqdhmvgguihgrsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheplhhinhhugidqshgrmhhsuhhnghdqshhotgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-DrWeb-SpamVersion: Vade Retro 01.423.251#02 AS+AV+AP Profile: DRWEB; Bailout: 300 X-AntiVirus: Checked by Dr.Web [MailD: 11.1.19.2307031128, SE: 11.1.12.2210241838, Core engine: 7.00.62.01180, Virus records: 12694235, Updated: 2024-May-21 05:22:48 UTC] flite_hw_reset is called in fimc_lite_resume with spinlock acquired that is forbidden. Replace usleep_range with udelay. Fixes: 2b511edb986f ("[media] s5p-fimc: Add FIMC-LITE register definitions") Signed-off-by: Anastasia Belova --- drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c index 2483277a6cb0..f1e7375c9a5f 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c @@ -30,7 +30,7 @@ void flite_hw_reset(struct fimc_lite *dev) cfg = readl(dev->regs + FLITE_REG_CIGCTRL); if (cfg & FLITE_REG_CIGCTRL_SWRST_RDY) break; - usleep_range(1000, 5000); + udelay(1000); } cfg |= FLITE_REG_CIGCTRL_SWRST; -- 2.30.2