From: Frank Seidel <fseidel@suse.de>
Organization: SuSE Linux Products GmbH
To: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] nozomi: constify driver
Date: Fri, 1 Feb 2008 08:59:14 +0100
User-Agent: KMail/1.9.5
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
       Greg Kroah-Hartman <gregkh@suse.de>, jirislaby@gmail.com,
       linux-kernel@vger.kernel.org
References: <200801312210.30722.fseidel@suse.de> <200802010725.05421.fseidel@suse.de> <20080201072815.GA5345@uranus.ravnborg.org>
In-Reply-To: <20080201072815.GA5345@uranus.ravnborg.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802010859.14583.fseidel@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1661
Lines: 51

On Friday 01 February 2008 08:28, Sam Ravnborg wrote:
> __devinitdata is for non-const data.
> __devinitconst is for const data.
>
> You cannot mix const and non-const data in the same section,
> if you do so gcc will complain.
> It may build for you if all uses of __devinitdata in the
> same source file is either const or non-const but when you
> mix it then it breaks.
> 
> So please use the correct annotation.

Ok, i see .. thanks for this explanation.
I'll repost with this fixed

BTW in this case those drivers also need to be fixed in current
git tree, should they?
drivers/edac/amd76x_edac.c
drivers/edac/e752x_edac.c
drivers/edac/e7xxx_edac.c
drivers/edac/i3000_edac.c
drivers/edac/i5000_edac.c
drivers/edac/i82443bxgx_edac.c
drivers/edac/i82860_edac.c
drivers/edac/i82875p_edac.c
drivers/edac/i82975x_edac.c
drivers/edac/r82600_edac.c
drivers/macintosh/macio_asic.c
drivers/mmc/host/ricoh_mmc.c
drivers/mmc/host/sdhci.c
drivers/net/natsemi.c
drivers/net/via-velocity.c
drivers/scsi/aic94xx/aic94xx_init.c

> We do small incremental steps whenever we can. The challenge is
> often to split up patches and not to combine them.
> 
> Where we combine two patches this is when the second patch fix
> a bug in the first patch.

To me it felt like those changes are so trivial and kind of
belong together so that i thought it would be ok here. But
i'll repost it as two patches in a few moments.

Thanks,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/