Received-SPF: pass (google.com: domain of linux-kernel+bounces-184703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 21 May 2024 11:25:02 +0200
From: Florian Westphal <fw@strlen.de>
To: ye.xingchen@zte.com.cn
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, corbet@lwn.net, dsahern@kernel.org,
	ncardwell@google.com, soheil@google.com, haiyangz@microsoft.com,
	lixiaoyan@google.com, mfreemon@cloudflare.com,
	david.laight@aculab.com, netdev@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	fan.yu9@zte.com.cn, he.peilin@zte.com.cn, xu.xin16@zte.com.cn,
	yang.yang29@zte.com.cn, yang.guang5@zte.com.cn,
	zhang.yunkai@zte.com.cn
Subject: Re: [PATCH net-next v2] icmp: Add icmp_timestamp_ignore_all to
 control ICMP_TIMESTAMP
Message-ID: <20240521092502.GB2980@breakpoint.cc>
References: <20240520165335899feIJEvG6iuT4f7FBU6ctk@zte.com.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240520165335899feIJEvG6iuT4f7FBU6ctk@zte.com.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)

ye.xingchen@zte.com.cn <ye.xingchen@zte.com.cn> wrote:
> From: YeXingchen <ye.xingchen@zte.com.cn>
> 
> The CVE-1999-0524 vulnerability is associated with ICMP
> timestamp messages, which can be exploited to conduct 
> a denial-of-service (DoS) attack. In the Vulnerability
> Priority Rating (VPR) system, this vulnerability was 
> rated as a medium risk in May of this year.
> Link:https://www.tenable.com/plugins/nessus/10113

Please explain at least one scenario where this is a problem.

AFAICS there is none and Linux is not affected by this.

> To protect embedded systems that cannot run firewalls
> from attacks exploiting the CVE-1999-0524 vulnerability,
> the icmp_timestamp_ignore_all sysctl is offered as

If there is an actual problem, then this should be on by default
or the entire feature should be removed.

But I don't think there is a problem in the first place.