Received-SPF: pass (google.com: domain of linux-kernel+bounces-184714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f9e0545d-cf00-447b-a1cf-8251e3fe9ffb@quicinc.com>
Date: Tue, 21 May 2024 15:06:17 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] USB: pci-quirks: Skip usb_early_handoff for Renesas PCI
 USB
Content-Language: en-US
From: AKASH KUMAR <quic_akakum@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Felipe Balbi <balbi@kernel.org>,
        Pratham Pratap
	<quic_ppratap@quicinc.com>,
        Jack Pham <quic_jackp@quicinc.com>, <kernel@quicinc.com>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        "Vijayavardhan
 Vennapusa" <quic_vvreddy@quicinc.com>,
        Krishna Kurapati
	<quic_kriskura@quicinc.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240521074635.17938-1-quic_akakum@quicinc.com>
 <2024052134-roundness-foyer-7bfa@gregkh>
 <1ceae2a4-0715-4cea-9351-fd98a0017b85@quicinc.com>
In-Reply-To: <1ceae2a4-0715-4cea-9351-fd98a0017b85@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Greg,On 5/21/2024 1:35 PM, Greg Kroah-Hartman wrote: > On Tue, May 21, 2024 
at 01:16:35PM +0530, Akash Kumar wrote: >> Skip usb_early_handoff for 
the Renesas PCI USB controller due to >> the firmware not being loaded 
beforehand, which impacts the bootup >> time. >> >> Signed-off-by: Akash 
Kumar <quic_akakum@quicinc.com> > What commit id does this fix? Should 
it go to stable kernels? yes it can go to stable kernels, issue is seen on every target with usb over pcie support. >> --- >> drivers/usb/host/pci-quirks.c | 5 +++++ >> 1 file changed, 5 
insertions(+) >> >> diff --git a/drivers/usb/host/pci-quirks.c 
b/drivers/usb/host/pci-quirks.c >> index 0b949acfa258..a0770ecc0861 
100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ 
b/drivers/usb/host/pci-quirks.c >> @@ -1264,6 +1264,11 @@ static void 
quirk_usb_early_handoff(struct pci_dev *pdev) >> } >> } >> >> + /* Skip 
handoff for Renesas PCI USB controller on QCOM SOC */ >> + if 
((pdev->vendor == PCI_VENDOR_ID_RENESAS) && >> + 
(pcie_find_root_port(pdev)->vendor == PCI_VENDOR_ID_QCOM)) > Why are all 
Renesas PCI devices on a QCOM host to be marked this way? > That's a 
very big hammer for potentially lots of devices. Have you > tested them 
all? firmware loading is being done in HLOS, not UEFI,
if firmware loading is done in UEFI, then calling early_handoff() API makes sense,
else it is checking for controller ready without firmware loaded which is impacting boot up time by 5 sec roughly.
We are seeing problem in all targets having usb over pcie support. > thanks, > > greg k-h Thanks,
Akash