Received-SPF: pass (google.com: domain of linux-kernel+bounces-184892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e3e483ff-d160-4bf2-a1e7-ae541c59f63d@oracle.com>
Date: Tue, 21 May 2024 07:45:05 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] perf jevents: Autogenerate empty-pmu-events.c
To: Ian Rogers <irogers@google.com>, Weilin Wang <weilin.wang@intel.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Sandipan Das
 <sandipan.das@amd.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240520203643.182920-1-irogers@google.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240520203643.182920-1-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Zk5yZjV1ZTdHMjlUL2kvN21xY1VDeVEydU5NOFlHVjhNR0tYcjZza0VoTWdP?=
 =?utf-8?B?eUhTT09XeWwrRzh2TXpxbjNoTEEzUGFqZUNldGdEbThINTVkOTZnVnM5L0N0?=
 =?utf-8?B?SjQzd25CbnA2MHQ2cklaaFZSV1RUSnMrUy9lbnpSZnNicmVDNEJzK3I3N2Zq?=
 =?utf-8?B?WW9lb2VOQitJaU04MEd0bTcvZjdOclJlYzZCN25peEFsT0lGVjlCMGRWWmJB?=
 =?utf-8?B?M1BkcjZXSWxOVG95Qjc3R0FDUnp5QWtGQlVsbmExQzVYN21SaDlsTVBvVldr?=
 =?utf-8?B?ZTZlbEc3OGtJMStjd2lWUTlnTDlnVWVwT045Y2E4K0piUTFrK0tPOVFLeEJr?=
 =?utf-8?B?Ni9xQXBtaVZqOFN6Y1NNMHlBcXRqdU5HaFVFMndjbkxrMlZ3YWRNaVhPTUht?=
 =?utf-8?B?TzlLNGR1WHZEMVVVTTNiQ1JlSFpVQXo4SURiSm00OW53NHVnQnhpRVFrMG1G?=
 =?utf-8?B?d3BpT2dObkU2WmRBNjFRVjVQaFNYeFo3dWUrVlBia1JXR2k5ZnVaNUgyTTQv?=
 =?utf-8?B?OHN3dTRhS1hNSjF1b245eE9OSVFNem11YjhPYWdIb2RKaUlFblpNSkI0MWJs?=
 =?utf-8?B?Wno1d0NvK0ErejF3dW1RU0JsREFqMlVJSDdIK29wWDJzT2Z4aDIwdlJFTXBG?=
 =?utf-8?B?SGt4Ung4a1JYNXQwR0ZyMnhXSDVEMWkyQSsyWjIybXZMWWhwU3ZZdWRBWUpL?=
 =?utf-8?B?VlhRTi80bVJBUlFXcElLb21xdlVIUUVEdmVVbzlMSW1lK01OU0FhZ0pPK2R5?=
 =?utf-8?B?RE1xeWQrek5udjdjR3RuS3hlZXIwcko0OXhvMEJCNEZYa09CQ2E5UnVCLzB4?=
 =?utf-8?B?V2lJRGREWnBWVFAxeHU0L3FkTjdMbWpQYTFjU2hjWEc2WUVXWUp1QXpRcHpx?=
 =?utf-8?B?am9WcWhhdzJCckxMTmh4ZTBOZzFyY29pSm95MnJBaS9ab0d0VWd6Z0JJNGFK?=
 =?utf-8?B?eUwzYklWa2lQUnZDWFNvbmdBYlBEUWhGZGpkQy9VYkd4bGcrWEZ6YXZvTXQ0?=
 =?utf-8?B?SmxXdU1VS01ZTlZxM2tXazJkOEV5UmhpbWxCUG1QbHh3YnFmZVpJSFp3ay9o?=
 =?utf-8?B?VWZua1VnSUVmZHlYekI1UmpoNkVRWmRuZGhPUlRQR1dWWUprWThSQjQvQk1i?=
 =?utf-8?B?dlRWY09KeUFDckhiUFNYbjhnMCs5eGpYdUJJUkM1RmtLb0M0a0ZnOFJCWFJt?=
 =?utf-8?B?a3FXUys5UXFkMWVua3d3dktnemt5VUdSUFlqZEJ6WS9ENXBubG8xSGRIN1Er?=
 =?utf-8?B?cU1hN2luaFp4Z0FZTmtSTm10OG4xQ3hEbjZtOFp0U1ZQaFFmbTllMEZkUzNj?=
 =?utf-8?B?SjdUUnhadE1hTjdyWTJUaFFRQUxKbmJ1ZVZtVGs4emwyd2l4di9BNkRTYzFy?=
 =?utf-8?B?dHpaYmsvWmZIeGthMzZqM2JFcDNBUXlORGlZalE0b0hiOUo1anpEYWFiQWhE?=
 =?utf-8?B?aWpBdGcxbmplY2t5ZEQ4UUlFdG9YYUZndSt0bmJvNEtRRGZxNUo1bzdTamVX?=
 =?utf-8?B?c0hVSmQybkNUYTBMM0hMdjlqa01HYkxYMmIvM051MU0vRXdlTWdWbW1TbTQz?=
 =?utf-8?B?Z3VlU2Q5MDE1dVFHTlZkYklXNHhHNlBGRSs0ejRNMjhMWjF6bWZvMlZrYWxW?=
 =?utf-8?B?VWpkaVAxRXFGVCtMR2tOeGhPQXh6Zk0xMEorazArR0hCdHhSYXVIT0RwN0F5?=
 =?utf-8?B?TGNEYkpQVzdSVjN2ajJ4dmE5T1VYcFVsSkJKeTcwa3VVRFp3am43ZGQydEQy?=
 =?utf-8?B?OGdiZ0tiTUV5SWJyT1dtSXdjNXB2YjBPbk1PTmgyMG95SVVORThjZXZoaXNO?=
 =?utf-8?B?ZitxaFRNdTRMbFhnNG5ZK2wwK24xOWl1TTBHMVlDeWpkU1BJd0FndGFYc0Z5?=
 =?utf-8?B?UThRUVVGMFVNSVhyQUNyMlI2SEYxWnNqTHQ3aUR6dERrVGZhcy9VclJIR0Ex?=
 =?utf-8?B?YlFIdldRSUxhYlZzd2ZqUnlKYnJKOGd6KzI4UWpQWVJ3RXJaRG85bDNoamxK?=
 =?utf-8?B?RGlJalBQV1pncTZOQWpQakszTEZCSU1Hcm9LTUlYc0dHdER3WVk2Z2VPRzJI?=
 =?utf-8?B?V094aks3aEhJdjJnUXp4RUFQdGxMSncvdnoxdmRIeW1Lek1nRDFHU05VbGhl?=
 =?utf-8?B?VkhyeHhUMk0rZ2ZIYVg3N1Z3dXYzRXluNm9CdWxKZUs4RlVpSFJQUWpNRWFZ?=
 =?utf-8?B?TkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZUc1A82T5A7oPrnCa+NeadTAjZby/yYx4UWaswSyauortBPWfZCmbX0wD3P28yuNxNb0S9NIjF/mhdt+nouYosv62dqLiZRFDaqWPBPyjAJcqHCpJCPvgu1pEfAynKnrFHlndEtgfn921nerz3qjPBwgJSROSTbe5qVt8km10d8OPXxM0uBi0NrNFGiNMl17FdxxZijmxuqKwNro1uGBQZAxK6qjlvWkGhsGKRt8oAslbKVhX6W0PVWk/hKgSobc8gsClKoGfPZPAe/YrUVqshHXgJieKxz7K7bHjA5DwYJY4Nk65ZhFQSTcnBxR2zbZrpeiRJ1na8PUv74QFLsGZEfgj0WHcRtqsZRsPVOdTiR7QYReiK81p4EVAxOBe66pUujpEZEbmoxJnYAe2UjQW8cFjfwWclwbXyh/sBz7/OK3UIaQpErROv/6mpOZdGk5XpHOspT46gPqy2/a4vCsFuwNtMnvoaOgVwR4L09HYpLumUCBs3bZSOZfU9XEdFv98LHThW/fQqM/8oQ494zg4OmSNrLCfbGBzOIeE5u2w5tBo3YlACCWrU3XKK5ovPZMZIAvHHYgDoavMZo5OUa/bjGh3TPwb/CNT0LuAPmMrRc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ae71813-4338-4f6e-240d-08dc798b76ce
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 11:45:08.1985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P5RT8gTScHAJMzN+OaJskSk/69aa98gT4t7/uwTrCXM4GxDEF7FdccLv2OrW5wDmu79oxXJ3/pgRPyUtvjG+7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4437
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-21_07,2024-05-21_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405210088
X-Proofpoint-ORIG-GUID: BJdGZN3O9wH2LmZJ4MtDok4Tz57dIM1N
X-Proofpoint-GUID: BJdGZN3O9wH2LmZJ4MtDok4Tz57dIM1N

On 20/05/2024 16:36, Ian Rogers wrote:
> 	}
> +                ret = pmu_events_table__find_event_pmu(table, table_pmu, name, fn, data);
> +                if (ret != -1000)
> +                        return ret;
> +        }
>           return -1000;

what's -1000 meaning? It would be nice to use some standard error codes.

Thanks,
John