Received-SPF: pass (google.com: domain of linux-kernel+bounces-184751-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 21 May 2024 13:06:11 +0300 (EEST)
To: Markus Elfring <Markus.Elfring@web.de>
cc: Hans de Goede <hdegoede@redhat.com>, 
    Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>, 
    platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org, 
    Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, 
    Zhang Rui <rui.zhang@intel.com>, LKML <linux-kernel@vger.kernel.org>, 
    Dan Carpenter <dan.carpenter@linaro.org>, 
    Dan Carpenter <error27@gmail.com>
Subject: Re: [v2] platform/x86: ISST: fix use-after-free in
 tpmi_sst_dev_remove()
In-Reply-To: <51368bcf-d2e3-42cc-a112-a1a485f29c73@web.de>
Message-ID: <a8eb3ba6-eeab-6c0c-7b57-4fde508853ed@linux.intel.com>
References: <20240517144946.289615-1-harshit.m.mogalapalli@oracle.com> <d5203ff5-8ed4-48ea-8e58-a2e6680b0542@web.de> <6d1bf351-77cc-7fe9-2d62-8bd99789e4f1@linux.intel.com> <d73fe99b-dea3-4792-aa1c-c3317f296003@web.de> <5287fc2e-91c5-442b-b66c-6eb1fe334ce4@redhat.com>
 <51368bcf-d2e3-42cc-a112-a1a485f29c73@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-2126140094-1716285753=:1027"
Content-ID: <73fe5b09-d14a-6e05-f359-409948eb0554@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-2126140094-1716285753=:1027
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <665ca344-ac2c-979a-bbcb-5839511e72c4@linux.intel.com>

On Tue, 21 May 2024, Markus Elfring wrote:

> >>>> =E2=80=A6
> >>>>> Fix this by reordering the kfree() post the dereference.
> =E2=80=A6
> > The original wording of the commit message really is fine as is,
> > I see no need for Harshit to send a new version and I plan to
> > merge this as is.
>=20
> Are there opportunities remaining to improve the discussed wording?
>=20
> 1. https://en.wiktionary.org/wiki/post#Etymology_1
>=20
> 2. https://en.wiktionary.org/wiki/reorder
>=20
> 3. Function call indication?
>    https://elixir.bootlin.com/linux/v6.9.1/source/mm/slub.c#L4371
>=20
> 4. Rephrasing of =E2=80=9CFix this by =E2=80=A6=E2=80=9D?
>=20
> 5. https://en.wikipedia.org/wiki/Dangling_pointer#Cause_of_dangling_point=
ers
>=20
> 6. https://wiki.sei.cmu.edu/confluence/display/c/MEM30-C.+Do+not+access+f=
reed+memory#MEM30C.Donotaccessfreedmemory-AutomatedDetection
>=20
> 7. https://en.wikipedia.org/wiki/Code_sanitizer#KernelAddressSanitizer

We'll not waste our time in wordsmithing commit messages to perfection,=20
the current one is good enough as was stated to you already.

--=20
 i.
--8323328-2126140094-1716285753=:1027--