Received-SPF: pass (google.com: domain of linux-kernel+bounces-184965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ab1939d8-1913-4b26-a2a2-3b49efb62e97@arm.com>
Date: Tue, 21 May 2024 18:22:20 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/mm: va_high_addr_switch: Do not skip test and
 give warning message post FEAT_LPA2
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com,
 kirill.shutemov@linux.intel.com, AneeshKumar.KizhakeVeetil@arm.com
References: <20240516035633.143793-1-dev.jain@arm.com>
 <20240519164823.8e21acfd2bf9ad13f7798f1a@linux-foundation.org>
Content-Language: en-US
From: Dev Jain <dev.jain@arm.com>
In-Reply-To: <20240519164823.8e21acfd2bf9ad13f7798f1a@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 5/20/24 05:18, Andrew Morton wrote:
> On Thu, 16 May 2024 09:26:33 +0530 Dev Jain <dev.jain@arm.com> wrote:
>
>> Post FEAT_LPA2, Aarch64 extends the 4KB and 16KB translation granule to
>> large virtual addresses. Currently, the test is being skipped for said
>> granule sizes, because the page sizes have been statically defined; to
>> work around that would mean breaking the nice array of structs used for
>> adding testcases.
> Which array is that?  testcases[]?  If so, we could keep if fairly nice
> by doing the array population at runtime.  Something like:
>
> static struct testcase *testcases;
>
> static void init_thing()
> {
> 	struct testcase t[] = {
> 		...
> 	};
>
> 	testcases = malloc(sizeof(t));
> 	memcpy(testcases, t, sizeof(t));
> }


Great idea! This should work. I shall implement it.