Received-SPF: pass (google.com: domain of linux-kernel+bounces-185023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <c4b73d50-2896-4bcc-ae61-6d72f9471978@oracle.com>
Date: Tue, 21 May 2024 09:38:29 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V3 1/3] vhost-vdpa: flush workers on suspend
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Si-Wei Liu <si-wei.liu@oracle.com>,
        Eugenio Perez Martin <eperezma@redhat.com>,
        Xie Yongji <xieyongji@bytedance.com>,
        Stefano Garzarella <sgarzare@redhat.com>
References: <1716218462-84587-1-git-send-email-steven.sistare@oracle.com>
 <1716218462-84587-2-git-send-email-steven.sistare@oracle.com>
 <CACGkMEvhs_-wD4p-i2VCmQnmdNPLsH9FkhkGePB5LxZQf4B30A@mail.gmail.com>
Content-Language: en-US
From: Steven Sistare <steven.sistare@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CACGkMEvhs_-wD4p-i2VCmQnmdNPLsH9FkhkGePB5LxZQf4B30A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aE43bzNPVkxRdnVoT1BBb09GV1A1a1JEWW5FODA2dFg5Q2JPQTRvbkNCL2Vy?=
 =?utf-8?B?a0IzbE5iMDFoL0FaUjhUWDV0cSttK2pYUXdXRVRDZVQraVNiYjhOYWdqd21v?=
 =?utf-8?B?eC9lWC9TVnZFRHp4SVNIQXpaSWZJT2VzNnc1N2F2Z1RFcjk0L2ZBS2ZkQlY5?=
 =?utf-8?B?Rzl3M2dJUVB1anpjVWpKekxWdWdkM0x6Vzlycit3T1pQVnVDMkY4SVcxN1k3?=
 =?utf-8?B?aW81N2V3QzA0bVV4eXdWeU55ejJYc1E1MTdkQ0x0ZytzYStCejR2d2FQelcv?=
 =?utf-8?B?cVpQUVFXNWMrT3pVbzB3Sm1nb3FyVVplZGN1WUtmNVBzVU54Q3k3RHppMjRV?=
 =?utf-8?B?Y28weG4yR2w3bFU1K2JaMTAxM1hONFRxK0ZMWGg2R0p3YXFWbTZRSkI1UzZl?=
 =?utf-8?B?RGorSTBsY2E4QWR0anh1cDZoemNEY1hic3d4NTRSb2hNZmplSE1tUkpqa0tP?=
 =?utf-8?B?Zks5TXZCalZFUEZET1kyU2g4VHVBTGQxdFEyVTAweERzK3NPVUo4M3FWMUt5?=
 =?utf-8?B?SklJNkN0QUZVOW00UHRpdUVTUFpHaVVDTitnRjh1R0g2djRzbzFmSmNSRjVr?=
 =?utf-8?B?RWlmcUhUdUdCUHMvUWozUVlyeUJnd3BGMXU0bTQ5N3E2MkhYeEh3RG8xVlZx?=
 =?utf-8?B?UGpYMXlyZ05oZnc0Y3NTb212SEZFR2pNV1gxVE5odkQrUE9FUjJiakZsbE5w?=
 =?utf-8?B?WUR1Z0N6M0VUc0dCR0pCR2Rka2NVSFYrNzRxSkxoUUZiWkFWL2J1QVVoUGpP?=
 =?utf-8?B?WXdXazhEUUk4L2NVSUhDVWgzdSswSWU3a0gvbzcwanptM0dVMU5YdENNY3lw?=
 =?utf-8?B?NUNIemcrSExsb0hIZFBSZ0lSVUovc0VmYk51UFBaRnlxMk5rMnV0RVg4ZzBQ?=
 =?utf-8?B?Z2FsWU04RW11TXkzMjlvdDdJeldKYVV0MkU1QmVXcHVhQ1NMT0JVMk13c0Fr?=
 =?utf-8?B?S3NJbGxxZHV1QlpFTEh1TFRWL1RWYUhtWGVSb1J3Q1A5b3NxOVpZTnZBZmhW?=
 =?utf-8?B?ZXB5TW9heHExbmRvNDdhMzVjdkFLRlNKMGVmWVI3L2sxZm40ZndkMWx4NHI2?=
 =?utf-8?B?QnV0cC9TYnkxbGxqN2RXelQwUHRJR1RhM2owZU5zaFdIWFhiejN0Y1ZDNzBR?=
 =?utf-8?B?bFQwVHloZkwxajlOUkxOM3plRk5wUDN2Y1BmZkNuTlhQYkdPeWttMlpJb2x1?=
 =?utf-8?B?bHBzUkY5VXFuSzlUL2dtclpuYUx6RHZEOWI1dHlXLzlZY1dsNG9vbTJjNlJS?=
 =?utf-8?B?dHZzNHFyL1NXcE5La2Nick5tY3I5S25FYklyL2xMUGU3Rk5tRWhjTi9idGFG?=
 =?utf-8?B?Vk5zcWRLZUo5Z0JnUVNGZnhNZTZQRk5QdmxJSlh3Mjh3N3loSEdPRThic2VD?=
 =?utf-8?B?ZzBXbENSZ3hVRjZuSE5tNmhtUi9ETUtKQjZ5aWN3Vi9HZ20xS3E3RUx1bllr?=
 =?utf-8?B?OG1oN3RseVFEc09zZ3dZaE1GcWxWVmZvTS82b01uRDhmU1pFN0VrWHJtQS8x?=
 =?utf-8?B?eVdiaFhNN0ZDK3ZqZ1psVXBLb1hTOVRaNjRUMHJhUUJyZERpZUphdFJ1RnIr?=
 =?utf-8?B?SlNKWERMOUpKTy9VZUZPbElncGdvMHZmTWxMMDNUejk5K0ZCcUlxdGdCeG51?=
 =?utf-8?B?Y2lRSnBJZUxYTXJ5REozVy91VUtub29LdVEzU2xlVjZvSEk1WmlFR0luNWlI?=
 =?utf-8?B?L0UrcmpjVWtHdWRybW8yZzFPT1dFUGN6eC9wZmNLakVZcHFURnJSUUxNWVpN?=
 =?utf-8?B?YTNWUG9IU1BxZVg4OHdPb29mbHdYY3lTd1I1VHBjdTFKR3VsK0IwVEJGUlNs?=
 =?utf-8?B?dFErbCtITU1lT1kxUXFyVGlNdXUyNXF0QlFURktnd2NBa2FkY1NnTkhtcTVC?=
 =?utf-8?B?aXZURGxCUTd1QTBMVkIyc2VWTU9tcU1rVDJnZGRYcVRKZ1BsSDFpVy91M2NW?=
 =?utf-8?B?ck9lamRML05JNTNBdkpHSnNJeU5Taml6U201L1RaVWtkSWxZQ1h1a2ExSTlV?=
 =?utf-8?B?Znl1QWhGN0ZqbFVNUWNUK0daK29HU2FGMUZiME1jcW83UFNGeUhvRUsycm9i?=
 =?utf-8?B?UFZ6aEJSSVRlZEltS2pKMlR0b3g1R2l4cDgwV0gyb0p6ZDNWTy9wVlFObUpM?=
 =?utf-8?B?b3Q4cDNnRm5zZ3R3TGlHNFExRUdtNWJZQzdIOWhHTGxzS1ZqMms5Wm5weXJr?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	R5QW9ZJ3umUHWGYZQ26CXHduO7ly3PW+towmF77TahLLwXG9qfAs44B6eGaA3b9/7mDlIA0lfPEM05OidfmFoOcWY9qcVHPhHdmRTGyEhSoq4PW58KFTzn4ffmubmgz6wQgOv8JVOlCWpIAEFlPB3DXDf3BVQ5/BuREmymjpUjcGR4lO0rmz7v1PgKNJLEsnaK6Md+mBc58q155wyy4GWxTPM76y/tLWdSJDUfJ5jP9wR8Z1TJuAkSmMHkYPG63T+R2CFYb7J8oUoZl8TbDAwEhoylHeUch4MnIMX4GwDxLFwSHsQ4Opq1QeTTE7hSEz0j23lsZZmaXkabnMdswpirghlSkgId067V0hKnC+NQJnty/Mmgqdd2kF5U1bPMxb6xcxBwUebkSdVVZu+hPkwYknW1UEnphATs9pAjqe9X3Alf0t6u979lypP10IpUvtG9xKCbOt3XSkB3+P4vcQ1iuxvsYcHR724aH6Vek68SRr/eb25IJPswpmFrnFSlQ6xTolZYeEpuvCPRUftg/FktctbHDxvDruQmOMVlN2riaRSBhxLNHkbKQ3W9CuCKXsj0DulXai/ZoaDtQMELl0DvBgjAKvJZci8NwzVkWpipE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 446ccf5d-89a2-4dd6-6c59-08dc799b50b2
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4684.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 13:38:36.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sDiXU02hM+62LOfE+c/soG3R6OowYiOTx3N1MA3m0UceVSlCFjU793E0JOWLSm9SThi5uOxQ4CMb15duOqpevn/+epGdAZm2ZLiioswqW78=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6527
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-21_08,2024-05-21_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405210103
X-Proofpoint-ORIG-GUID: unqyrUCrkVxFPd243rTJbskGc35c3xHM
X-Proofpoint-GUID: unqyrUCrkVxFPd243rTJbskGc35c3xHM

On 5/20/2024 10:28 PM, Jason Wang wrote:
> On Mon, May 20, 2024 at 11:21 PM Steve Sistare
> <steven.sistare@oracle.com> wrote:
>>
>> Flush to guarantee no workers are running when suspend returns.
>>
>> Fixes: f345a0143b4d ("vhost-vdpa: uAPI to suspend the device")
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> Acked-by: Eugenio Pérez <eperezma@redhat.com>
>> ---
>>   drivers/vhost/vdpa.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index ba52d128aeb7..189596caaec9 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -594,6 +594,7 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>>          struct vdpa_device *vdpa = v->vdpa;
>>          const struct vdpa_config_ops *ops = vdpa->config;
>>          int ret;
>> +       struct vhost_dev *vdev = &v->vdev;
>>
>>          if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>>                  return 0;
>> @@ -601,6 +602,8 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>>          if (!ops->suspend)
>>                  return -EOPNOTSUPP;
>>
>> +       vhost_dev_flush(vdev);
> 
> vhost-vDPA doesn't use workers, see:
> 
>          vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
>                         vhost_vdpa_process_iotlb_msg);
> 
> So I wonder if this is a must.

True, but I am adding this to be future proof.  I could instead log a warning
or an error message if vhost_vdpa_suspend is called and v->vdev.use_worker=true,
but IMO we should just fix it, given that the fix is trivial.

- Steve