Received-SPF: pass (google.com: domain of linux-kernel+bounces-185067-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 21 May 2024 17:12:06 +0300
From: Andy Shevchenko <andy@kernel.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Uros Bizjak <ubizjak@gmail.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Arnd Bergmann <arnd@arndb.de>, Mateusz Guzik <mjguzik@gmail.com>,
	Thomas Renninger <trenn@suse.de>, Andi Kleen <ak@linux.intel.com>,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v6 16/49] x86/platform/intel-mid: Switch to new Intel CPU
 model defines
Message-ID: <Zkyrtgj7yQR8H-Bz@smile.fi.intel.com>
References: <20240520224620.9480-1-tony.luck@intel.com>
 <20240520224620.9480-17-tony.luck@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240520224620.9480-17-tony.luck@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, May 20, 2024 at 03:45:47PM -0700, Tony Luck wrote:
> New CPU #defines encode vendor and family as well as model.

..

> -	switch (boot_cpu_data.x86_model) {
> -	case 0x3C:
> -	case 0x4A:
> +	switch (boot_cpu_data.x86_vfm) {
> +	case INTEL_HASWELL:

Thanks, God^W your series, I just realised that this is quite a mistake.
I mean, you need to remove this line (with HASWELL) from this file.

  Fixes: bc20aa48bbb3 ("x86, intel-mid: Add Merrifield platform support")

HASWELL was never a part of Intel MID initiative (in a sense how it's
organised in HW and FW).

> +	case INTEL_ATOM_SILVERMONT_MID:
>  		x86_platform.legacy.rtc = 1;
>  		break;

So, TL;DR: Please add the patch, I will give a tag to it immediately.

-- 
With Best Regards,
Andy Shevchenko