Received-SPF: pass (google.com: domain of linux-kernel+bounces-185070-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <854fa2e1634eb116b979dab499243e40917c637c.camel@HansenPartnership.com>
Subject: Re: [PATCH] tpm: enable HMAC encryption for only x86-64 and aarch64
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-integrity@vger.kernel.org
Cc: keyrings@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>, Jason
 Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>, David Howells
 <dhowells@redhat.com>, Paul Moore <paul@paul-moore.com>, James Morris
 <jmorris@namei.org>, "Serge E. Hallyn" <serge@hallyn.com>, 
 linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Date: Tue, 21 May 2024 10:13:45 -0400
In-Reply-To: <D1FDMULT5YRK.GZOPJ9FZ325R@kernel.org>
References: <20240521130921.15028-1-jarkko@kernel.org>
	 <236606947b691049c650bdf82c37324084662147.camel@HansenPartnership.com>
	 <D1FDMULT5YRK.GZOPJ9FZ325R@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2024-05-21 at 17:02 +0300, Jarkko Sakkinen wrote:
> Secondly, it also roots to the null key if a parent is not given. So
> it covers all the basic features of the HMAC patch set.

I don't think that can work.  The key file would be wrapped to the
parent and the null seed (and hence the wrapping) changes with every
reboot.  If you want a permanent key, it has to be in one of the
accessible permanent hierarchies (storage ideally or endorsement).

The spec has a mechanism for deriving the key from a permanent handle
if the system doesn't have it in-place.  I do have patches to use that
because that's the way most sealed objects and keys are generated
today.  I'll post them (although there'll be a bit of fixing up to do).

Regards,

James