Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3129725lqo; Tue, 21 May 2024 07:42:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/MrMeJ2rGlw7SHSXaq75YztwZxx7HGd/7JWCEEchNO4jPDYY4YkbVkBUnAd9I47478oNfri2b32/T6ejUVu9F2gAMHxFc15VQyBJa3w== X-Google-Smtp-Source: AGHT+IGyMIJGufKlBAHB67lv2EyJHesQW/WoHWwia4iorPxgr8g3ZRZfHFwDvF3W5r9yWHFaKeYU X-Received: by 2002:a05:6512:3e0e:b0:522:2edc:c858 with SMTP id 2adb3069b0e04-5224b73a706mr20829141e87.34.1716302565882; Tue, 21 May 2024 07:42:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716302565; cv=pass; d=google.com; s=arc-20160816; b=uegywzHx67x650P3FIzG/a/f8gwVLWX+j9R74XDK8o9mYl7By0aiCDfwdHeGJmR18g 2qUM/Rd/+0ec0YT1GMmZ95zuAim1z5iuKYIzEVVY4MC0RPqZPsO7bHj/mYZem50/gQ0n Yf3b5u0axplfERuv2MWHoY7mv1+xdS+YmTOSdO8YFFoVtP1jBIRyci3Qs2tWQeOmrT6x rzdrv6TaEwlbueF4XcShz9mH1DZoqMs3L1O6JvCOYlcF4Je/b22ppKPZoVJPUlNBhCD4 pWTyw6U2q5ubdTLblNbB5o1UdUDL8mrAQ9x4CgpaTkYFKxlfDRDA4+fL8jnT2u/n8bjW mKoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1fAF320AzDvCN142776Nqrdp4/SJvaHmma0TtiGBQhM=; fh=dBg9xwISWwxZrJmwe4MDx57thaYsOEA4kPCR19c0su8=; b=WmdyG8O5QQiszEcRgcUsLjMK6jkJxja49ezsh5uuFEHqdx/b6b99p4/10gBqbISjb+ zZ7b59O6SXwecJk5llD7myEJjeuQ9Kvk4jZHrqfGOZ2JVnBlUWffqci/kRr9ndHq5SNJ aJSmndHrk3LnnBOYRa7T7o+0B4eFPYDnUapKsBHJyAiBDl7S2vNnC3Uf9TdGVj0sMxBk VqMoFWP8qqWwfvEKpIfEV6Q1tyT2DGYgjzPLbsnXE8KZkz0ex8AVbpD0nshxjRLnDKbB 79tUuzl8Uk2rhWPm3fUs8YqUGijV8qlPnHCT0uGqcdMUfJ8sX73pXxj0Fj+X2pBN5KZU HOtg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="us7cW/DE"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-185107-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185107-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a61cb8b7775si199352666b.936.2024.05.21.07.42.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 07:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185107-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="us7cW/DE"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-185107-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185107-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 845D11F237E6 for ; Tue, 21 May 2024 14:42:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 88DF4142E86; Tue, 21 May 2024 14:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="us7cW/DE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAECF142E7C; Tue, 21 May 2024 14:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716302534; cv=none; b=UzqDyV7Si9eovAJyio17jKEip+5WrilC2htDZRYg4PW6Q9ZKVonXgJkW+QPUUNHAL4MZel0aNVxya0x26uPtTviGp01NeYmKJSRfqmcceL38i9sXTbirzCij4F0S3zdKxfni9x1rm/BTrYwP87TFApCxjVgqjmQ3T5WQTd1sTxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716302534; c=relaxed/simple; bh=jqRppYoUU1XIgdcBdLNzyzVT8stpiXxdprmvRRM5LZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jPpxYvAy4JF0ElCAXv4tc0qpwj9E03k+9ddAc9CwZkc1yrRMZaJO0+FyDq7mU6rin89LNLX8DnfyX8dGt48JECcpQwyW60E3NHcZxno2IekeIY3LJCiwe2cmsKZAsU0kujvJCF0LFX0x/+NR/55gjqmTgr0BDtiqukgbR6tJ+38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=us7cW/DE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3179DC2BD11; Tue, 21 May 2024 14:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716302534; bh=jqRppYoUU1XIgdcBdLNzyzVT8stpiXxdprmvRRM5LZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=us7cW/DEmuWVdpTzxhboLIpHoTLmnHWi1ny+P0km6OlkICC7Tx4fOfqZlbR6y2CHO BTkRH4eIe8vOhLGg4uYS7LaEFT/JzUDCpNnMqFFzyDtdLvVac8zD69BkAPs6z+F/Eq qcEsnolDIvZvZ2yeTMuiug9kr/K8hzO9IS9fGI04= Date: Tue, 21 May 2024 16:40:24 +0200 From: Greg Kroah-Hartman To: Michal Hocko Cc: cve@kernel.org, linux-kernel@vger.kernel.org, Jason Xing , linux-cve-announce@vger.kernel.org Subject: Re: CVE-2024-27429: netrom: Fix a data-race around sysctl_netrom_obsolescence_count_initialiser Message-ID: <2024052105-pulsate-reborn-119a@gregkh> References: <2024051722-CVE-2024-27429-878c@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 21, 2024 at 10:39:04AM +0200, Michal Hocko wrote: > This and couple of others are all having the same pattern. Adding > READ_ONCE for an integer value with a claim that this might race with > sysctl updates. While the claim about the race is correct I fail to see > how this could have any security consequences. Even if a partial write > was observed which sounds _more_ than theoretical these all are merely > timeouts and delays. > > Is there anything I am missing? Nope, you are right, our fault, I'll go revoke this now. Thanks for the review, it's much appreciated! greg k-h