Received-SPF: pass (google.com: domain of linux-kernel+bounces-185112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240516174357.26755-1-jim.cromie@gmail.com> <20240516174357.26755-6-jim.cromie@gmail.com>
 <CALwA+NahLwNXapUogMGvBX1LavVKMoipLwN7v1DdjtJzayEkNQ@mail.gmail.com>
In-Reply-To: <CALwA+NahLwNXapUogMGvBX1LavVKMoipLwN7v1DdjtJzayEkNQ@mail.gmail.com>
From: jim.cromie@gmail.com
Date: Tue, 21 May 2024 08:44:25 -0600
Message-ID: <CAJfuBxxZATOwNW3TM35YixTaTQQ5BGvcQHu3nemPWvAX8XYbLw@mail.gmail.com>
Subject: Re: [PATCH v8-RESEND 05/33] dyndbg: replace classmap list with a vector
To: =?UTF-8?Q?=C5=81ukasz_Bartosik?= <ukaszb@chromium.org>
Cc: jbaron@akamai.com, gregkh@linuxfoundation.org, 
	linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, joe@perches.com, 
	mcgrof@kernel.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, 
	jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, 
	robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 5:45=E2=80=AFAM =C5=81ukasz Bartosik <ukaszb@chromi=
um.org> wrote:
>
> On Thu, May 16, 2024 at 7:44=E2=80=AFPM Jim Cromie <jim.cromie@gmail.com>=
 wrote:
> >
> > Classmaps are stored in an elf section/array, but are individually
> > list-linked onto dyndbg's per-module ddebug_table for operation.
> >
> > This is unnecessary; even when ddebug_attach_classmap() is handling
> > the builtin section (with classmaps for multiple builtin modules), its
> > contents are ordered, so a module's possibly multiple classmaps will
> > be consecutive in the section, and could be treated as a vector/block,
> > since both start-addy and subrange length are in the ddebug_info arg.
>
> Should it be start-addr instead of start-addy ?
>

yes, we dont need spurious new terms.  will fix.

> >
> > IOW, this treats classmaps similarly to _ddebugs, which are already
> > kept as vector-refs (address+len).