Received-SPF: pass (google.com: domain of linux-kernel+bounces-185137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <466e5359-067c-4ab5-9476-06daa44dc83d@linuxfoundation.org>
Date: Tue, 21 May 2024 09:11:08 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] tools/latency-collector: fix -Wformat-security compile
 warns
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240404011009.32945-1-skhan@linuxfoundation.org>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20240404011009.32945-1-skhan@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/3/24 19:10, Shuah Khan wrote:
> Fix the following -Wformat-security compile warnings adding missing
> format arguments:
> 
> latency-collector.c: In function ‘show_available’:
> latency-collector.c:938:17: warning: format not a string literal and
> no format arguments [-Wformat-security]
>    938 |                 warnx(no_tracer_msg);
>        |                 ^~~~~
> 
> latency-collector.c:943:17: warning: format not a string literal and
> no format arguments [-Wformat-security]
>    943 |                 warnx(no_latency_tr_msg);
>        |                 ^~~~~
> 
> latency-collector.c: In function ‘find_default_tracer’:
> latency-collector.c:986:25: warning: format not a string literal and
> no format arguments [-Wformat-security]
>    986 |                         errx(EXIT_FAILURE, no_tracer_msg);
>        |
>                           ^~~~
> latency-collector.c: In function ‘scan_arguments’:
> latency-collector.c:1881:33: warning: format not a string literal and
> no format arguments [-Wformat-security]
>   1881 |                                 errx(EXIT_FAILURE, no_tracer_msg);
>        |                                 ^~~~
> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>   tools/tracing/latency/latency-collector.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
> index 0fd9c747d396..cf263fe9deaf 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -935,12 +935,12 @@ static void show_available(void)
>   	}
>   
>   	if (!tracers) {
> -		warnx(no_tracer_msg);
> +		warnx("%s", no_tracer_msg);
>   		return;
>   	}
>   
>   	if (!found) {
> -		warnx(no_latency_tr_msg);
> +		warnx("%s", no_latency_tr_msg);
>   		tracefs_list_free(tracers);
>   		return;
>   	}
> @@ -983,7 +983,7 @@ static const char *find_default_tracer(void)
>   	for (i = 0; relevant_tracers[i]; i++) {
>   		valid = tracer_valid(relevant_tracers[i], &notracer);
>   		if (notracer)
> -			errx(EXIT_FAILURE, no_tracer_msg);
> +			errx(EXIT_FAILURE, "%s", no_tracer_msg);
>   		if (valid)
>   			return relevant_tracers[i];
>   	}
> @@ -1878,7 +1878,7 @@ static void scan_arguments(int argc, char *argv[])
>   			}
>   			valid = tracer_valid(current_tracer, &notracer);
>   			if (notracer)
> -				errx(EXIT_FAILURE, no_tracer_msg);
> +				errx(EXIT_FAILURE, "%s", no_tracer_msg);
>   			if (!valid)
>   				errx(EXIT_FAILURE,
>   "The tracer %s is not supported by your kernel!\n", current_tracer);

Any thoughts on this patch?

thanks,
-- Shuah