Received-SPF: pass (google.com: domain of linux-kernel+bounces-185168-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <58ddfc8f-1995-4f41-9d63-35a00c6f92b9@gmail.com>
Date: Tue, 21 May 2024 17:36:43 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi
To: keith <keith.zhao@starfivetech.com>, andrzej.hajda@intel.com,
 neil.armstrong@linaro.org, rfoss@kernel.org,
 Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
 jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
 mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
 robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
 hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
 xingyu.wu@starfivetech.com, p.zabel@pengutronix.de,
 jack.zhu@starfivetech.com, shengyang.chen@starfivetech.com
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20240521105817.3301-1-keith.zhao@starfivetech.com>
 <20240521105817.3301-3-keith.zhao@starfivetech.com>
Content-Language: en-US
From: Alex Bee <knaerzche@gmail.com>
In-Reply-To: <20240521105817.3301-3-keith.zhao@starfivetech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Keith,

thanks a lot for working on this. See some general remarks below
Am 21.05.24 um 12:58 schrieb keith:
> Add INNO common api so that it can be used by vendor
> drivers which implement vendor specific extensions to Innosilicon HDMI.
> 
> Signed-off-by: keith <keith.zhao@starfivetech.com>
> ---
>   MAINTAINERS                                   |   2 +
>   drivers/gpu/drm/bridge/Kconfig                |   2 +
>   drivers/gpu/drm/bridge/Makefile               |   1 +
>   drivers/gpu/drm/bridge/innosilicon/Kconfig    |   6 +
>   drivers/gpu/drm/bridge/innosilicon/Makefile   |   2 +
>   .../gpu/drm/bridge/innosilicon/inno-hdmi.c    | 587 ++++++++++++++++++
>   .../gpu/drm/bridge/innosilicon/inno-hdmi.h    |  97 +++
>   include/drm/bridge/inno_hdmi.h                |  69 ++
>   8 files changed, 766 insertions(+)
>   create mode 100644 drivers/gpu/drm/bridge/innosilicon/Kconfig
>   create mode 100644 drivers/gpu/drm/bridge/innosilicon/Makefile
>   create mode 100644 drivers/gpu/drm/bridge/innosilicon/inno-hdmi.c
>   create mode 100644 drivers/gpu/drm/bridge/innosilicon/inno-hdmi.h
>   create mode 100644 include/drm/bridge/inno_hdmi.h
> 
...

> +	drm_encoder_helper_add(encoder, pdata->helper_private);
> +
> +	hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
> +
> +	drm_connector_helper_add(&hdmi->connector,
> +				 &inno_hdmi_connector_helper_funcs);
> +
> +	drmm_connector_init(drm, &hdmi->connector,
> +			    &inno_hdmi_connector_funcs,
> +			    DRM_MODE_CONNECTOR_HDMIA,
> +			    hdmi->ddc);
> +
I really don't want to anticipate bridge maintainer's feedback, but new
bridge drivers must not contain connector creation. That must happen
somewhere else.
Also I'm neither seeing any drm_brige struct nor drm_bridge_funcs, which
are both essential for a bridge driver. I don't think moving a part of a
driver to .../drm/bridge/ makes it a bridge driver.

Regeards,
Alex

> +	drm_connector_attach_encoder(&hdmi->connector, encoder);
> +
> +	return 0;
> +}
> +
...