Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3177314lqo; Tue, 21 May 2024 08:55:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWbRa0SK0I4Mp0kLqSUpvM9dGoB3EdalIcBkl9JMj+gK0bTcxiU1/t+ZqYCAzf3vVN3j33cATU9Y1j6/jb59dvQqjiyqgJ8E3lRBf82yg== X-Google-Smtp-Source: AGHT+IH4vQynZ9Ikau/8jdSj7ZiYvCymYFusKQR8YHvgRRlCGIBIafEtzjWw8HFJ1+Ylp9KoDXlZ X-Received: by 2002:a05:6a20:de89:b0:1af:d4b1:889e with SMTP id adf61e73a8af0-1afde1ddb99mr31011245637.53.1716306912248; Tue, 21 May 2024 08:55:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716306912; cv=pass; d=google.com; s=arc-20160816; b=s3E5LNg4hLHRt/XckFPffgZa997JiR/jQJhqjBI1/2t4TP27iGkDqRKsNwEqqxAl8e wk9009mFzNTNa2KRy3NfD8fCCcovwpNFxl6vk4u9KXChcB2cxCfNeCxaB7+Aft6rmGaR RBBMvvUdJArdlIOTQpmtty5mNRAZ/59yXMkMIUx8vfcNfq9z49Cyj6IqxwGlffLMpdpY 1QQe9+zSEH7UIYxg+V6bC0kAC3TLHPeuMfj8sy57aAGIkK7okUwPqKKTNZFvEdSkYWHU 8xu4b/1mqFfZh70xtEBX1BY89u1RrUSwwO3k/qXg0QaEgwrUDMmio41rkl1YImdMJLt5 sQWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+exNWJ2f1JRklZ6bkbodlLKC5KMK9e9kaHtrEIGuTKE=; fh=CIg/BA2PsMORimCRnf6LNoiIPj013f7MHt22vvSQBPg=; b=oyK6fhfmy33vG0Yeh4KkVTkzHZnp5vbCmX87BNaxClrsYCJaY0FKX9jWRcDp4wilU/ hD6kMGnt1Uqufixq1Z6N4H+kY+oj9qauVfDakmpHg8BGBgb9S/JUabhCXpQETAwk64Aq ltIpuvkV0eXCYMqgzSelBV03MLkyoCpamM+UJYFkwuaH+zl2h4p7TYMRVilvJeOMrSXM /Mv0YDdeOVsFDYhauGm47OB7CWwMicOrs9qmJ+5kR791tOIlVacxI9aZFdVKOMWB35Sc qyhBX4l1m/HcfWSa2DZelIWQ0Suy0zXaYPp3oRxH55PQ3F73l4m1s3N5fcCRbcXqndB2 a0ig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ficKUcQ1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185188-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185188-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-638b8059657si22223110a12.604.2024.05.21.08.55.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 08:55:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185188-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ficKUcQ1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185188-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185188-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BE1DA28443D for ; Tue, 21 May 2024 15:55:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6EA3B1487C0; Tue, 21 May 2024 15:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ficKUcQ1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913D31FBB; Tue, 21 May 2024 15:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306891; cv=none; b=JELJqdoc/FGWIkdfxQjWaTzZGRSTIAuGDbdMO6Dx12FXFT31ILQLnpkVYzebe8AT+22u06H2Wyuc9vDTsl1ic4htH2z6wTx3MCtF4vJyLrTqcL6GR0NHmkbT7QUn73JFMZRikpqhO1Z1mZA9y4JZOdUaS31AAnlBymRZWofA/m4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306891; c=relaxed/simple; bh=ZiVylaIhpmU5Y8L5i/SnpTaX9nQlLaIxh9KusDNt/0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MpINgXWYOrwsD4MBjA7rrIT5IaFQkjdXaOoJuuKS98nc7a/h+t0djrCSXzO3QUrUrDINJccndi6Yn89NuW6GR4BafSYpwOE1im6f5ZFpwHwBJM7h8q91JrZIwiWHixt8rAPK19sNQk4uklZysGdOknh2vJ1b9iB824e//KC5Dcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ficKUcQ1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA61C4AF0D; Tue, 21 May 2024 15:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716306891; bh=ZiVylaIhpmU5Y8L5i/SnpTaX9nQlLaIxh9KusDNt/0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ficKUcQ1Rlp3RRbru0nSthZ9Uzc2zECFLSArZF+Vf7KqkzQ7XxyWFHrpz7bZ9O1vz 7sLnUe+3scjTsJg4VHrQJy7gNszTmzQP0cNvYOTaCXHW68de3vyWnZUJZHBINmJuaD J7pR5CmQBb6bFjzhsK4VRZUkRLE7QotGW7hWYC/0Hab7jQjS8XXvCUtpNvlZ7H8ADM EpLPNdOiQZlrf5aUO0fS08ScQWeAR4Qm8/5EGVkPho8v0JedicM5EW3Ka3CQH1O7PH L4EtClo2MfNqL66YJkSwfiwHpbiCHW9AkYwqAzZwB7w0hSnZMargpH7LoHndxuYVgx QixH0o3hqqqVg== Date: Tue, 21 May 2024 16:54:46 +0100 From: Simon Horman To: Ryosuke Yasuoka Cc: krzk@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syoshida@redhat.com Subject: Re: [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() Message-ID: <20240521155446.GA839490@kernel.org> References: <20240521153444.535399-1-ryasuoka@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521153444.535399-1-ryasuoka@redhat.com> On Wed, May 22, 2024 at 12:34:42AM +0900, Ryosuke Yasuoka wrote: > When nci_rx_work() receives a zero-length payload packet, it should not > discard the packet and exit the loop. Instead, it should continue > processing subsequent packets. > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Signed-off-by: Ryosuke Yasuoka > --- > v3 > - Remove inappropriate Reported-by tag > > v2 > - Fix commit msg to be clearer to say > - Remove inappropriate Closes tag Reviewed-by: Simon Horman