Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3177471lqo; Tue, 21 May 2024 08:55:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXXQEAOh0QW5TYjUhk1fPkd9YQMJmPzUuTlYW0wHTRgYIlRoVvX08t9pfR0/kD/nLsJ+Jlv2G5R5ZBTgDyPG0axwL6S0YYsAiha4NQTug== X-Google-Smtp-Source: AGHT+IHXUv/AZQ6JFSTaZA9/Dz7jXJkUUh8QT+Rd0gayomDnQ3rkGoQhhaTQDR06fb6SYHCUIF2R X-Received: by 2002:a50:cd0a:0:b0:574:ea0b:c1a3 with SMTP id 4fb4d7f45d1cf-5752b3f884amr8771600a12.1.1716306927768; Tue, 21 May 2024 08:55:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716306927; cv=pass; d=google.com; s=arc-20160816; b=LzriF7MuqTi6Tmx5AIELn4+VRuWGJbpoKgMRRT7W66eZv1fcZwKKMJP7GAhJwfFnS/ hDIaxgYrHPQLNha37dqDfgydrPwx/VeKDODAX4D8nC3YVOATlT4wLBh+5WdMdgtMXwcJ D0k5vYwQV2w6KFHyA4+Ej+nB7Bu815jfeiMbuOTaRmmUsQPz+2FoyS+eONuoyOHKBKCW y0EH5IEjNmwpp4X3LUIj9Beb2g3NwXrcE/RP/RHl+YjkRwAMWf6kURPze5Dj9lQ7d6P1 SgcWXBBgxQqeMl3xc5eMPkDRrGfVSV4jZYv+D+ZLekhRAt0QBeGoujC2acKEKlWt4E1m jdOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=ETMyAjhAyjRrYjH6gWRvwzWDDJXx1j3zk86x7NvOJmw=; fh=s+niglHrocknOa0M45OuVG4aXd5rjo8nLQCogCYAiXA=; b=Q/NVzHlIfGeCAy6CSbwMbiDJTy+dLOcNjiQO6e5p1nT5EglN2lpft6jjhz2pRJXq+l F1LEsWi7PoDILPS/jzxWPNMhljHUvmPl2P6dgfsDX8BUhbyqTXPS14emlu2TyhzqSkvk NpXIjDfTSQV/lqlx7+gHU7WYaCV6huEQgZqFoB2SNFNexncdJZcizMRyBsGuxBYgIILc Zp4s9Ywif9SiEbIVR4QVEsrnG1wTOXKp3q2RUIM/4/6FhFF9pmvpWRxOCAhkstrwTf7e LUzgP9kqeO5YVBuhm9Vkj9oS0Z/IfPYdj9CVSPZk0+sqb5Mq0fA1bxdok51NZBrvb0eg Yl/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVmTtRd4; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-185189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185189-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5750c5f45fbsi6435715a12.292.2024.05.21.08.55.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 08:55:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVmTtRd4; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-185189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185189-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 80E131F22F35 for ; Tue, 21 May 2024 15:55:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F3265147C71; Tue, 21 May 2024 15:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PVmTtRd4" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3346142E72 for ; Tue, 21 May 2024 15:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306907; cv=none; b=HLOXYpYbsWvX09iqdK52H6l0NgEtG6j2K0JyZFU+bnMAMrOf2Yvx42vV0Mmnb0xZtWy6RWP9JolZkVZpTY9E7xOxVFXr3tpGwB6CDiCOHEF3x29crAdjzX6Yd9cYBKEzUKfmDUhUWmylUvrU4VTdeEsRlUJkLiRCrIA/4unzA/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716306907; c=relaxed/simple; bh=ETMyAjhAyjRrYjH6gWRvwzWDDJXx1j3zk86x7NvOJmw=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=T48Js/deK+fTQGzkNRWpbZSQidNmyJ+sEhGH6fVHTIwTDhkQxgdeqxt9nmYncyM/YnJkw0bkxzOoi8jvt5k83m8RrwmTovelwLQR00NViKkvXDrzbEeaf+s0rfOwS8yMKOPxucxWM7oncwg7BIgjHPKLvGF4majLfy/pbOhi1Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PVmTtRd4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716306904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ETMyAjhAyjRrYjH6gWRvwzWDDJXx1j3zk86x7NvOJmw=; b=PVmTtRd4Q7pRIvGB2Mpv10JitSPu8cGNZl7K7REufTiFiqCheD77oAXRhHdX6fcEZfT0D8 Vu5q9/my5OVNqh2islmzF7gRH5NiJjqyXVt4aPxtM+7f658BJyhl8ylb8HhNS6ie002Rbx ktUuNYZwh5zF1U7/h7ycGwWYSpJ437I= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-l7H-i_idMlq5SSTveGjq1Q-1; Tue, 21 May 2024 11:55:02 -0400 X-MC-Unique: l7H-i_idMlq5SSTveGjq1Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7132329AB3E2; Tue, 21 May 2024 15:55:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CB731C09481; Tue, 21 May 2024 15:54:59 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2e73c659-06a3-426c-99c0-eff896eb2323@kernel.dk> References: <2e73c659-06a3-426c-99c0-eff896eb2323@kernel.dk> <316306.1716306586@warthog.procyon.org.uk> To: Jens Axboe Cc: dhowells@redhat.com, Steve French , Jeff Layton , Enzo Matsumiya , Matthew Wilcox , Christian Brauner , netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfs: Fix setting of BDP_ASYNC from iocb flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <316427.1716306899.1@warthog.procyon.org.uk> Date: Tue, 21 May 2024 16:54:59 +0100 Message-ID: <316428.1716306899@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Jens Axboe wrote: > However, I'll note that BDP_ASYNC is horribly named, it should be > BDP_NOWAIT instead. But that's a separate thing, fix looks correct > as-is. I thought IOCB_NOWAIT was related to RWF_NOWAIT, but apparently not from the code. David