Received-SPF: pass (google.com: domain of linux-kernel+bounces-185192-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 21 May 2024 08:59:28 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>, "Davidlohr
 Bueso" <dave@stgolabs.net>, Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
Subject: RE: [PATCH v4] cxl/events: Use a common struct for DRAM and General
 Media events
Message-ID: <664cc4e01e02b_2c262944c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240521140750.26035-1-fabio.m.de.francesco@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240521140750.26035-1-fabio.m.de.francesco@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j3MqyeqSFscgsq8D5TNHGVaOc1okCNrkL3kM4rNnE3DprgPjt/kn+1d2V65l?=
 =?us-ascii?Q?cI4sSxvljeRyo2LyqbJmDBLlK1uS8B8W+lqPiM6PSseLVduIgJH3ycD20Y9L?=
 =?us-ascii?Q?tQahn2BD+3dJx3irsEH/mDiFgGGH1hBqmjkVqXMOpDL6xtwywxUtYqn8JcUb?=
 =?us-ascii?Q?P02Zrz8KZuGuK9vyD3k+XBS5c+YsA1L7nSgJ0Iz/MveifCl0u84cVekAUKfQ?=
 =?us-ascii?Q?2+muE6JGMnkxmfESLto8XXY3S4oaNcYt5vRYmn6hN9kytlRrvgwpRHatH3li?=
 =?us-ascii?Q?MziwspMNtALEsbqmOhkbMULe8+S9yKz15SKETXajwXpwSRdQonoLHeKjKxEW?=
 =?us-ascii?Q?DCrA3/RCKT59mG+yL0N2oz6/IRU2ByGMT8zq/UCpw3xP9on/AJun4lBDHofS?=
 =?us-ascii?Q?CcoyLLC/q7YvyIAD5kPVHlt1T9YeDlBz/MTLLv9Yt7RstD+BViTo05cpGGOG?=
 =?us-ascii?Q?piqd53iUDPRUdXnsS0uRypLePO/VwIzCYJm/6Lc0uZfn4B3yvX+WpdPXFKo8?=
 =?us-ascii?Q?BP7N1R970QzAzqFNuE7vKg6zkq+TWOGfiw4Qvn2SPakcSRqD8puWIjfKPJEJ?=
 =?us-ascii?Q?k9XmnvpukymCBVjCm+O2fXnewD+8EQ6TNZQ0+MNCXSkPTOprQ2zU7Drbg/s2?=
 =?us-ascii?Q?lgVWRj5/hWzS60apiKgCuqcDBywMV1cuWMfsOURsFIn3bxKPqxhh+f8JpksE?=
 =?us-ascii?Q?hmSNEpzDODFUegqujUOQYhtDD7hkffG9Ejt7zLwZvf4G7ywRZgPxlCKg9K6i?=
 =?us-ascii?Q?5A4i7QgKSJGPELkwU+RXRtM49l3sGLhs+EwRa3dnnPLletTxSGhvZOWUUkUy?=
 =?us-ascii?Q?qGnGpUTzl504xSQc2AiExyzoE4kbDU0YQtwibDTqSxdZ2nvUQbt6bn+2lBk/?=
 =?us-ascii?Q?MyaAk2uExfMwtXasGBahubllRbgAgfixcXwileHQRJ/ClgdTuh3+0axZmC5X?=
 =?us-ascii?Q?0aavY1ma+mXRaATGYcECsNY8fj1I0XtxJ8/u5dR+ExPQA5AKD+dTxxJir1Dn?=
 =?us-ascii?Q?0ioTaH8yLvkPqCi7gqo3KbtwG5yGgp/teuFK2GUEMpboEQV5iF/Nf5LADnZ6?=
 =?us-ascii?Q?OnX8zF1YKb8A2AIE2HiICsFHxpPYuGNgd1li0PpdBCJkH45INTUUpRqpkzhX?=
 =?us-ascii?Q?TCGudboJTM4O1GCiBwpfqeCLszLVnBNzplAXU3pRf44hdZAEJu01BALf+Pov?=
 =?us-ascii?Q?V19ruVjtin2IexX9biiG25LmKzeHopI6L9eyf5HOBFUOGvh11cHzKbf6+s40?=
 =?us-ascii?Q?poxNav+c0LHICyI2d5RBAN1Vdg4yNRVjsIi11h5DwFgW2zZ82G1tOuGtQdaV?=
 =?us-ascii?Q?M5oRFaUUfncatd+rAXsY/tl/a22tIb5O5n3cyKvRulQAZ0HHoj0056l/de8V?=
 =?us-ascii?Q?h2nZXOjN2kLbOTzfvcZ0LDQa6fRhQH9FK3ysk4P4Wdc1tAtgtPNAFWerXIsl?=
 =?us-ascii?Q?9m3cw6Dv4MbISd7fGfEATTcTlDSvre+PdQt4RPkmmR6NDzcnfuXwdlkkuuQn?=
 =?us-ascii?Q?nYeeRzzOo1BGPji/6WmoFOA7BVXNXFSDNMSfFgh8euPt75vaIG+1XXf8tsdS?=
 =?us-ascii?Q?7cKjmReTqdkoIsbOwTa4bkJ0kOnMKsxwy0YMlwCiGfg4bHj9/4H8RNM9fBnq?=
 =?us-ascii?Q?wg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09e1cb61-4a7c-436a-7294-08dc79aeffca
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 15:59:30.4507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ug15iRNKfu1yBPS/RDeTms5wt5RFne/rpVPf4a/pd1In6vVrTqFMUU1k/AZWy6AzkJl1fTr6isZYxjZ+9LACLSdKg43XRrCgzN4ow43kqxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6271
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> cxl_event_common was an unfortunate naming choice and caused confusion with
> the existing Common Event Record. Furthermore, its fields didn't map all
> the common information between DRAM and General Media Events.
> 
> Remove cxl_event_common and introduce cxl_event_media_hdr to record common
> information between DRAM and General Media events.
> 
> cxl_event_media_hdr, which is embedded in both cxl_event_gen_media and
> cxl_event_dram, leverages the commonalities between the two events to
> simplify their respective handling.
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Fabio M. De Francesco <fabio.m.de.francesco@linux.intel.com>
> ---
> 
> - Changes for v4 -
> 
> 	- Initialise cxl_test_dram and cxl_test_gen_media without 
> 	  unnecessary extra de-references (Dan)
> 	- Add a comment for media_hdr in union cxl_event (Alison)
> 
> - Changes for v3 -
> 
> 	- Rework the layout of cxl_event_dram and cxl_event_gen_media to
> 	  make a simpler change (Dan)
> 	- Remove a "Fixes" tag (Dan)
> 	- Don't use unnecessary struct_group[_tagged] (Jonathan, Ira)
> 	- Rewrite end extend the commit message
> 
> - Link to v3 -
> 
> https://lore.kernel.org/linux-cxl/20240518113317.3683718-1-fabio.m.de.francesco@linux.intel.com/
> 
>  drivers/cxl/core/mbox.c      |  2 +-
>  drivers/cxl/core/trace.h     | 32 ++++++++++-----------
>  include/linux/cxl-event.h    | 41 ++++++++++-----------------
>  tools/testing/cxl/test/mem.c | 54 +++++++++++++++++++-----------------
>  4 files changed, 61 insertions(+), 68 deletions(-)

LGTM

Reviewed-by: Dan Williams <dan.j.williams@intel.com>