Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3185784lqo; Tue, 21 May 2024 09:06:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWdIX4JENZAkPL4Qslj+dw0hAEjMzRzHETJCTxZdch3bcyJkuwzgRMxO6xYcLJAYLNpD66kLrZ0j3jgkxqwPXVUgcq3/O1T+Th8kEaAjA== X-Google-Smtp-Source: AGHT+IFrtNy2bUA8dywTGAg15rL90KiEO8ntmDsOFWr5HFDhgYtlg/eL7ooOWFyAzhueWf64xmr1 X-Received: by 2002:a05:6a20:5602:b0:1af:957a:75fb with SMTP id adf61e73a8af0-1afde1b7e87mr30372425637.41.1716307585844; Tue, 21 May 2024 09:06:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716307585; cv=pass; d=google.com; s=arc-20160816; b=XZW1LLyFtn/eQhUov+oeFtrHi1TMl0vz/X3zaLFVZ/xia9ptZ8uemQ2jO86zBsSglu 3Nc0k/QB2gCCsBhDh+ZkTlPL1yUYatSXkxw/jtx2BQlRmmzEudp1GpPEUON2ZKDXpDxZ pHsk2KiAfrts40ejaq+yyj7xRDhubKvAhAKegX/k1ab5HXZcTRvEaxxQUlz3mvFHGmaN ca+C6Ew/VAN87ZhmunttLXDKLv4TLZf5sroq6gNhB69gVwaaDhNJa6LRgzcsCKuGBCQD 3oGJ4BaYcpgH7QKbQV6qjA8pZjxLsOx8Na4yH8LbG1ayFPXG7DRBWohbOZpnQDnPc1d9 DaRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=Ju4HNRiaOvRrYI7sR7Tczm4YBlqCQdYlg/CzuEceDBI=; fh=EUtXlBJ3ggoKjsT5QioPBtvl0nuZODHVX87/rU2i9Tc=; b=i+84K4VonnagD2r3djAl+SawBWtYvFB+xkdPVy53RtSf+ZVwnv5Wosjrpi7Ct7JRYx ZUWX/rt6VcNDHNp8XhZg0NyDabGZ3KkBRQDlS/mEBvM3bfh1lRz9Q5oC69QDMS3CYM+w IEzkJwXM2+eIZQvTzGFHGBiwqaPNUaecYQ+fhD8f5/cg5V+X/t66zTQBw7oCqCCUAbLp R8GhEf6KcJcdrFg8sXasMSzgpmk3ykcpnsJCZmXNUBnyMKh/SxJ577neTjz3pN8nlQ4z 9wo5mThSJ1tpIscXZeHzNnrCh9FgKAwPJB+W+vFnCtZY00pg0d++2KmRNubqznLZAKT6 L1XQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=hlWyJHcd; dkim=pass header.i=@suse.com header.s=susede1 header.b=hlWyJHcd; arc=pass (i=1 spf=pass spfdomain=suse.com dkim=pass dkdomain=suse.com dkim=pass dkdomain=suse.com dmarc=pass fromdomain=suse.com); spf=pass (google.com: domain of linux-kernel+bounces-185197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-63411902dabsi23454201a12.504.2024.05.21.09.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 09:06:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=hlWyJHcd; dkim=pass header.i=@suse.com header.s=susede1 header.b=hlWyJHcd; arc=pass (i=1 spf=pass spfdomain=suse.com dkim=pass dkdomain=suse.com dkim=pass dkdomain=suse.com dmarc=pass fromdomain=suse.com); spf=pass (google.com: domain of linux-kernel+bounces-185197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C12D6B236B1 for ; Tue, 21 May 2024 16:05:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F4B120B28; Tue, 21 May 2024 16:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hlWyJHcd"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hlWyJHcd" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E13A1CD13; Tue, 21 May 2024 16:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716307517; cv=none; b=PFsrHJHoYNvVtA3diu8AU/81TMWwbgCCeDVA35H2VwsaPx40duiMu9Rh4skd1khV/2oR3Z5wxzlB8Vk5UjmR/ctdrt3KP8CaEVxA+qA6bm2bB8O85lEUbF3292AubrmTzeSOXrTvYe+MHJvQzYP1Q4tVLfrvFKjTAFHVyk5rAjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716307517; c=relaxed/simple; bh=N7gDzwrxS3u32IRNatT6UTzz15/lI/SVlb6Xi9bZwPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CzhY1QnBLCRyFV5X8tlDhItlcUXPW3JxfrvvewKjBgESMKsOonc7TtSIv0C7lHN1SyQjNohnaI1czijEaG6bbsrfDuYP8jSSLHV7ByvvHSf2frR4zIozTjDyW8cpUkFsE+yGOlRD57H+p+ZIg5ilBD/lvI2l97iw2TEPU8SaYvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=hlWyJHcd; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=hlWyJHcd; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8EBA75BDBC; Tue, 21 May 2024 16:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1716307513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ju4HNRiaOvRrYI7sR7Tczm4YBlqCQdYlg/CzuEceDBI=; b=hlWyJHcdQ3/8wmaYYDDHuX2FB9ta379fxwid5iToThDQ2ggLqDNUCmkA4vVrekbRS+PLc5 Dd9n/kYjc4WBI50qRKDd/FtJMs9/Sr6b9mn/R8ud6xYMZ6i05Ha+uht2vQMSkdXrwTtCDc eHgWzQGG4lUwsLwP5scU/vAILMcEvX0= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=hlWyJHcd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1716307513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ju4HNRiaOvRrYI7sR7Tczm4YBlqCQdYlg/CzuEceDBI=; b=hlWyJHcdQ3/8wmaYYDDHuX2FB9ta379fxwid5iToThDQ2ggLqDNUCmkA4vVrekbRS+PLc5 Dd9n/kYjc4WBI50qRKDd/FtJMs9/Sr6b9mn/R8ud6xYMZ6i05Ha+uht2vQMSkdXrwTtCDc eHgWzQGG4lUwsLwP5scU/vAILMcEvX0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A8BD13A1E; Tue, 21 May 2024 16:05:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 14nxGjnGTGYTPwAAD6G6ig (envelope-from ); Tue, 21 May 2024 16:05:13 +0000 Date: Tue, 21 May 2024 18:05:03 +0200 From: Michal Hocko To: Greg Kroah-Hartman Cc: cve@kernel.org, linux-kernel@vger.kernel.org, Jason Xing , linux-cve-announce@vger.kernel.org Subject: Re: CVE-2024-27429: netrom: Fix a data-race around sysctl_netrom_obsolescence_count_initialiser Message-ID: References: <2024051722-CVE-2024-27429-878c@gregkh> <2024052105-pulsate-reborn-119a@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024052105-pulsate-reborn-119a@gregkh> X-Spam-Level: X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 8EBA75BDBC X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -4.01 On Tue 21-05-24 16:40:24, Greg KH wrote: > On Tue, May 21, 2024 at 10:39:04AM +0200, Michal Hocko wrote: > > This and couple of others are all having the same pattern. Adding > > READ_ONCE for an integer value with a claim that this might race with > > sysctl updates. While the claim about the race is correct I fail to see > > how this could have any security consequences. Even if a partial write > > was observed which sounds _more_ than theoretical these all are merely > > timeouts and delays. > > > > Is there anything I am missing? > > Nope, you are right, our fault, I'll go revoke this now. please also revoke all others touching the same function. -- Michal Hocko SUSE Labs