Received-SPF: pass (google.com: domain of linux-kernel+bounces-185209-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 21 May 2024 09:19:54 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>, <dave@stgolabs.net>,
	<jonathan.cameron@huawei.com>, <dave.jiang@intel.com>,
	<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
	<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>
CC: <linux-kernel@vger.kernel.org>, Li Zhijian <lizhijian@fujitsu.com>
Subject: Re: [PATCH v2] cxl/region: Fix memregion leaks in
 devm_cxl_add_region()
Message-ID: <664cc9aa97558_e8be2941e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240507053421.456439-1-lizhijian@fujitsu.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240507053421.456439-1-lizhijian@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eG119cWFkfowhNSPM65WmFjGoOmf+d76ybwd9osJfSmLReYmNjiQ8qTp4uYO?=
 =?us-ascii?Q?L2iSAiqE9t0q0qNrLjkPRhdXEX6/T/ZWilAQv2kodlg3PLu7p2W1R2Z1yzJB?=
 =?us-ascii?Q?ZHx0ENpZC0AbKBmrg2lrXL2QdKB2/gxFXd9dwfbylE5xlkUwZVybpR1ac8MF?=
 =?us-ascii?Q?XU4iE8TKwJHP7GWrqQLlaVO3000JJeoRImFD34fKf01sQomUQVXD61GyIGlu?=
 =?us-ascii?Q?31D/hByYnmZC5DD47GWcu+EesaK+7vjeTLjJG2PYxKVZ9DPg9ZOBdD8BKhj2?=
 =?us-ascii?Q?rkNmjTq8l7THHoelAPFRF52uMT+bNWET+GWcCYQQJXQe1oTKOed6NfoUM9TV?=
 =?us-ascii?Q?0x5JWrb3J/xEdgASRV0fVVfalFYH3JVLJqXgyaoXtL28Hel8GacW/wBD8TF8?=
 =?us-ascii?Q?vW6AqMCUp/4S8wWQXx+TkDor7gL7iBYVbYvW3Ex0gbBHG4KVgbYbvFNEwNpc?=
 =?us-ascii?Q?CM6z4AEm4/GH/o6SVBZaIDFS8oIAy/aES/AiXwqYEmM/B5djDxklFiBmoMsG?=
 =?us-ascii?Q?mPTCsy9lyORJpoUJShzsVmp3XjsY8gENjaxApvMy8sV/6QSUgpcsEQ/CddtT?=
 =?us-ascii?Q?eLSBuFpo7+jE75P6fxMRqKt5FDPbNoXceBzRDbtXpC9fR5b/MSd8JvUAhZ/0?=
 =?us-ascii?Q?kRoL1NKZRsrZY8L3EwUf6YjRDz3WT9Gq2XYMoKFgK9B2V0DgITIWPGGofNqu?=
 =?us-ascii?Q?1ym22OailXxQycOmwX5i+txKNuZwj8XxNO20QF9qvlJHmBE+0bw9dM3msdVV?=
 =?us-ascii?Q?q2EXObQaq974l3+FkPKnykNetsZ7dlsX6aubxQ2u/Bb5lt0thiKnBDY0/CDC?=
 =?us-ascii?Q?B8pjAanpICNSP+Pqb1SzTETFnHQS+EIJ+7giHWh8xSIvQ5IsJ4ZVVA8J+jNz?=
 =?us-ascii?Q?XXX2szxzmudRcVyavaIbg5dfgNOJ46mvNLIy+NDWZZIsrvostDdw+IQDNoe1?=
 =?us-ascii?Q?AcVJpXHKvOrcKPuULun+Fe5p0gJN8CDm04E3wwhROKFi2M3ZWIOzFNl5x3DD?=
 =?us-ascii?Q?ucrVn+Ssrv3Wpx23L1sAkXIkPQNaNFGPatHunBLcxM9qMt/3pvb2cpByTI34?=
 =?us-ascii?Q?/cDLQK5CnXmL+WvEASq+Ya+vJnG3yfoK6eJp1FlohSnp5cRwoPOq8uzfrADR?=
 =?us-ascii?Q?EiEJlAKK3zYRa1SFSeC32jKf7e4deVAdBwj5/7PvFzp5NzWnt4b6t6mT54kH?=
 =?us-ascii?Q?mmXmsRLGvNIUn2NQ56wcILgXN2vBb05oZs1+mG0Rt0BgELjU9WG8VE8fiSdB?=
 =?us-ascii?Q?am43WXN3hB8G7lSD/esu1O2IN2pYCvTkX/suTkSIaQ9pfPeQ19Z+m5M0hLz1?=
 =?us-ascii?Q?r07J0UdtAFB8oLdzgl/bcZ7IDO21iUVvnV8b9wleAOxTDXq05wcR5+s6aTkC?=
 =?us-ascii?Q?ruXLpzKRsEQfiw+KyvOzvDAaDExRPdOQubRhOW1m/58nl0+nKF5upLT4NHYZ?=
 =?us-ascii?Q?X/zeCnNZ1/CLghLNxxEj7X7aLbelSVeNMvtkkr3lD1usoUZ8qRlAXxwHmY05?=
 =?us-ascii?Q?IiLvrEZcDA4MYYSR1+I91JRFWwh5uD6AICqXDp1FKJVz8/7K7XcFau+iguqV?=
 =?us-ascii?Q?RVS24V89F8CHjGgzQIKhHKcFlQS/OiytQ7wWcFAs+yI8wDkc4CsJH3O4piJz?=
 =?us-ascii?Q?dg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca5d80b-4e66-49cf-d9d2-08dc79b1dae2
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 16:19:56.9629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rn78x2QwLkboIOZHThdHSbeisx7Ovu2EkfaA9PZ/xgPPZJXz9vuHK1cnmXaMjNz84yw1SWZdHfuvvyhg8RiJLWiTHQaFC5CXP8lc4ImDy9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4603
X-OriginatorOrg: intel.com

Li Zhijian wrote:
> Move the mode verification to __create_region() before allocating the
> memregion to avoid the memregion leaks.
> 
> Fixes: 6e099264185d ("cxl/region: Add volatile region creation support")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> V2: Move the mode verification to __create_region() # Dan
> ---
>  drivers/cxl/core/region.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

LGTM

Reviewed-by: Dan Williams <dan.j.williams@intel.com>