Received-SPF: pass (google.com: domain of linux-kernel+bounces-185036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 21 May 2024 16:52:36 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Cc: gregkh@linuxfoundation.org, lk@c--e.de, u.kleine-koenig@pengutronix.de,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: typec: ucsi_acpi: Add LG Gram quirk
Message-ID: <ZkynJGchSsg8YQH7@kuha.fi.intel.com>
References: <5qc55gruhn4pmutiukohauki5dehba6n2k22jgvpt7i3hafkon@v2ng2a33o7vv>
 <5fh2v2dcjjcgg3qgvbhlsf24kfigzzbv3sq5ykjuwyjodbqzsa@kf7crcyswm5y>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5fh2v2dcjjcgg3qgvbhlsf24kfigzzbv3sq5ykjuwyjodbqzsa@kf7crcyswm5y>

On Thu, May 09, 2024 at 04:27:41PM +0100, Diogo Ivo wrote:
> On Thu, May 09, 2024 at 12:50:36PM GMT, Diogo Ivo wrote:
> > Some LG Gram laptops report a bogus connector change event after a
> > GET_PDOS command for the partner's source PDOs, which disappears from
> > the CCI after acknowledging the command. However, the subsequent
> > GET_CONNECTOR_STATUS in ucsi_handle_connector_change() still reports
> > this bogus change in bits 5 and 6, leading to the UCSI core re-checking
> > the partner's source PDOs and thus to an infinite loop.
> > 
> > Fix this by adding a quirk that signals when a potentially buggy GET_PDOS
> > command is used, checks the status change report and clears it if it is a
> > bogus event before sending it to the UCSI core.
> > 
> > [Sending as RFC both to see if this is a good idea and so that more
> > users can test it to gather all the models affected by this bug.]
> > 
> > Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> > ---
> 
> I just realized that I should be using the {set, test, clear}_bit()
> functions in the patch I sent, sorry for that. With this in mind it
> would still be good to hear what you think about it.

The quirk looks reasonable to me.

thanks,

-- 
heikki