Received-SPF: pass (google.com: domain of linux-kernel+bounces-185241-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <4bbb71a1-bd5e-4549-8a54-e3781290591c@oracle.com>
Date: Tue, 21 May 2024 12:57:33 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] KVM: x86: Drop unused check_apicv_inhibit_reasons()
 callback definition
To: Hou Wenlong <houwenlong.hwl@antgroup.com>, kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
References: <54abd1d0ccaba4d532f81df61259b9c0e021fbde.1714977229.git.houwenlong.hwl@antgroup.com>
Content-Language: en-US
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
In-Reply-To: <54abd1d0ccaba4d532f81df61259b9c0e021fbde.1714977229.git.houwenlong.hwl@antgroup.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SnVVSnNzMEpUK20vbGFldDM1L0NzNlNuRUUzTGg5L2s0cmI1OUlITHBXUEdx?=
 =?utf-8?B?Sy9HTndyd1JEQVl0ajEwVGprS001ZEpCeFp2OU5LOHhhTTZ2SDhCa3pBL1hU?=
 =?utf-8?B?RnZoSHVzTjZNNVJ5cUd1ZnpZdjVqOFZwMmVaRm5VaDNqandZeXB1Tk9ranZC?=
 =?utf-8?B?YVovbEh0dllWR2k2Rmh4UlVQMUFRdHdmMDZqdWlBU0xCWTlRYUduWTJvMUJP?=
 =?utf-8?B?VWZPb1JSdWpqcXJINUQ2dGJsWjRBaFVoYVJnTVVkTCtGSTV6dkFnSzlnaFhh?=
 =?utf-8?B?OVgxMWx6TXA1UFROemVnVUJWbm10V0N4ZHdzb0hqalE0U0pwM1NaVXE5S0dI?=
 =?utf-8?B?aytDci81blIrV2lSdXNSS2VFWXJpSmRYSG5LVmtBV1E2bTNTclgvRkNnTlNj?=
 =?utf-8?B?dktRa1NOTDlRMlp1YklaUEpGd2ROTWN1M2hLSk4wWVhNQ0VWZTVLaS85WXdF?=
 =?utf-8?B?ejBHSXlGYk1XQWJIeVZSclloNEtucHRkckJxNERUa0NmSm50R2ZLOVRzMlhG?=
 =?utf-8?B?MGNsM24rVEdIWkxOaVNzRGZiL05DZTRSRlFaN05QcmJoR2Uyc0VsRTEwRFJz?=
 =?utf-8?B?YUdvcHdPUFFhcXlla2NEMDAvSzdDTlNLenJvYzlsRUpjRm5SbU5ZTnE1a2NH?=
 =?utf-8?B?dmNkQkhXVTNsM3hOSDZpcHR3SWZFdjRVN253a2I4VkNKMWdhWGkweG1YYm8w?=
 =?utf-8?B?ZDRDandLSEg5clZVd0ttMGdPa3F5ZnJLS2IrbDhLek8rQ2JWU1lPV2E2QWh3?=
 =?utf-8?B?TzZqL3lkdjdxTFhCMTBlblZQSzIzV2pGNE9KcGJHUkxZY3luWkVzQURiWnM4?=
 =?utf-8?B?bzhYR3R4VVBUQVFuekZvaDhSUGRuT1ZabVd5aXE1VVA2enVEUHlZRHJNMDE5?=
 =?utf-8?B?NFRaWWFHSTBwUDhMbCtJWHM1UGJLVVFrU0dnTFU2RW9hR2NSTy9LeS9BYXp1?=
 =?utf-8?B?QmtUdkdFbUlvNmhpb3RXLzdHalZmeDZrWWNLNWZIYTVKeVRDdHZ6OWROV2ht?=
 =?utf-8?B?SG54Mm9nZjg1RkJBSGViRGdEcXQwaDFJR3hzWXQ4TFFzMlZEOGxDTkZJaG9p?=
 =?utf-8?B?czdhelBKQk9uZnZIb25ac0VjNEgzYU5OM0JNRHU1NmJFZmpjSFk5T20ySkRI?=
 =?utf-8?B?Z2pDdTNGMFI1bkx2RzU3c3JzWlR5KzgrSGUyNzE2R3Q4Y3dlNytoc0FpYjkw?=
 =?utf-8?B?SzY0QThQSXJyNHl5SDVKY2lMV1ZEeVlXWUJwK01NVndmY3k5Zm9VbzNjOWdr?=
 =?utf-8?B?KzE0b0FIdmhpNENuSDQ5b0x0VlJuM1VDZUZxY1R3bGFuKzVROTRPSlRvSUxr?=
 =?utf-8?B?eG9qcXU4WUJKOHE5aXJObWpaWjJzZ2YrZDNmWkpreGZTRkpKVVo3ZVlDOXhQ?=
 =?utf-8?B?c0VzckNCdW5tSThlU2Z1dHVlSmdzZmRHNWtYWkNNTFJKelpHYWFXeXU0ZGF4?=
 =?utf-8?B?QlBLdjhnYlRNQ2YrZi81SlM2TTZXU0htWmRmOWh5UGxKR3kwWjdkdTNJcUR4?=
 =?utf-8?B?NEo2ZC9PK1BZWUpXU1RYa2p4KzczWlVRY3RabjM1QitjZCtiNkNDTG5qcnU5?=
 =?utf-8?B?TkYyd2hGMHJBZUt5RjJvQ2hXelB0WWp1aFhOK3B4ZHVJUWZxZG55dHBkelFh?=
 =?utf-8?B?MTR2b1Y3UFVkUkpEQy8vWEZPTU1Sb0RqcmpBZjh5dENoQXp0ekdMcFZWSUVR?=
 =?utf-8?B?Q1RvV1lFVHErcnNubTBaNy9EeTZWS2ZKcXdRSHpnM2dTYWI5S3pubnpwLzBw?=
 =?utf-8?B?TlpYL2tkRFByUm0vVEJZRjRDZmxDUk9GTSthZHU2UjRXK1hiRnFvSUIxQmox?=
 =?utf-8?B?UDdJYnZIVU83RjBaSThMdWtlOGhneDc2S2ZBbUttWFZ2anhoSHgyTmoxc3lF?=
 =?utf-8?B?S2JMaE1SVmt1N29xN05sbjFBWC91QmUxSGFWMGx6RGpyU2tudlpydWVtY0VG?=
 =?utf-8?B?WkJUWE84N1k2WmZ2S2VFNXVWWU1SZmJnM2Y1c3BvRDY5RFFjcFJDSzU4R0s1?=
 =?utf-8?B?aGN6SjBtWk9DRXRCdmk1Vm04TnJXcHU0bWZxQ3JRRWRKWE9hcVZxV2xqZWNR?=
 =?utf-8?B?UTB6c3B4My9mWDNNN0RoTFVFNDhlQVhmUXRKcDBMRmloZjNhdmR4RmpLL2lJ?=
 =?utf-8?B?b1M5cmhwN3RIRWdTTCtKM0pqWG5Jc3Ura1RBVzYzeFYvTitjQmsxdklNZ1k0?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	y0wj5I1ZeyZfGzmD/AWuiY4SmCuSaAiPH6wtx4k7wb8wr2ky/5CMPvs8DlyZ1bdh8+/axRvidnzpzhouXn2mVff2XvqXek+EQ2XimzIjOZk6P88Ml8Z5bz90r2VvD9qkszDmrL8q+VrXgzDFMJagIM4kLQ1/mOWoa+FhtK8UH0iORcu/mVlyR1luZQk+lBsWeiZEGyjn8y8Hl4TqOmpPEE7EhKLMWdf3jvBvW/szM8RHwVi7VtHyp07IyEcgMaO64tcx/D8ssUwjdiAfZFIBhUKNrBpS1jmKu/H8Ucg8tnAGDlXWBY6QYxJViQfcKvivmiXdNy+8NqhLKbhDRuuj9ssSM2/7ivJSyE+aZS29gYKGtN4x9CDOWroGeqsSABppKBAO7jD8VoR7Ng/0rSwMyN0AXLS2CDl+tXJRElYcS0uneXPbCG0hhExbSGuBT+0kr7svyKsK+QBj8V8yt84s1XJVgh4MYuhaufzB1I+UvPTWJqTLCY+k5HHvLr2GY+/BlmCYkczW03zev8OBWVGJCUzyYIPjKGrquJ6Bp/fYvgEHs/pyKFhzDx3lA1/Hqd8nTueLlYUgsfpHj6oDj74oBnfu0oPSz3F7HGCVUdR0G6M=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37206a31-e67f-4864-cbd8-08dc79b71de7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5280.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 16:57:37.0379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +rOtZ6uOg3267Y4QUXyX4Fvbxtn5wZZgbRGrz5evRVjmKK1c+h8NjApKJecEAplosLWCTRoSzJVeXlaQvI/zpkO1fLMW7o7J3OC7NXosi8A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7705
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-21_10,2024-05-21_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405210128
X-Proofpoint-ORIG-GUID: YX1tUg-tIbfm-82pVXtJspMipbFNriut
X-Proofpoint-GUID: YX1tUg-tIbfm-82pVXtJspMipbFNriut


On 5/6/24 02:35, Hou Wenlong wrote:
> The check_apicv_inhibit_reasons() callback implementation was dropped in
> the commit b3f257a84696 ("KVM: x86: Track required APICv inhibits with
> variable, not callback"), but the definition removal was missed in the
> final version patch (it was removed in the v4). Therefore, it should be
> dropped, and the vmx_check_apicv_inhibit_reasons() function declaration
> should also be removed.
> 
> Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>

Reviewed-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>

> ---
>   arch/x86/include/asm/kvm_host.h | 1 -
>   arch/x86/kvm/vmx/x86_ops.h      | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 1d13e3cd1dc5..a10d7f75c126 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1702,7 +1702,6 @@ struct kvm_x86_ops {
>   	void (*enable_nmi_window)(struct kvm_vcpu *vcpu);
>   	void (*enable_irq_window)(struct kvm_vcpu *vcpu);
>   	void (*update_cr8_intercept)(struct kvm_vcpu *vcpu, int tpr, int irr);
> -	bool (*check_apicv_inhibit_reasons)(enum kvm_apicv_inhibit reason);
>   	const unsigned long required_apicv_inhibits;
>   	bool allow_apicv_in_x2apic_without_x2apic_virtualization;
>   	void (*refresh_apicv_exec_ctrl)(struct kvm_vcpu *vcpu);
> diff --git a/arch/x86/kvm/vmx/x86_ops.h b/arch/x86/kvm/vmx/x86_ops.h
> index 502704596c83..4cea42bcb11f 100644
> --- a/arch/x86/kvm/vmx/x86_ops.h
> +++ b/arch/x86/kvm/vmx/x86_ops.h
> @@ -46,7 +46,6 @@ bool vmx_apic_init_signal_blocked(struct kvm_vcpu *vcpu);
>   void vmx_migrate_timers(struct kvm_vcpu *vcpu);
>   void vmx_set_virtual_apic_mode(struct kvm_vcpu *vcpu);
>   void vmx_apicv_pre_state_restore(struct kvm_vcpu *vcpu);
> -bool vmx_check_apicv_inhibit_reasons(enum kvm_apicv_inhibit reason);
>   void vmx_hwapic_irr_update(struct kvm_vcpu *vcpu, int max_irr);
>   void vmx_hwapic_isr_update(int max_isr);
>   bool vmx_guest_apic_has_interrupt(struct kvm_vcpu *vcpu);