Received-SPF: pass (google.com: domain of linux-kernel+bounces-185366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>, Steven Rostedt
 <rostedt@goodmis.org>, Thomas Gleixner <tglx@linutronix.de>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v5 19/30] printk: nbcon: Provide function to
 flush using write_atomic()
In-Reply-To: <ZktmhL2hos8-IrNb@pathway.suse.cz>
References: <20240502213839.376636-1-john.ogness@linutronix.de>
 <20240502213839.376636-20-john.ogness@linutronix.de>
 <ZktmhL2hos8-IrNb@pathway.suse.cz>
Date: Tue, 21 May 2024 21:13:09 +0206
Message-ID: <87seybdlwi.fsf@jogness.linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 2024-05-20, Petr Mladek <pmladek@suse.com> wrote:
> What about reshufling the code a bit?
>
> <proposal>
  [...]
> </proposal>

Your proposal is fine and is easier to follow. Thanks.

>> +	/*
>> +	 * This context must flush any new records added while the console
>> +	 * was locked. The console_srcu_read_lock must be taken to ensure
>> +	 * the console is usable throughout flushing.
>> +	 */
>> +	cookie = console_srcu_read_lock();
>
> In principle, this should not be needed because the console is
> added/removed under con->device_lock() in
> register_console()/unregister_console().  And this function
> nbcon_driver_release() should be called under the same lock.

I added a comment here to make it clear why it is needed. It is about
making sure the console is _usable_ during the flushing, i.e. it
prevents console_suspend() and console_stop() from exiting while the
flush is in progress.

I will leave this as is for v6.

John