Received-SPF: pass (google.com: domain of linux-kernel+bounces-185361-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <17782a6e-db84-4c20-874a-342b9655ffc5@amd.com>
Date: Tue, 21 May 2024 21:03:59 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs
To: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>, alexander.deucher@amd.com
Cc: Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, "Pan, Xinhui"
 <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Aurabindo Pillai
 <aurabindo.pillai@amd.com>, Hersen Wu <hersenxs.wu@amd.com>,
 Hamza Mahfooz <hamza.mahfooz@amd.com>, Wayne Lin <wayne.lin@amd.com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
 Fangzhi Zuo <jerry.zuo@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
 Mario Limonciello <mario.limonciello@amd.com>,
 Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <fa885eca-d7e6-415a-8a08-9103b002c6bb@amd.com>
 <20240521051140.30509-1-rinoandrejohnsen@gmail.com>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240521051140.30509-1-rinoandrejohnsen@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YlhqZGxtSC8rVEFQRTdlQU1wNXB6Qy9FNnZYQzd1YTB4N3VBbFRwUG80N2Ru?=
 =?utf-8?B?NS90MHlOdk9GQkw4Y0V4dityWHBkM1N0UWUzWUVTOUk5eWgvT05VRnRVRG03?=
 =?utf-8?B?Y2p3VkRjMkNBMnhtUU5qdCtCdlZwamtCUU5zeW43RXZQQXRTS2tyUkc1RlBa?=
 =?utf-8?B?WGVIZ1NGNGhnQUlOMC9samQ3Nnp4aGVpbEZVZ2tIK0pkTUZwMUQ5TlFFd2Za?=
 =?utf-8?B?WFY1clMwaW1wQWlCK0ZSMmF2b0gzT1ZpOU9YenZuanZlazc3T2s4TStaYXZ0?=
 =?utf-8?B?cFoyeUFqT01PNytOSG1WK21YUDdxYU5vNzJWNlg2azVISjNTNWNrOHMxeGZX?=
 =?utf-8?B?a0g0cDRZTCt3SUVZUGNQSEY5eUJJeklEMFBBdVVUWVVReHZmeEJObjFMRlgr?=
 =?utf-8?B?ay9xRU5OZWxMUWRFZXRxZGpMYWtFNzc0MEY3RUVqSjkwdFRHbmlOdDIzc3pH?=
 =?utf-8?B?TWlsRmlFamk5QktIZXVpZXMrMGpsYW1HMmtPcnZubkhleEwyTjRrY2V6MVdU?=
 =?utf-8?B?NXNhZ2x0TTFLRkFSbXl6S2JCblQvdm5aWUVIZE90c29qKyswNWg2dlZ3cXRt?=
 =?utf-8?B?WEI5L0RUTVRuRDladWFuY1kyeWVJVm1keXBQd3lIaE5qeDRxQWZTMkpXMEd1?=
 =?utf-8?B?U3poalNUQkFUcGZQc1hrUUVnOU03RUFKU3pySEc2NDJsZE5STWwvd0ttWmxU?=
 =?utf-8?B?bnZLVk9VNGlRN1h6dlVwc3NhMjJQVGNUUlhaZWNMMXBRQkszUDBZSXJyeHZZ?=
 =?utf-8?B?WHBYWlBSVFdsRWxINEpNS3FtYURnOTBrTnlhazVad0JXclc5Ylp1cFkweThZ?=
 =?utf-8?B?L3B6bDlYbUxiZmZZdWdJaDJhbGkrZUYveE1MOTdUVi9YUHQxQ29FcExPQ2tL?=
 =?utf-8?B?L1lMemVSUzAwM0NLQ3REQW5PbkhLRmFPbHRoMGVaSVNpUW9PV0x3b00zcmI0?=
 =?utf-8?B?ZzN2RUFoRkVERWNEVlFzSUR6bkFRM2VhdFRxeUxpa0ZCSWdqVkdHSmhzSjVl?=
 =?utf-8?B?SWxIZVh0aTZIVExlWTN3akJwc2hDdlVwdkRCZUFrVld3akEvNG1sOEhBclFG?=
 =?utf-8?B?cW9yK2FCMTRmUVNicXU5cEpoTkk0K2I1UnVEWkRFci80cnQ1SkdPenNmMVlo?=
 =?utf-8?B?NU1uQ04rdjNzVHdIVHFaVnROYTJEYlhiWDVwUWI1dnNwbCtWUjdVQk8xajNZ?=
 =?utf-8?B?SzRUalBsN3JzblFiTVdGLzlKaUQ3OFVTU1RqaVZVL2dxMEdHY1FuZFUycW5v?=
 =?utf-8?B?Y2F5cUQ1THByTDdBYUtxb1RMeFRtK2oyVzZZWm5xY3lTcUMyV0h6SVBGR1k1?=
 =?utf-8?B?alJHWnE1ZjhDUXBkSkh6VHl5cGtRWDRJZEVkZ2QzVTI2ZHlmS005a2QzMUNp?=
 =?utf-8?B?cmpaQTJCMzEvRlg5Zjc2a2NzZ2dhcHVpVDRpUWtnYWpGcGlKdWhxSWJPY1Zu?=
 =?utf-8?B?eWZXbTV3emplcUNIWWluTVNiZXptR01WYWxsRXN1ZDJROEw5QUlKbkJBL1hJ?=
 =?utf-8?B?dkZJWkQ1dC9sUzBKVVpzYXE3cW9nRHEyQ3FNR0JLdm0rZlVDVEFQSzNvc0dk?=
 =?utf-8?B?WEpYcGlUQjNYdE1VRitZRmNKZDA5aGZYVmR4aHBFbXJxcmc4RGJaaEJncStk?=
 =?utf-8?B?WHAzSUlRbGFHeldJWHdjTW5ZSGlWcHNWVWFDN2hQM2hkbU8vWUhVZVJBUnB0?=
 =?utf-8?B?elpsU21BTnhWdTVsNFlvMDlKYXVQVlhQcWh6VXRFeGFwRnFLMHBoU0h1Mitz?=
 =?utf-8?B?TldjZ1VhWTNBL0VUWTRoNE1pVHNGZkZ5UVp4U1NMWFRGOUtlbk1COFhIeUlO?=
 =?utf-8?B?TVlJYXBUTGJSalRGeWpsYWZNdGw1bmxzU1MxcDBxa2t2SDlmc1RNUzlUTjY4?=
 =?utf-8?B?bExubTl3YVIycTlkMWdrRGwzVEtQbE9YNjlIRXh0czZHVE9VZnFzTG1veWpQ?=
 =?utf-8?B?UHpWcUJzUHlEbUxtb2JubTlod0lIVmg4dnRJRk0wc2U1dkQ4dUxWR0pPdGdj?=
 =?utf-8?B?eERCQ1VpY2ZMUmMxQVNENU1LU2FHSHFnQUJ2NEhiL0RLRzlzOFo2aWYzZVF1?=
 =?utf-8?B?anRDWnRZQ1N5MU1kWXd3aHpoQ0dTU0dWU1VvcE9jRmVONGNxb3ZiWUNicUM4?=
 =?utf-8?Q?lUN9SmjTOQewbRAvY+iVoft9r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49546291-3b42-4a6d-7575-08dc79c8ca80
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 19:04:08.0629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZ3owDklt4l2REPplDtJyw3rsqgIVftoqZ3EGXPwv32lwkVu7UNTq52o64u57KRs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7537

Am 21.05.24 um 07:11 schrieb Rino Andre Johnsen:
> [Why]
> For debugging and testing purposes.
>
> [How]
> Create amdgpu_current_pixelencoding debugfs entry.
> Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding

Why isn't that available as standard DRM CRTC property in either sysfs 
or debugfs?

I think the format specifiers should already be available somewhere there.

Regards,
Christian.

>
> Signed-off-by: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>
> ---
>
> Changes in v2:
> 1. Do not initialize dm_crtc_state to NULL.
> ---
>   .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 47 +++++++++++++++++++
>   1 file changed, 47 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 27d5c6077630..4254d4a4b56b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -1160,6 +1160,51 @@ static int amdgpu_current_colorspace_show(struct seq_file *m, void *data)
>   }
>   DEFINE_SHOW_ATTRIBUTE(amdgpu_current_colorspace);
>   
> +/*
> + * Returns the current pixelencoding for the crtc.
> + * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/amdgpu_current_pixelencoding
> + */
> +static int amdgpu_current_pixelencoding_show(struct seq_file *m, void *data)
> +{
> +	struct drm_crtc *crtc = m->private;
> +	struct drm_device *dev = crtc->dev;
> +	struct dm_crtc_state *dm_crtc_state;
> +	int res = -ENODEV;
> +
> +	mutex_lock(&dev->mode_config.mutex);
> +	drm_modeset_lock(&crtc->mutex, NULL);
> +	if (crtc->state == NULL)
> +		goto unlock;
> +
> +	dm_crtc_state = to_dm_crtc_state(crtc->state);
> +	if (dm_crtc_state->stream == NULL)
> +		goto unlock;
> +
> +	switch (dm_crtc_state->stream->timing.pixel_encoding) {
> +	case PIXEL_ENCODING_RGB:
> +		seq_puts(m, "RGB");
> +		break;
> +	case PIXEL_ENCODING_YCBCR422:
> +		seq_puts(m, "YCBCR422");
> +		break;
> +	case PIXEL_ENCODING_YCBCR444:
> +		seq_puts(m, "YCBCR444");
> +		break;
> +	case PIXEL_ENCODING_YCBCR420:
> +		seq_puts(m, "YCBCR420");
> +		break;
> +	default:
> +		goto unlock;
> +	}
> +	res = 0;
> +
> +unlock:
> +	drm_modeset_unlock(&crtc->mutex);
> +	mutex_unlock(&dev->mode_config.mutex);
> +
> +	return res;
> +}
> +DEFINE_SHOW_ATTRIBUTE(amdgpu_current_pixelencoding);
>   
>   /*
>    * Example usage:
> @@ -3688,6 +3733,8 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
>   			    crtc, &amdgpu_current_bpc_fops);
>   	debugfs_create_file("amdgpu_current_colorspace", 0644, crtc->debugfs_entry,
>   			    crtc, &amdgpu_current_colorspace_fops);
> +	debugfs_create_file("amdgpu_current_pixelencoding", 0644, crtc->debugfs_entry,
> +			    crtc, &amdgpu_current_pixelencoding_fops);
>   }
>   
>   /*