Received-SPF: pass (google.com: domain of linux-kernel+bounces-185375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 21 May 2024 12:20:12 -0700
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
CC: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <julia.lawall@inria.fr>, <javier.carrasco@wolfvision.net>,
        <skhan@linuxfoundation.org>
Subject: Re: [PATCH next] drivers: soc: qcom: Auto cleanup using
 __free(device_node)
Message-ID: <Zkzz7PZUnU/xP/O2@hu-bjorande-lv.qualcomm.com>
References: <20240407072330.229076-1-pvkumar5749404@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240407072330.229076-1-pvkumar5749404@gmail.com>

On Sun, Apr 07, 2024 at 12:53:30PM +0530, Prabhav Kumar Vaish wrote:
> Use automated cleanup to replace of_node_put() in qcom_smem_resolve_mem().
> 

I don't find this easier to read or maintain.

Also, your subject prefix does not match other changes to this driver.

Regards,
Bjorn

> Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
> ---
> drivers/soc/qcom/smem.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 7191fa0c087f..ad1cf8dcc6ec 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -1032,18 +1032,16 @@ static int qcom_smem_resolve_mem(struct qcom_smem *smem, const char *name,
>  				 struct smem_region *region)
>  {
>  	struct device *dev = smem->dev;
> -	struct device_node *np;
>  	struct resource r;
>  	int ret;
> +	struct device_node *np __free(device_node) = of_parse_phandle(dev->of_node, name, 0);
>  
> -	np = of_parse_phandle(dev->of_node, name, 0);
>  	if (!np) {
>  		dev_err(dev, "No %s specified\n", name);
>  		return -EINVAL;
>  	}
>  
>  	ret = of_address_to_resource(np, 0, &r);
> -	of_node_put(np);
>  	if (ret)
>  		return ret;
>  
> -- 
> 2.34.1
>