Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758671AbYBAKuS (ORCPT ); Fri, 1 Feb 2008 05:50:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755450AbYBAKuF (ORCPT ); Fri, 1 Feb 2008 05:50:05 -0500 Received: from relay1.sgi.com ([192.48.171.29]:42340 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754791AbYBAKuB (ORCPT ); Fri, 1 Feb 2008 05:50:01 -0500 Date: Fri, 1 Feb 2008 04:49:59 -0600 From: Robin Holt To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com Subject: Re: [patch 2/4] mmu_notifier: Callbacks to invalidate address ranges Message-ID: <20080201104959.GJ26420@sgi.com> References: <20080201050439.009441434@sgi.com> <20080201050623.344041545@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080201050623.344041545@sgi.com> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 41 do_wp_page can reach the _end callout without passing the _begin callout. This prevents making the _end unles the _begin has also been made. Index: mmu_notifiers-cl-v5/mm/memory.c =================================================================== --- mmu_notifiers-cl-v5.orig/mm/memory.c 2008-02-01 04:44:03.000000000 -0600 +++ mmu_notifiers-cl-v5/mm/memory.c 2008-02-01 04:46:18.000000000 -0600 @@ -1564,7 +1564,7 @@ static int do_wp_page(struct mm_struct * { struct page *old_page, *new_page; pte_t entry; - int reuse = 0, ret = 0; + int reuse = 0, ret = 0, invalidate_started = 0; int page_mkwrite = 0; struct page *dirty_page = NULL; @@ -1649,6 +1649,8 @@ gotten: mmu_notifier(invalidate_range_begin, mm, address, address + PAGE_SIZE, 0); + invalidate_started = 1; + /* * Re-check the pte - we dropped the lock */ @@ -1687,7 +1689,8 @@ gotten: page_cache_release(old_page); unlock: pte_unmap_unlock(page_table, ptl); - mmu_notifier(invalidate_range_end, mm, + if (invalidate_started) + mmu_notifier(invalidate_range_end, mm, address, address + PAGE_SIZE, 0); if (dirty_page) { if (vma->vm_file) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/