Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp3328177lqo; Tue, 21 May 2024 13:38:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVehbU0B4k42hwFzSbKSTZA3oznvGFMlbJI3zzCOuZVAfYvjEQWAGfniqiNj41bb96Qrkb22h8xBzz7rW70RUWWMbd2ZYT+2orCnJm9XQ== X-Google-Smtp-Source: AGHT+IFyneDIQ6XGQ0IO9nCAwgmYa0gyvJGBWtRpDpSC2i++n4t0Uxb0/QoVgUUPUbvHcpExdFBj X-Received: by 2002:a17:906:7156:b0:a59:ad15:6142 with SMTP id a640c23a62f3a-a5a2d6bc0b4mr2090450266b.77.1716323881600; Tue, 21 May 2024 13:38:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716323881; cv=pass; d=google.com; s=arc-20160816; b=ruqaQwIJ5sEFKzyNuj7zdBhgX0TAn59cbE7C4DB539bgnqLUzaY8mHazfGgQuDJ8+0 MdehLJJ9ndyMRlKZCpg9Zltyy4IdZEXee8yPyHP5uiGB4m23is1n+jmKyuRoQHs2mTqw ydXs1tP+v2xBFTWqEWjJrm9etp50pWU6BhSErpmitib4nH4Egk1sSBgqD2JxksBsJI30 5QqUrCJCgm09bWOWwqfxeMLitoZypSo5Rb6u+5sz7n0EzjNiIcS/CTJg0hkjhElmpmM/ L53Lf1jkco/UFe+wYL7Nfrq1YIxMUfie6cook963qQaIAhdjEeLD8tmRzQgNlOngutE5 5+1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9NLbNUDlzC2jcO08AefJjvDOuFA0wNb9S8kYwaE3wt4=; fh=XynUPPO8v5WEDRuxYGneR8oX2p4KPgxX2CCIN1fh6Aw=; b=WOoeCcc/Du3QZDE7hKnjmmpEjwhwf36I+2x/C72oh+z8HCGN94XrToZEp1LB3M6R16 6JuolIwNVDXixw4iU4yE0TrsFBByyijPX3qkJGxe/ZeKcWpyKomZtGcfZVgf4AT2FOJ6 Vs2cDY/86eVoss9nvmLEMxgtyWnoWa8H28hP/rMLJ7DXrg2lR6QidZiN92FTdd88ns4u K0kpgOeENV3hr6Kni4yl3+L1UV3sQru6BgKG/zZRYrXIx8/E7VI8SEPq4PttQV5DxpXq PrJpT81VY2GTOYNHc39RBnqrlUZ5MEu+B4vI5uQTVq4jdR6rFj3plFoUnRh04oR0NK4P ho8w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bk0XI5tv; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-185423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17be63d2si1437556666b.717.2024.05.21.13.38.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 13:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bk0XI5tv; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-185423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 229E21F22C43 for ; Tue, 21 May 2024 20:38:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E81F149C4E; Tue, 21 May 2024 20:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="bk0XI5tv" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA248208D0; Tue, 21 May 2024 20:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716323868; cv=none; b=e8tXNBvi6rKRTHIZfp4aYZibK6PJW/dGJhGCqj8kJKurqY29pHaL0hsJbqdw3SJML2X7UopvNoUD38UzabmOWRy6M3SFX97Ov2n/6ukK2pxCN3l+I1XH1npNTxyIZPc10I+MjtD4u/5NVF/afe/RaFrSXaX2BtPUbI13cB1O1n4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716323868; c=relaxed/simple; bh=B9ViOYqXgDpQjV19AK5VUQQ4TV/W0LZcZ1p/e/v3QyU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aTZqcmQBJ1+fXpZRHge+3YXpSDZGCQ6l6pt7p/QyVV0o2Pgp9/FeM7Z5bSTVdqNjIWI2E4uUy2BZ4fUOPcel6ZlmKQO2sKebjvALzN2WbUcs1H0yGsEHWNqTiMqiwzv1m+hW+U6aspEjQ5nxBXZ16Otq9B9BQM5mV/aW/aswjPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=bk0XI5tv; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9NLbNUDlzC2jcO08AefJjvDOuFA0wNb9S8kYwaE3wt4=; b=bk0XI5tv5egsQIv1BwYpYtr4T4 62h+8SAf9m3BGEYEmvolS+Ux2TyeGE7hvRr8FslC7hEgdYQkkmzsWGi6JPeEI6OjFd5MZxwfuqg2r 75fvqdxUc765PwSoAXJ2yZ+0OALvTGlPTz+0J5/mw0uX/e7C954wnI9xFM2YlUFhBW4s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s9WEn-00Fmf6-2T; Tue, 21 May 2024 22:37:33 +0200 Date: Tue, 21 May 2024 22:37:33 +0200 From: Andrew Lunn To: Gregor Herburger Cc: Marc Kleine-Budde , Manivannan Sadhasivam , Thomas Kopp , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux@ew.tq-group.com Subject: Re: [PATCH v3 7/8] can: mcp251xfd: add gpio functionality Message-ID: References: <20240521-mcp251xfd-gpio-feature-v3-0-7f829fefefc2@ew.tq-group.com> <20240521-mcp251xfd-gpio-feature-v3-7-7f829fefefc2@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521-mcp251xfd-gpio-feature-v3-7-7f829fefefc2@ew.tq-group.com> On Tue, May 21, 2024 at 03:04:57PM +0200, Gregor Herburger wrote: > The mcp251xfd devices allow two pins to be configured as gpio. Add this > functionality to driver. I have a basic understanding of GPIO drivers, which is probably more than average for netdev reviewers. This code looks O.K. to me, but i would prefer you run it by the GPIO maintainers, since that is there domain of expertise. I don't think any are in Cc: Andrew --- pw-bot: cr