Received-SPF: pass (google.com: domain of linux-kernel+bounces-185436-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <df7b1dff-49da-4b1b-b230-f36a5a591c9f@amd.com>
Date: Tue, 21 May 2024 15:50:44 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 0/3] platform/x86: dell: Implement platform_profile
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: pali@kernel.org, W_Armin@gmx.de, srinivas.pandruvada@linux.intel.com,
 ilpo.jarvinen@linux.intel.com, lkp@intel.com, hdegoede@redhat.com,
 Yijun.Shen@dell.com, Matthew Garrett <mjg59@srcf.ucam.org>,
 Vegard Nossum <vegard.nossum@oracle.com>,
 Randy Dunlap <rdunlap@infradead.org>, Jonathan Corbet <corbet@lwn.net>,
 Heiner Kallweit <hkallweit1@gmail.com>, linux-kernel@vger.kernel.org,
 platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240517224323.10045-1-lsanche@lyndeno.ca>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240517224323.10045-1-lsanche@lyndeno.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkZzVHJCcnNNaVNJeUFKSms5bThQS3ZWbnJ0YXpjc2cyYVplczRsdXFmZkJH?=
 =?utf-8?B?L2syY3B0R2pjVEFBK1ZpN0x5d3NTT0h4TUlISDlKWmowZDM1dnBvK2VTZ3Fk?=
 =?utf-8?B?OENOSlhmYk1hLzFLSGloai94VHF3ZmJsajI2bnBOQytESlRvL1lDY1VHZFVL?=
 =?utf-8?B?bkJSZUVTQ2FmemJGVHRUeFRhd2piaXVLZ2tOUEYwNGt2aVhvbFNSbGs3NjhF?=
 =?utf-8?B?WVFZa3BtQms0eXljMzcrYytLZnFxRVQ2eitrNzJEUmdzUTE5aDgrK3FZaGlF?=
 =?utf-8?B?ODArNFR0dGVKUGg5KzVwWGhPeDB4dnIyTVVtYTlGcHFKcDQ5WUIxMWUvVW9F?=
 =?utf-8?B?V3IwbkQ2amx5YXFmOEVmS2FTWHhDS1U0ZzQ0ckRTMmtuTUZ5N2lXK2orcVBO?=
 =?utf-8?B?OG1uSzFna3VtZ3owWGxBWXhKUDdRcHF0aHJNL0VMcW1VL0w2Z0w3NlBnWjgx?=
 =?utf-8?B?TEh1czNIZTBkOERTTFdVQW9Yc2pCeVlsOGpEU0JFc2FoZUZIU3oyZVgxeitF?=
 =?utf-8?B?TE9UMC8yRS9ocGgySFdkTHRYWFl1RHBmYm5adXluSExIbisyNUsvS2ZmUXNK?=
 =?utf-8?B?NFhvMXRXTkdCaUFQSVZ2Mk15M0g5VXM2d29tbFpXTk4vTU42V0dUa1FXakNz?=
 =?utf-8?B?UEs4YUg2bTRSSWdzb0JVYWhsdkxVVm9NR1lKdHB1d3puU2dsTzZzTjJhMmxm?=
 =?utf-8?B?c1drNkx0QUcrRjNubk5GT2R4QkxxMjAvbmpvaXd1T1BQNFlxZ0ZMblBmMGRu?=
 =?utf-8?B?Mm9lTk1DTTNVa2UxQ0s5ZUw1cjRISEI4bVNKVnY3WWlwNU5QRHdwZ2xhLzRp?=
 =?utf-8?B?V1hicnBTSVArMERrdkNkV3BJUUFFOFVnUHRRVk9yem9FRTc3NnhleEtlMzN6?=
 =?utf-8?B?REN1TXRBb2Q5SGNiNk9tcEpWV1EwMFR5ZkNDKzk4WFMyVzc4dCsydUxzUW5k?=
 =?utf-8?B?d1ZtaVFzdXB5Vmw2NnBDNGxubXQ3a1d2elZTLzQyZDNuUkdiUzRHRHdOQW92?=
 =?utf-8?B?NS8zQzlyU3oreE53bkJ6RXFkTjBHa0RqQ2lUbmNkaTk3OWxaQmh2N052WGtC?=
 =?utf-8?B?UzhjZ2U3dUVuS3BLUGZpd2c0SGhtSzBqeGhNYytsd1hMV1pjbUFTS0xkRis3?=
 =?utf-8?B?cDljZkhiN3JVZXJKWjFlM09IMW9uZnU4TTkwRTN5UUFOQktMSGRrZjl6RkhD?=
 =?utf-8?B?UXczdDAwYnI4Tld5bU9teUNmcTdkSmZUOTRaYTRkM1h4SkxrNVJ5Ykx5VTB4?=
 =?utf-8?B?Zzk3WDE0dzNoUDRMQ0tBWFg2L25GSWZFWHhqSEh1SlRhVUxWZU9vdTBYNFZJ?=
 =?utf-8?B?R2F4Qml3ZCtaVTBlNnNyVXh1NGw1dmo5SmZmczJKMzVZbDBFWGNkRHRZTEdq?=
 =?utf-8?B?Vk9pbG53bVJsc0tPYXBMS2pkSXcxSU5sZjhHcTFqbmxCMUpKVEhwQkw5MFJH?=
 =?utf-8?B?c2VxL3VCRVNGSnZCQUdLaU9oVkVZM21IRUYwUG8zUm1QY2RWWERYZU52dk1N?=
 =?utf-8?B?WjlrY241M2VReGJpN2NkUW5EbEEwcUZncFlFb09sb2JKZU1MdTNONHNrbisv?=
 =?utf-8?B?dTdWTTY5ZDR2QzU2bW9oZ1ZXbUVBaTM4NXdQUmlEc0pHazFjeGJpS3V5amd2?=
 =?utf-8?B?QWRlZEpaQkYxVVRMOHNjUGxkR3FzWDNKVkYrbi9LZXNhcGhOcE5HL2ZibWp0?=
 =?utf-8?B?aThpSG9yUW5nTk9GY0t1VFlmaDJxMVpwSU05YW1hMWVkckhxMjdlRmlHNjlj?=
 =?utf-8?B?dDBVQ1o0cXBPQWlUdFhaWTBjUUI2SXBQeVZLaXFOWEh1L0lVUVdxYVhRV0lP?=
 =?utf-8?B?QnJYTEFvZDZiTFJYVm8vQ2NncDY3ZzF2ZVZVd2NyOUxrWENZcms5VlhkeWVH?=
 =?utf-8?B?NERLZjFqcmI2cEM1UGJTYVN2RkE0Y211dXZSNG93VlhBUythL3piWnVSbnhk?=
 =?utf-8?B?QlhHU3Z5K2RYZWZKdUNlSDE3Z05uMStzQ210SDlLOFFaTTN5Ni80TXdLSEZN?=
 =?utf-8?B?OW8rOUg4VmFiNmY0ZWo2VHgyc0YyYWVxN253WDBtbnV1UzlrNjJwRzd4OXVa?=
 =?utf-8?B?a2xFUmlzMUx3blRVbkx5amttK0Rwb0lDNzN4SW1sRjA0UXBrNWtqTFA1SVRn?=
 =?utf-8?Q?uZH0yXBl1ipqXWjd14/WJTE+m?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37db0058-3066-4821-999c-08dc79d7b17f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 20:50:48.4499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jhh6z4Ozisi2Ov1QHOrCQUHzz5Slw7eWnZhBexsJegIUubf8QC983ljdTpt8JwmZW20iWhThoBaIufXAW1AqrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6834

On 5/17/2024 17:42, Lyndon Sanche wrote:
> v7:
>   - Move platform_profile into new dell-pc module
>   - Add myself as maintainer of dell-pc
>   - Move smbios call and fill functions to dell-smbios-base
>   - Check for classes above 30 and return as not supported
>   - Rename dell_laptop_check_supported_cmds to
> 	 dell_smbios_class_is_supported
>   - Check for ENXIO and treat as no thermal modes supported
> v6:
>   - Add ACPI dependency for dell-laptop
>   - Add and use helper symbol for checking supported commands
> v5:
>   - Fix indent in smbios-thermal-ctl comment
>   - Remove linux/wmi.h include
>   - Add 'select ACPI_PLATFORM_PROFILE' to Dell KConfig
> v4:
>   - Make thermal_init and thermal_cleanup static
>   - Rearrange order of added includes, did not edit current includes
>   - Include bits.h
>   - Switch comment style
>   - Return error if platform_profile registering failed
>   - Add thermal calls to call_blacklist
>   - Align defines with tabs
>   - Correct separation of function and error handling
>   - Propagate error codes up
> v3:
>   - Convert smbios-thermal-ctl docs to multiline comment and wrap
>   - Change thermal_mode_bits enum to directly be BIT() values
> 	- Convert related code to use this
>   - Use FIELD_GET/PREP and GENNMASK for getting/setting thermal modes
> 	- Correct offset for getting current ACC mode, setting offset
> 		unchanged
>   - Check if thermal_handler is allocated before freeing and
> 	 unregistering platform_profile
> v2:
>   - Wrap smbios-thermal-ctl comment
>   - Return proper error code when invalid state returned
>   - Simplify platform_profile_get returns
>   - Propogate ENOMEM error
> 
> Lyndon Sanche (3):
>    platform/x86: dell-smbios: Add helper for checking supported class
>    platform/x86: dell-smbios: Move request functions for reuse
>    platform/x86: dell-pc: Implement platform_profile
> 
>   MAINTAINERS                                  |   6 +
>   drivers/platform/x86/dell/Kconfig            |  13 +
>   drivers/platform/x86/dell/Makefile           |   1 +
>   drivers/platform/x86/dell/dell-laptop.c      |  23 --
>   drivers/platform/x86/dell/dell-pc.c          | 310 +++++++++++++++++++
>   drivers/platform/x86/dell/dell-smbios-base.c |  35 +++
>   drivers/platform/x86/dell/dell-smbios.h      |   7 +
>   7 files changed, 372 insertions(+), 23 deletions(-)
>   create mode 100644 drivers/platform/x86/dell/dell-pc.c
> 

Series looks good to me, thanks.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>