Received-SPF: pass (google.com: domain of linux-kernel+bounces-185442-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <86410711-9b88-448c-9148-109f81b1ca55@amd.com>
Date: Tue, 21 May 2024 15:55:34 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs
To: =?UTF-8?Q?Rino_Andr=C3=A9_Johnsen?= <rinoandrejohnsen@gmail.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc: alexander.deucher@amd.com, Harry Wentland <harry.wentland@amd.com>,
 Leo Li <sunpeng.li@amd.com>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Aurabindo Pillai
 <aurabindo.pillai@amd.com>, Hersen Wu <hersenxs.wu@amd.com>,
 Hamza Mahfooz <hamza.mahfooz@amd.com>, Wayne Lin <wayne.lin@amd.com>,
 Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
 Fangzhi Zuo <jerry.zuo@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
 Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <fa885eca-d7e6-415a-8a08-9103b002c6bb@amd.com>
 <20240521051140.30509-1-rinoandrejohnsen@gmail.com>
 <17782a6e-db84-4c20-874a-342b9655ffc5@amd.com>
 <CAACkh=-B-jH6g7KY7Nn_7Y_+gHPQ7G5Z5AZ0=a=_ifjcmsorcw@mail.gmail.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <CAACkh=-B-jH6g7KY7Nn_7Y_+gHPQ7G5Z5AZ0=a=_ifjcmsorcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YU94Y09rajRBSll5Y0RpMThXTGorUzVrTGtHSm5hQkIxS0N3NVQyTTZsdG10?=
 =?utf-8?B?anh6bTJ4MzB4NVNCTW04WXZ5Mm5vQkRhNU9ia3djK244K1MyNFVaek1ObzNx?=
 =?utf-8?B?bnNFenpwZ2lLTnhzK2dmY3c0K0QwY3NrRFBLSENOaktIMHRHQ1hEdHBFcWhH?=
 =?utf-8?B?ZzU1UFV6ZHNLN0Y4OTJ6dFdOTjV4UFltckJLL1RFMW9qNnB5Q3NBQmt6OUFO?=
 =?utf-8?B?RlNCREs4aGQyVWVZdXdSUFh2R2s2SkZkQVJ0QStzY2ZlOW13WUJwRmR0bWdl?=
 =?utf-8?B?UURIZDdtT3N1UG1POEd0ZVhZZGNSK21OV0VlZC9rTEg2YTJ4SXNCQnFsd25E?=
 =?utf-8?B?RTIvamdMY3VlU09VVkRYa0FYSGw2VUFBMzVUUWFVc2x5NmhLYyszazEwMmEw?=
 =?utf-8?B?UzRvd3B1bkhzcm9RdzBuVVltNXBRYnBUZGVVbW96cVZjMnpKZFc4WGt4eGtn?=
 =?utf-8?B?ZWhhZGxjQWU5djBuY2t3MVg5WGVSVDNPTkNqb25udmI5eTlGSFVCc2J4aHVp?=
 =?utf-8?B?WVYrRGE4T3JrbzNENEJoNUQwMTdvb2dRUTRMeFZoY2Z5WmdKalZ2NnVBMG91?=
 =?utf-8?B?V0t6cWI4Q2JPRmVnaEI2czc4MTlnSW4xK01scXRDYVV3T1B0di8vQXhucFZG?=
 =?utf-8?B?UzJldUV0NEwrdjNsanVtb2dBbkhXV25SL3Z2V01IcmV1OGprbnhQb2VmMlhs?=
 =?utf-8?B?WTYvU0QrZGJjSUY5ZnlNdmh2bHJWNXVrVXlFME5md3FjU2JaQkoxNVpicmdO?=
 =?utf-8?B?TGJjeUFpWVByRFNOcEIxNlMrdTV4cjFJNDVNYTNubU1UKzRZUjROVGdhSkty?=
 =?utf-8?B?aEVOVlVNZi9taFY1d3MxRjFVWTQyYnl3Umh0blphVlEyMnUvV2s4cFF6T3BP?=
 =?utf-8?B?VWl4MFcxOEc4akp3NEw4K2JVVm1IcFFuZ3ZsdnhLUFZQeVZydUw1OTFXZFVm?=
 =?utf-8?B?U0J0ZG5UWnJxU05JNzl1OXpxUVQrb1VCSXEwR25DY0J5SGFJT0VJbFRLam1J?=
 =?utf-8?B?UWZ2c0FIaUVEVWxmang1bHN0QXhjQzhIaHZ5U1RQUE11dTExTk5mc0dYQTEw?=
 =?utf-8?B?SzNYejJoY0IvekpXZC9ITVVEZ2hKZHlHL21vYVE0eDVjTGdocG95dzBxWHg3?=
 =?utf-8?B?amNCWWVCcjVUak1UaVFrRlNac3hZTkhac29VN2FsSkNMa24rWWtGSllLKytz?=
 =?utf-8?B?aTRxU2ovUmdXVVRaSTlTMkV0WGpRL0xtNDFVaFBjRUJ6NUI5bGZPbGsyMC9V?=
 =?utf-8?B?bDFoNEUzaDVUbFNKN1JqK0dXeU5WNVVtdDNRdjNQQnZSSUswMTJwNzUxTnAx?=
 =?utf-8?B?Q1Bhb1o5QlloQkl2c1hNWmtCN1ZSYys0V0x4VEQrRk01azhOanR0Q3Z1M1B0?=
 =?utf-8?B?R2pSc1BhQ3dTeFBwMk85ZDduVkQwZDJWL1VpOXpETXBFb1ZVc2VJZzgrMUti?=
 =?utf-8?B?MTdYQXBRZHBTaDMzQXVsTUxiTTlacE5ONURvdVpIQ0VxWGNGdCt2ck5UZGU0?=
 =?utf-8?B?aWdXMS9RUlRLTGg0VW5YZE1DZktJdzc5c2kwZkZXTG9kWTBmQXp3c2o2bVJu?=
 =?utf-8?B?M1U3WEVzb3hqUmtFWVhXWXJJYjYyYTBjR0FlN2JmM1EyVTBQd2xPSUxmWHBE?=
 =?utf-8?B?ck5EY1N5MkoxVHhWZGNCYWdqZDB5bUV6aWJQbVU4Mm9nSjhNSnArTkpKTm0z?=
 =?utf-8?B?U0YwUnR4UGNCWTdHNE9ETjdYN2xJRjlwYjVlKzlxRXlFbkE1VDRZTWRjTjYx?=
 =?utf-8?B?cmJWY0tqeXFHYVhXUmhvZDVJSVZGd1F6Rnd4U1JJN3I1N0liZ2NZeEVBbmow?=
 =?utf-8?B?RElmZDJUNU9kVWFsUUlpZngvNU5FMWlVVEZTYWlQQzU2NkxUY0tGYVVSaXBm?=
 =?utf-8?B?cXkzZVhGOTJ4MEkvZVluU0VqR24xb3R1b0dWSjdIcjh5R0tUNmRob2d1U0pt?=
 =?utf-8?B?TGxnZjNXN29vWWFBTTNONDdKZXpBMjcwNnU3VENTMkcyVWVwWXd2d1FMWTVV?=
 =?utf-8?B?ZHY0aDZYTjRNeWdadStxaWtuUVZzcC92VVpwaDFZS1hCTDZQbW12eUk1KzdT?=
 =?utf-8?B?c0FiM08vU09JQkx1WkM2U2V1SWVkWEtjWnYyb2grZWIyOExlV09hSWR1VUlX?=
 =?utf-8?Q?lnnSjnlyKiWeRsNRwmQUaNIST?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc825d0b-dc1e-4438-2b25-08dc79d85e2b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 20:55:38.1554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9damzV22SyGcmymWHphXOz8FcHfkFRVi7Ftoe+Nss9Y1qix/lebndvDaZwL7kOL8Zjw+3PxWSOi0TZoJKxezEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4190

On 5/21/2024 15:06, Rino André Johnsen wrote:
> What is already there in debugfs is 'bpc' and 'colorspace', but not
> the pixel encoding/format.
> I have searched high and low for that to be able to verify that my
> monitor and computer are using my preferred combination of all those
> three values.
> 
> I do think it should be available as a standard DRM CRTC property, but
> for the time being, I figured that a simple debugfs property would be
> sufficient for time being.
> 

It's just about as much work either way to populate it though, why do it 
twice instead of just doing it right the first time?

> Rino
> 
> 
> On Tue, May 21, 2024 at 9:04 PM Christian König
> <christian.koenig@amd.com> wrote:
>>
>> Am 21.05.24 um 07:11 schrieb Rino Andre Johnsen:
>>> [Why]
>>> For debugging and testing purposes.
>>>
>>> [How]
>>> Create amdgpu_current_pixelencoding debugfs entry.
>>> Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding
>>
>> Why isn't that available as standard DRM CRTC property in either sysfs
>> or debugfs?
>>
>> I think the format specifiers should already be available somewhere there.
>>
>> Regards,
>> Christian.
>>
>>>
>>> Signed-off-by: Rino Andre Johnsen <rinoandrejohnsen@gmail.com>
>>> ---
>>>
>>> Changes in v2:
>>> 1. Do not initialize dm_crtc_state to NULL.
>>> ---
>>>    .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 47 +++++++++++++++++++
>>>    1 file changed, 47 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>> index 27d5c6077630..4254d4a4b56b 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>>> @@ -1160,6 +1160,51 @@ static int amdgpu_current_colorspace_show(struct seq_file *m, void *data)
>>>    }
>>>    DEFINE_SHOW_ATTRIBUTE(amdgpu_current_colorspace);
>>>
>>> +/*
>>> + * Returns the current pixelencoding for the crtc.
>>> + * Example usage: cat /sys/kernel/debug/dri/0/crtc-0/amdgpu_current_pixelencoding
>>> + */
>>> +static int amdgpu_current_pixelencoding_show(struct seq_file *m, void *data)
>>> +{
>>> +     struct drm_crtc *crtc = m->private;
>>> +     struct drm_device *dev = crtc->dev;
>>> +     struct dm_crtc_state *dm_crtc_state;
>>> +     int res = -ENODEV;
>>> +
>>> +     mutex_lock(&dev->mode_config.mutex);
>>> +     drm_modeset_lock(&crtc->mutex, NULL);
>>> +     if (crtc->state == NULL)
>>> +             goto unlock;
>>> +
>>> +     dm_crtc_state = to_dm_crtc_state(crtc->state);
>>> +     if (dm_crtc_state->stream == NULL)
>>> +             goto unlock;
>>> +
>>> +     switch (dm_crtc_state->stream->timing.pixel_encoding) {
>>> +     case PIXEL_ENCODING_RGB:
>>> +             seq_puts(m, "RGB");
>>> +             break;
>>> +     case PIXEL_ENCODING_YCBCR422:
>>> +             seq_puts(m, "YCBCR422");
>>> +             break;
>>> +     case PIXEL_ENCODING_YCBCR444:
>>> +             seq_puts(m, "YCBCR444");
>>> +             break;
>>> +     case PIXEL_ENCODING_YCBCR420:
>>> +             seq_puts(m, "YCBCR420");
>>> +             break;
>>> +     default:
>>> +             goto unlock;
>>> +     }
>>> +     res = 0;
>>> +
>>> +unlock:
>>> +     drm_modeset_unlock(&crtc->mutex);
>>> +     mutex_unlock(&dev->mode_config.mutex);
>>> +
>>> +     return res;
>>> +}
>>> +DEFINE_SHOW_ATTRIBUTE(amdgpu_current_pixelencoding);
>>>
>>>    /*
>>>     * Example usage:
>>> @@ -3688,6 +3733,8 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
>>>                            crtc, &amdgpu_current_bpc_fops);
>>>        debugfs_create_file("amdgpu_current_colorspace", 0644, crtc->debugfs_entry,
>>>                            crtc, &amdgpu_current_colorspace_fops);
>>> +     debugfs_create_file("amdgpu_current_pixelencoding", 0644, crtc->debugfs_entry,
>>> +                         crtc, &amdgpu_current_pixelencoding_fops);
>>>    }
>>>
>>>    /*
>>