Received-SPF: pass (google.com: domain of linux-kernel+bounces-185756-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240521005649.12144-1-xndchn@gmail.com> <20240522010559.10551-1-xndchn@gmail.com>
 <20240521194010043-0700.eberman@hu-eberman-lv.qualcomm.com>
In-Reply-To: <20240521194010043-0700.eberman@hu-eberman-lv.qualcomm.com>
From: xndcn <xndchn@gmail.com>
Date: Wed, 22 May 2024 12:10:25 +0800
Message-ID: <CAJ=gGT1Ojxe3vLNVAoXHO4j1_-71YafRXkVkd34Oqyzs9r3VwQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/decode_stacktrace.sh: better support to ARM32
 module stack trace
To: Elliot Berman <quic_eberman@quicinc.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, 
	quic_bjorande@quicinc.com, cmllamas@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks, I'll split it into 2 patches later.

> Your change is to strip any leading/trailing characters before/after the =
[ / ] respectively?
Yes, exactly.

> Isn't this a problem for $symbol as well
there is already a strip logic in "parse_symbol()", which seems
introduced by #e260fe01, also for ARM.
> # Remove the englobing parenthesis
> symbol=3D${symbol#\(}
> symbol=3D${symbol%\)}

On Wed, May 22, 2024 at 10:48=E2=80=AFAM Elliot Berman <quic_eberman@quicin=
c.com> wrote:
>
> On Wed, May 22, 2024 at 09:05:59AM +0800, Xiong Nandi wrote:
> > Sorry about the name, it is some kind of abbreviation. So I re-post her=
e:
> > ---
> > Since System.map is generated by cross-compile nm tool, we should use i=
t
> > here too. Otherwise host nm may not recognize thumb2 function address w=
ell.
> >
> > Beside, sometimes special characters around module name, such as ARM32
> > with BACKTRACE_VERBOSE in "(%pS)" format, such as:
> > [<806e4845>] (dump_stack_lvl) from [<7f806013>] (hello_init+0x13/0x1000=
 [test])
> >
> > After stripping other characters around "[module]", it can be finally d=
ecoded:
> > (dump_stack_lvl) from hello_init (/foo/test.c:10) test
> >
> > Signed-off-by: Xiong Nandi <xndchn@gmail.com>
> > ---
> >  scripts/decode_stacktrace.sh | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.s=
h
> > index fa5be6f57b00..324e4a6c260a 100755
> > --- a/scripts/decode_stacktrace.sh
> > +++ b/scripts/decode_stacktrace.sh
> > @@ -30,6 +30,7 @@ fi
> >
> >  READELF=3D${UTIL_PREFIX}readelf${UTIL_SUFFIX}
> >  ADDR2LINE=3D${UTIL_PREFIX}addr2line${UTIL_SUFFIX}
> > +NM=3D${UTIL_PREFIX}nm${UTIL_SUFFIX}
> >
> >  if [[ $1 =3D=3D "-r" ]] ; then
> >       vmlinux=3D""
> > @@ -158,7 +159,7 @@ parse_symbol() {
> >       if [[ $aarray_support =3D=3D true && "${cache[$module,$name]+isse=
t}" =3D=3D "isset" ]]; then
> >               local base_addr=3D${cache[$module,$name]}
> >       else
> > -             local base_addr=3D$(nm "$objfile" 2>/dev/null | awk '$3 =
=3D=3D "'$name'" && ($2 =3D=3D "t" || $2 =3D=3D "T") {print $1; exit}')
> > +             local base_addr=3D$(${NM} "$objfile" 2>/dev/null | awk '$=
3 =3D=3D "'$name'" && ($2 =3D=3D "t" || $2 =3D=3D "T") {print $1; exit}')
>
> The nm parts should be a separate patch.
>
> >               if [[ $base_addr =3D=3D "" ]] ; then
> >                       # address not found
> >                       return
> > @@ -282,8 +283,8 @@ handle_line() {
> >
> >       if [[ ${words[$last]} =3D~ \[([^]]+)\] ]]; then
> >               module=3D${words[$last]}
> > -             module=3D${module#\[}
> > -             module=3D${module%\]}
> > +             module=3D${module#*\[}
> > +             module=3D${module%\]*}
>
> I need to get a moment to play with it. Is my understanding correct that
> the problem is that the last word ($module) is:
>
> [test])
>
> and after the existing strip logic, $module becomes test]) whereas
> expecting just "test"? Your change is to strip any leading/trailing
> characters before/after the [ / ] respectively? Isn't this a problem for
> $symbol as well -- it would be "(hello_init+0x13/0x1000" in the example.
>
> - Elliot
>
> >               modbuildid=3D${module#* }
> >               module=3D${module% *}
> >               if [[ $modbuildid =3D=3D $module ]]; then
> > --
> > 2.25.1
> >