Received-SPF: pass (google.com: domain of linux-kernel+bounces-185795-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d543ac68-346a-4439-8f29-ceb7aa1b3b50@amd.com>
Date: Wed, 22 May 2024 11:41:38 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] KVM: SEV-ES: Don't intercept MSR_IA32_DEBUGCTLMSR for
 SEV-ES guests
To: Paolo Bonzini <pbonzini@redhat.com>,
 Sean Christopherson <seanjc@google.com>
Cc: thomas.lendacky@amd.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 michael.roth@amd.com, nikunj.dadhania@amd.com, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org, santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20240416050338.517-1-ravi.bangoria@amd.com>
 <ZjQnFO9Pf4OLZdLU@google.com> <9252b68e-2b6a-6173-2e13-20154903097d@amd.com>
 <Zjp8AIorXJ-TEZP0@google.com> <305b84aa-3897-40f4-873b-dc512a2da61f@amd.com>
 <ZkdqW8JGCrUUO3RA@google.com> <b66ea07a-f57e-014c-68b4-729f893c2fbd@amd.com>
 <Zk0ErRQt3XH7xK6O@google.com>
 <CABgObfaXAERePMQrrpWg8PqM1TOq8TJT65i3WgU0n0-vePDGNg@mail.gmail.com>
Content-Language: en-US
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CABgObfaXAERePMQrrpWg8PqM1TOq8TJT65i3WgU0n0-vePDGNg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Ykl4ZlIvVisyQjRoSisza3lSUFdjcWlKbng0S2VOYWJpZUwzbE9LUlpUbkRO?=
 =?utf-8?B?WWkvTXFuV2hQRGJ2NG1CdGdCeHdPL3pTMkN1RTZzVlZrSVB2MjYyc2FrMzRk?=
 =?utf-8?B?VUk5TjQ1VnZsZzN1VENFRmhhbmZMbFYwSjRwS3pLSEVDNnZxSGRBUlNLK0R6?=
 =?utf-8?B?ME5JWlFlS28zL2dnRHllRk14akhpa0h5dUdMRFBBZHE1dWp5R3pXRWJRb3NG?=
 =?utf-8?B?bVF6aFdNT3MrdmtRcTlkRmtKMkQ1UU1vQVRrZGJjeU5BSS95T0VMcXpqcXZJ?=
 =?utf-8?B?MGxKQmIwM1VpSFQveGt1OWkwV2pvcGp6d1JoQWkyME53MGN0VWdvQ1prZDlN?=
 =?utf-8?B?eE13b2NSSlFvSjhDNTFXZW1OSFhGSU9kd2EyeW94RVNtQ3g3TjdaeUxZcXZT?=
 =?utf-8?B?R1F1WmE2OU91cys1NWFRam93Wlg3cE5sdC9wei9XVC9aQWhwMGdaVUpqUUtr?=
 =?utf-8?B?amI1UzB2RmFnc05YM2ZSanM4c0hIMllWNEE3Ui9VcW1rcFp0Zjh4OUVCTWcx?=
 =?utf-8?B?RnRVWUZhTHpaQUk4a0hYSHRIZ2piWGlhNC9NVytrWmVwdFdWcjNQUUN4THA0?=
 =?utf-8?B?ZWtPWnM0Ynp3VXNZOTEzNTZmYnpEVVIrbWQyNkVuMkE2YjNpTjVseWlKUGxn?=
 =?utf-8?B?NWx6NVUzdm14VjM4cE8rckNCazZxSWJ5ZUphZ3NZQmlNM0RvS3pnMjNwZVN6?=
 =?utf-8?B?a05PMGZHMW1sdE43cHdsTm9qdTBqWUt0ZkZCSGMwdldLWk1wWlhsOXpQeHpt?=
 =?utf-8?B?T1lzc0hIY1RHSjFPSHVqcjNqNnpvS00xWkNHMVRKbkJGWGJabW5tbithbnhi?=
 =?utf-8?B?bGYyVGgxZlo1clJhOGFtc2tHOWhQV3N4WEFsdUN3K1pjNUhTcmNGK2ZMLzZC?=
 =?utf-8?B?T2lXQzNCcHZEMVl2RDlKcVQ3MnRzT0ZmOWo3dGJkWmMyN2YrRi9Hc3l1czlX?=
 =?utf-8?B?djJNNm9PSlhUUXVqUldxd2hSRUlaRWxxZ01sNUR2T1NJcHlrcnRkc1N3VVY5?=
 =?utf-8?B?b0lMYWFkblZPKzU1d000ZU1nam95bzM0d29ldVFrL2ErakRYSHlCd2Y2TlpD?=
 =?utf-8?B?czE4cGZJbTE4M21JTmM1ZkY5LzZPTFBveU1lYXVJYzZlNVF2Y244bDJvUjV2?=
 =?utf-8?B?S2ZyU1gwaW9TMUFKN0hQQVB1Y0ZzV1BXak10Wm5lRlEyMnFVVTdQMmtHYUNV?=
 =?utf-8?B?bFB4cGx2WVdMeHJ4NnMwTWpCY2wvWlByVnRlOFdBYjM1dFd1M3RnWWJSV1Rr?=
 =?utf-8?B?bVBZbmdaenFlVXcybDBxbnNUajMxb1lWb3hRTk15Ry9aQ2VvZzNGMUJNUUMv?=
 =?utf-8?B?REI2citDVUtWKzJRT3ZBZUtGWS83VXhEbWNqdTZRT0o3cGFGV0NTc1k2Nytn?=
 =?utf-8?B?eHE2eUJWTDc2M3h1MzVJbGR3dkZabHVWQlA4NHE4UWVzUnI5TUNhVjFQZ3ZX?=
 =?utf-8?B?bkYxQkp2dGtJSFJieVI4MUFEbjFvakErcG5naEsrRmthWDFJcHJuWmZFL3F5?=
 =?utf-8?B?Y1NOenJ6M1Vlbko3dnhTaGYwbUt5dDhreFpIQmJhUHNjMnpJUnBmNWJrb2R3?=
 =?utf-8?B?SU9hV1JsVjc4TkFlVFZvVG1mUUJZcmlpZG5pTVU3V2FFNUhWdkoxcm9RRmo4?=
 =?utf-8?B?eEdIRzgzTHh6QUwxMjZLMVFvbWRMRDlIL0dibVQ2cmZDdndpL3B2Lyt5YSto?=
 =?utf-8?B?OUpOVVpXVWFGWjQvaUlMLzB5cDQ1Mm5qaDgyN2RXZ3dqT2kzS1Rqenk3T3Ru?=
 =?utf-8?B?TVJtT3YyQXZjeEI1U3ROU0Fya3dmSEQ0dXBJSmhuYTFzdURoeGNSaHVVTTEz?=
 =?utf-8?B?K0lJSGRkYmpMZDFRQ0paenROVTdtenpQU2FQWVZ1WmFmc1RyS2JBcmpiWEda?=
 =?utf-8?B?WFpJc2tRTlc3anF0TXV4aktPYnBHdGlrYjVPd1o5d21VeWtPZGRqREhUVnND?=
 =?utf-8?B?cWRzL05EdVhIRU9vUjlxRUpjdm1hT1dyUXh5K1JlSk01aHUzdzRZNU9jenA1?=
 =?utf-8?B?ZGJONUxvdW13cFFPOGhxYjQ5VVEwb2hIS1VEd3U2Y0QyKzcwTHZlUUlZVlh6?=
 =?utf-8?B?Z0ZZTnZuSGlISHRDaDQxSkgxVlA2UU5NOHU3blVJOS82Zk5TcVR1ZEJXRTh3?=
 =?utf-8?Q?udIrI4zOt/WYsB9/JmllRljVB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d5a532a-0c10-4444-e9af-08dc7a261118
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 06:11:49.7250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WSBuOa7Sp6BJPm3fWwuOtlGylTs+XhZCCALKAh6lOIr1IEOJtXwANHKOudqTMd0EI6xER/e4zYt/BGSAIIUJbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6177

On 5/22/2024 2:17 AM, Paolo Bonzini wrote:
> On Tue, May 21, 2024 at 10:31 PM Sean Christopherson <seanjc@google.com> wrote:
>>
>> On Mon, May 20, 2024, Ravi Bangoria wrote:
>>> On 17-May-24 8:01 PM, Sean Christopherson wrote:
>>>> On Fri, May 17, 2024, Ravi Bangoria wrote:
>>>>> On 08-May-24 12:37 AM, Sean Christopherson wrote:
>>>>>> So unless I'm missing something, the only reason to ever disable LBRV would be
>>>>>> for performance reasons.  Indeed the original commits more or less says as much:
>>>>>>
>>>>>>   commit 24e09cbf480a72f9c952af4ca77b159503dca44b
>>>>>>   Author:     Joerg Roedel <joerg.roedel@amd.com>
>>>>>>   AuthorDate: Wed Feb 13 18:58:47 2008 +0100
>>>>>>
>>>>>>     KVM: SVM: enable LBR virtualization
>>>>>>
>>>>>>     This patch implements the Last Branch Record Virtualization (LBRV) feature of
>>>>>>     the AMD Barcelona and Phenom processors into the kvm-amd module. It will only
>>>>>>     be enabled if the guest enables last branch recording in the DEBUG_CTL MSR. So
>>>>>>     there is no increased world switch overhead when the guest doesn't use these
>>>>>>     MSRs.
>>>>>>
>>>>>> but what it _doesn't_ say is what the world switch overhead is when LBRV is
>>>>>> enabled.  If the overhead is small, e.g. 20 cycles?, then I see no reason to
>>>>>> keep the dynamically toggling.
>>>>>>
>>>>>> And if we ditch the dynamic toggling, then this patch is unnecessary to fix the
>>>>>> LBRV issue.  It _is_ necessary to actually let the guest use the LBRs, but that's
>>>>>> a wildly different changelog and justification.
>>>>>
>>>>> The overhead might be less for legacy LBR. But upcoming hw also supports
>>>>> LBR Stack Virtualization[1]. LBR Stack has total 34 MSRs (two control and
>>>>> 16*2 stack). Also, Legacy and Stack LBR virtualization both are controlled
>>>>> through the same VMCB bit. So I think I still need to keep the dynamic
>>>>> toggling for LBR Stack virtualization.
>>>>
>>>> Please get performance number so that we can make an informed decision.  I don't
>>>> want to carry complexity because we _think_ the overhead would be too high.
>>>
>>> LBR Virtualization overhead for guest entry + exit roundtrip is ~450 cycles* on
>>
>> Ouch.  Just to clearify, that's for LBR Stack Virtualization, correct?
> 
> And they are all in the VMSA, triggered by LBR_CTL_ENABLE_MASK, for
> non SEV-ES guests?

Not sure I follow. LBR_CTL_ENABLE_MASK works same for all types of guests.
Just that, it's mandatory for SEV-ES guests and optional for SVM and SEV
guests.

Thanks,
Ravi