Date: Fri, 1 Feb 2008 13:13:31 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: torvalds@linux-foundation.org, gerg@uclinux.org,
       linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: platform setup for 520x ColdFire parts
Message-ID: <20080201121331.GA12815@uranus.ravnborg.org>
References: <200802010734.m117YAx4022578@goober> <20080201084817.GB10969@uranus.ravnborg.org> <47A30604.6070602@snapgear.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47A30604.6070602@snapgear.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1509
Lines: 46

On Fri, Feb 01, 2008 at 09:44:04PM +1000, Greg Ungerer wrote:
> 
> Hi Sam,
> 
> Sam Ravnborg wrote:
> >On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote:
> >>Switch to platform style configuration for 520x ColdFire parts.
> >>Initial support is for the UARTs. DMA support moved to common code
> >>for all ColdFire parts.
> >>
> >>+static struct mcf_platform_uart m520x_uart_platform[] = {
> >>+	{
> >>+		.mapbase	= MCF_MBAR + MCFUART_BASE1,
> >>+		.irq		= MCFINT_VECBASE + MCFINT_UART0,
> >>+	},
> >>+	{
> >>+		.mapbase 	= MCF_MBAR + MCFUART_BASE2,
> >>+		.irq		= MCFINT_VECBASE + MCFINT_UART1,
> >>+	},
> >>+	{
> >>+		.mapbase 	= MCF_MBAR + MCFUART_BASE3,
> >>+		.irq		= MCFINT_VECBASE + MCFINT_UART2,
> >>+	},
> >>+	{ },
> >>+};
> >const?
> >Same comments for the rest of the patch and the other similar patches.
> >
> >Note: Use __initdataconst for const data as replacement for __initdata.
> 
> I am confused, __initdataconst?

Newly introduced...
We only had __*initdata before and therefore we could not
annotate both non-const and const data in a mix - gcc would barf out.

So we added a new member of the set of annotations:
__initconst used to annotate const data.
[I see - I had a spelling error above - I guess that why I confused you]

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/