Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp169491lqp; Wed, 22 May 2024 00:15:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXfJb2fXI3yXAi++jwnC5qd4zIqoBPfmF+70PqJpCOvJjs4SGXwPGWRVrX8vLFE49A0syew+szjteUpZBazuunOVFz/nYjEjZvks9F5Qw== X-Google-Smtp-Source: AGHT+IHbgdhpu7jxkgEhXVpCHrRsKzar+QlhwufvCtqPsU8oGN0K6RhinWT4CWDNWaHUrAG5dPli X-Received: by 2002:a05:6a20:9f4e:b0:1b1:fede:59cb with SMTP id adf61e73a8af0-1b1fede5cb5mr141044637.0.1716362106665; Wed, 22 May 2024 00:15:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716362106; cv=pass; d=google.com; s=arc-20160816; b=qhn0k76q2u9W+XHjseWJxGsHzu/DUr0vlIWzu3WEQLSzpwPRRHNyNZNpqfVwmVf/Lw mu8DfpBLNmPyGKtpfaKKIg3Wm+HBufZEzYCt5lz0bTJe/AImW+vINuHbDbJRmySuVDJq pFVuyLk0UzP74nlUvFpAUisxuvF4mNiKu/e+iR0y+j4ZRAsGpZUTkQgzd9s1Td2xOzZR cTGK4vWcq/X0qAWxSoPDV6zr5JuBlNBZ87wNWItmI90IM5Q6lTWvd3TlxniV/+Cmu/Xg Nz/oKrod59fewrCY8A3nHGF/bGFQzUzIaE3k/fPoVpx75QgciXfSwpFRAvm7fS9yXLsU e2mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rhDASxfnXWKSWVpkzKnUX2gLlTpE0EJRnGzquY5eFhM=; fh=3nLVuiThjyqICc3bXh/Ut6xLhZi321r9VCn3cZoq2CM=; b=wGLQPfgZwa+EOjSqAZebulyswB7OQS1+06zbUqnbICcp7y9DnVDI3hrv+UP0LihPFM 8XnM4HO8OpZ1bJHDNnhlhVoXk/QaObWnlJXfa8RBq2SZCjYEU3hnAMDhQbdji1XuLQV7 yVHU8QF+l2wVR+VPvPiesv49rdjJPWxI7TxOUlgGeB+y8nN7Hu65LodSkphlyTJT16Ly oofOJ4zHVeDKwyIcEQfvsuFbbuXykAelwjOPeWO4dcV9dVhoH6w7kbTpMii/CBi06lZ3 Da7cqEYnOIKZLBfOD8jAK3oIP/Suj01Tyr+HnHjTSu8n7yJELTGzPbpF9n6xqffuh4oC yD1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KxUDh4A7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-64b8a33a2c7si16372299a12.335.2024.05.22.00.15.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 00:15:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-185844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KxUDh4A7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-185844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-185844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DDFD5B21B76 for ; Wed, 22 May 2024 07:14:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A53B57CF18; Wed, 22 May 2024 07:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KxUDh4A7" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD47D7BAF7; Wed, 22 May 2024 07:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716362072; cv=none; b=OtynCIumofW9ft4nVC+2Zv8t+gBnAsSErWvhhP4Z1Wk39znpjNAhfYbMw0uJUFo8/tHvOSajaFzFde3Bp4qxJAdjquI1qK+2mHbL4TRXjSnbgYyd76jw+f9CXqKXiHWIyUCmXixjowAaLX/UjF/jWcmThd4TiB68BlCu9VjdU6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716362072; c=relaxed/simple; bh=o7FelwEYe06bUj5gigSKOWEN1hyHxbXUGTMgm7PhL9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h1O/f4ypO85NuEnv9Q6up9NtvMkJ1HkNgqo+WbDIBHyo7FoU1u6QnN9XGupjfsdi3UXw4537iE9SEn6LRxUfMIe4i1F5TDQlcNhHLU7jeHRJKMhsctgtyRYMfEUEVMrbWYoS7HQdA89hm3YT9OMPoiRK/jlDOAju4G8/WJyEf9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KxUDh4A7; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8693DC2BD11; Wed, 22 May 2024 07:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716362071; bh=o7FelwEYe06bUj5gigSKOWEN1hyHxbXUGTMgm7PhL9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KxUDh4A73NHTC6Uo8h5Ypzmu20FS3YX6acckvMWdiTXlPRBjHCRk0EBbJl9S64aw7 fvi2zjqqoHjbD8jQyI1RMGX+yQx0yPJAEnWSLlpK9yTT0aatU/SRonCaKuyKmVGbNH 3HqrddQuCxvyfWafJoMknIMWKMebVIPmr5pz3n4sa9urXda/xmbnk9J8jWy3L7ypdD V1UvaZyoATvDw+yBeJObfOx70Af9oi6mTC5NVQw+byDXa4FRe2gG5/Hu+oF/RQiMBr aYar/GPGVKNDfbmSkaX4NWa83bKOiAMWu4xVSJI4C1GotroqgvH+ILaWPJpAEHlyM1 es738P4O+j5QQ== From: Christian Brauner To: Steve French , David Howells Cc: Christian Brauner , Jeff Layton , Enzo Matsumiya , Jens Axboe , Matthew Wilcox , netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfs: Fix setting of BDP_ASYNC from iocb flags Date: Wed, 22 May 2024 09:14:20 +0200 Message-ID: <20240522-weltmeere-rammt-70f03e24b8b4@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <316306.1716306586@warthog.procyon.org.uk> References: <316306.1716306586@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1256; i=brauner@kernel.org; h=from:subject:message-id; bh=o7FelwEYe06bUj5gigSKOWEN1hyHxbXUGTMgm7PhL9Q=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaT5zvZ/VJrSsYxv51y3TfmcQte5fa4UZafWckj9j9mw2 PJaYfO/jlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgIlUrWD4n5pi88L397Z6Xbv2 O1r3t/Z9dXA+H9T4a6/78o9nxIPZgxkZWj89LFFMex2/tuIsx+tL+ZE/tl/mFI60cZxvEvT/lTY 7AwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Tue, 21 May 2024 16:49:46 +0100, David Howells wrote: > Fix netfs_perform_write() to set BDP_ASYNC if IOCB_NOWAIT is set rather > than if IOCB_SYNC is not set. It reflects asynchronicity in the sense of > not waiting rather than synchronicity in the sense of not returning until > the op is complete. > > Without this, generic/590 fails on cifs in strict caching mode with a > complaint that one of the writes fails with EAGAIN. The test can be > distilled down to: > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] netfs: Fix setting of BDP_ASYNC from iocb flags https://git.kernel.org/vfs/vfs/c/33c9d7477ef1